From: "Paul E. McKenney" <paulmck@kernel.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
rcu@vger.kernel.org, urezki@gmail.com, boqun.feng@gmail.com,
Neeraj Upadhyay <neeraju@codeaurora.org>,
joel@joelfernandes.org
Subject: Re: [PATCH 0/4] rcu: Unify a bit [non-]PREEMPT expedited quiescent state report
Date: Tue, 28 Sep 2021 11:13:32 -0700 [thread overview]
Message-ID: <20210928181332.GA2598698@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <20210916121048.36623-1-frederic@kernel.org>
On Thu, Sep 16, 2021 at 02:10:44PM +0200, Frederic Weisbecker wrote:
> This eventually removes rcu_data.exp_deferred_qs to use
> rcu_data.cpu no_qs.b.exp instead.
>
> For those like me who need a headlamp to walk there: https://ibb.co/3d06r0V
>
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> rcu/dev
>
> HEAD: 7d9d8a0c6141f95cbac4367b12e755bfabb383ee
Applied and pushed with some additional marking and commit-log editing.
The marking is needed because rcu_qs() can be invoked with interrupts
enabled, which can result in a low-probability data race with the
expedited IPI handler rcu_exp_handler(). There was another access in
sync_sched_exp_online_cleanup() than needed marking, so I am queuing a
separate commit for that one.
I suspect that this problem predated your series. This is a low
probability data race, so KCSAN might be hard-pressed to spot it.
Anyway, the result in much much nicer with the converged use of the
->cpu_no_qs.b.exp field, so thank you!!!
Might simplify a few of your future headlamp diagrams as well? ;-)
Thanx, Paul
> Thanks,
> Frederic
> ---
>
> Frederic Weisbecker (4):
> rcu: Ignore rdp.cpu_no_qs.b.exp on premptible RCU's rcu_qs()
> rcu: Remove useless WRITE_ONCE() on rcu_data.exp_deferred_qs
> rcu: Move rcu_data.cpu_no_qs.b.exp reset to rcu_export_exp_rdp()
> rcu: Remove rcu_data.exp_deferred_qs and convert to rcu_data.cpu no_qs.b.exp
>
>
> kernel/rcu/tree.h | 1 -
> kernel/rcu/tree_exp.h | 6 +++---
> kernel/rcu/tree_plugin.h | 24 +++++++++++++-----------
> 3 files changed, 16 insertions(+), 15 deletions(-)
prev parent reply other threads:[~2021-09-28 18:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 12:10 [PATCH 0/4] rcu: Unify a bit [non-]PREEMPT expedited quiescent state report Frederic Weisbecker
2021-09-16 12:10 ` [PATCH 1/4] rcu: Ignore rdp.cpu_no_qs.b.exp on premptible RCU's rcu_qs() Frederic Weisbecker
2021-09-16 12:10 ` [PATCH 2/4] rcu: Remove useless WRITE_ONCE() on rcu_data.exp_deferred_qs Frederic Weisbecker
2021-09-16 16:43 ` Paul E. McKenney
2021-09-16 21:05 ` Frederic Weisbecker
2021-09-17 18:10 ` Paul E. McKenney
2021-09-17 22:00 ` Frederic Weisbecker
2021-09-16 12:10 ` [PATCH 3/4] rcu: Move rcu_data.cpu_no_qs.b.exp reset to rcu_export_exp_rdp() Frederic Weisbecker
2021-09-16 12:10 ` [PATCH 4/4] rcu: Remove rcu_data.exp_deferred_qs and convert to rcu_data.cpu no_qs.b.exp Frederic Weisbecker
2021-09-16 16:40 ` [PATCH 0/4] rcu: Unify a bit [non-]PREEMPT expedited quiescent state report Paul E. McKenney
2021-09-28 18:13 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928181332.GA2598698@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neeraju@codeaurora.org \
--cc=rcu@vger.kernel.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).