From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 892A7C433E5 for ; Fri, 17 Jul 2020 19:05:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 688062064C for ; Fri, 17 Jul 2020 19:05:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UMpy7eBg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728459AbgGQTFc (ORCPT ); Fri, 17 Jul 2020 15:05:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728453AbgGQTF1 (ORCPT ); Fri, 17 Jul 2020 15:05:27 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13721C0619D3 for ; Fri, 17 Jul 2020 12:05:27 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id h22so13868925lji.9 for ; Fri, 17 Jul 2020 12:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=EHhwNWLvCGKwFX6ZeCk25F8g9x2pupMKT7Bn+2O6siI=; b=UMpy7eBg0VQk13Zh0CsA8daqqCqMYLR/yLgZvVSL0lJ8/e5Ix44NjgigL3+q8XJArC +CoZF6icBgyJrPruDpKiDqs3SPz2T9oivrXhdcRHtNzZ1eOY09EfmGogrMEiKoqjN8Tf QfSD4InjPcIuMhztE9TSwtLzGwGlEqO2hK1TlNN3tpgoD/IpL93Q8TOpldntF8RTIa9i C8ukkczG2UxL4WrwjzmXVCfquGoET/KgUjsKal4Q1IavPiGqE2sp7z7Ky8vMrNAWrbHJ dh1pCRPAhK/qgJYywFwZzK5mejpW5pcI+fhWKbs7znm9DT4r7gpOB4C5y4W8oNfI1t7j EZsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EHhwNWLvCGKwFX6ZeCk25F8g9x2pupMKT7Bn+2O6siI=; b=bjz0pIl0JJBwPgz8hajSAxlOc8V1fUI2hqJpJs/5tgJVgTKX7wR0u3bJqa16OgTmAz hfYNNdeTfhjYb7jFWmXa6zcCwXVa6X8fF4fbs+7y8RoH4Jl5BdPl0FGsx0781qVtViNN PtYYPM/46H/xz0TdAYieUPbjl+Sjm+X5aaHdSJwcXcYBdjj47rbokpaE/3cgZp1c0Iwt as0T+2VH2MGjH0eMWWHrfDJr12F5KyRrR93Z0qkvDHP+NAfeTZgXq4V5eYEzu0WVoOdB UlL4i5pWjbD98WQkQaIf/Mlemv+lPl9dCHokrF5RJQCD2KZP7HXCyszl74uZV9BNqyzI IHcw== X-Gm-Message-State: AOAM5309YGV81u+HYg+SmTjW8OKScxOpO+R11s6YeCjOM7Q65oc5lZIr nleJouyn1foldcYTzg4FeReeA48YjaoAYCwPw1ApfA== X-Google-Smtp-Source: ABdhPJzA2lclNj5LaSPAOhsYYmx7y36gm/usqNFraHHlhKV4rNqxpPH0IXWB5YiqK4pOf3QGE+Q7RO/aAlHNo2NWhrU= X-Received: by 2002:a2e:9b42:: with SMTP id o2mr4877549ljj.102.1595012725372; Fri, 17 Jul 2020 12:05:25 -0700 (PDT) MIME-Version: 1.0 References: <20200712131003.23271-1-madhuparnabhowmik10@gmail.com> <20200712131003.23271-2-madhuparnabhowmik10@gmail.com> <20200712160856.GW9247@paulmck-ThinkPad-P72> <20200717170747.GW9247@paulmck-ThinkPad-P72> In-Reply-To: <20200717170747.GW9247@paulmck-ThinkPad-P72> From: Naresh Kamboju Date: Sat, 18 Jul 2020 00:35:12 +0530 Message-ID: Subject: Re: [PATCH 2/2] kvm: mmu: page_track: Fix RCU list API usage To: "Paul E. McKenney" , madhuparnabhowmik10@gmail.com Cc: Dexuan-Linux Cui , Josh Triplett , Joel Fernandes , Paolo Bonzini , rcu@vger.kernel.org, open list , X86 ML , kvm list , frextrite@gmail.com, lkft-triage@lists.linaro.org, Dexuan Cui , juhlee@microsoft.com, =?UTF-8?B?RGFuaWVsIETDrWF6?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: rcu-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org Hi Paul, > I am not seeing this here. Do you notice any warnings while building linux next master for x86_64 architecture ? > Could you please let us know what compiler > and command-line options you are using to generate this? We have two build systems one showing it as error and build breaks and another one showing it as warning and build pass. tool chain: gcc 9.3.0 build command: make -sk KBUILD_BUILD_USER=3DTuxBuild -C/linux -j16 ARCH=3Dx86 HOSTCC=3Dgcc CC=3D"sccache gcc" O=3Dbuild metadata: git_repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-ne= xt.git, target_arch: x86, toolchain: gcc-9, git_short_log: aab7ee9f8ff0 (\Add linux-next specific files for 2020071= 7\), git_sha: aab7ee9f8ff0110bfcd594b33dc33748dc1baf46, git_describe: next-20200717, kernel_version: 5.8.0-rc5, warning log, -- make -sk KBUILD_BUILD_USER=3DTuxBuild -C/linux -j16 ARCH=3Dx86 HOSTCC=3Dgcc CC=3D"sccache gcc" O=3Dbuild # In file included from ../include/linux/pid.h:5, from ../include/linux/sched.h:14, from ../include/linux/kvm_host.h:12, from ../arch/x86/kvm/mmu/page_track.c:14: ../arch/x86/kvm/mmu/page_track.c: In function =E2=80=98kvm_page_track_write= =E2=80=99: ../include/linux/rculist.h:727:30: warning: left-hand operand of comma expression has no effect [-Wunused-value] 727 | for (__list_check_srcu(cond), \ | ^ ../arch/x86/kvm/mmu/page_track.c:232:2: note: in expansion of macro =E2=80=98hlist_for_each_entry_srcu=E2=80=99 232 | hlist_for_each_entry_srcu(n, &head->track_notifier_list, node, | ^~~~~~~~~~~~~~~~~~~~~~~~~ ../arch/x86/kvm/mmu/page_track.c: In function =E2=80=98kvm_page_track_flush= _slot=E2=80=99: ../include/linux/rculist.h:727:30: warning: left-hand operand of comma expression has no effect [-Wunused-value] 727 | for (__list_check_srcu(cond), \ | ^ ../arch/x86/kvm/mmu/page_track.c:258:2: note: in expansion of macro =E2=80=98hlist_for_each_entry_srcu=E2=80=99 258 | hlist_for_each_entry_srcu(n, &head->track_notifier_list, node, | ^~~~~~~~~~~~~~~~~~~~~~~~~ arch/x86/kvm/svm/svm.o: warning: objtool: svm_flush_tlb_gva()+0x12: call without frame pointer save/setup kernel/bpf/core.o: warning: objtool: ___bpf_prog_run.cold()+0x7: call without frame pointer save/setup ref: https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/643978120 > Thanx, Paul - Naresh