From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52BD9C0650F for ; Sun, 11 Aug 2019 22:12:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24A3D2085A for ; Sun, 11 Aug 2019 22:12:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="mvrBrR8g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbfHKWMp (ORCPT ); Sun, 11 Aug 2019 18:12:45 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:42742 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726053AbfHKWMp (ORCPT ); Sun, 11 Aug 2019 18:12:45 -0400 Received: by mail-lf1-f68.google.com with SMTP id s19so10339342lfb.9 for ; Sun, 11 Aug 2019 15:12:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FY7aY7/rAMquy8xmrOkqN/GNbl5YhGEDuc/fn8Fq/bE=; b=mvrBrR8gHlX5FiGSQWTmftyc/WrLC8GK2OQWXmkeIioVsLiXcOkp4aoPVfaH7Ntu/Y byc1Jo0B65TGpASFNSjY3jaml5RAMwEmQ79/qGJDJP2YXsNsUVquOSfF3DQGLgOXUIkA MoRd3Em/NfWyaY+LtaaJi8gU5N8gb6XkqxMG0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FY7aY7/rAMquy8xmrOkqN/GNbl5YhGEDuc/fn8Fq/bE=; b=uPfQISLSS3nrv/vEKMAH/pc5GR7LRIQb66BoX8WarxoQVSJQvRfQGxdNXcS4mye0r8 6W0ikhxpJhYiRK1KE7ci22gqUMsznY7CPltK2kFFmZkKJmSivSrGOigx6+qlHdDfnC7j HcEU3g7XmJ9LteL54qAhdrP2+jQbcpCTS3hIk8Wwz0/8Lm107clZiSKX//cyHw5C1eOA eSIJkBpaHjZYQ2vBC2Rp+bQY59bsXKxUZJf5ZrfFEjZ381DEIlgjGgTmMLZ7hH2YmBsD yox1/bzKst7XU2gFXaFXn3NfjGwp10tLXPY/QEH6AjjNsFEUxSreaY/MEzsU9tV+uFDl NGrg== X-Gm-Message-State: APjAAAWyxfWWFLPAunhB9DOsb+6gRHy7HFnj53WE9Gzz5Vc8M2wz3VNG GYabbZOGMuvq9X/cewOCqOJAy6eHkWrWSvrSDMF0eQ== X-Google-Smtp-Source: APXvYqyukhEgHZH0kh2WWC+7VgUH9yYc4gTR2/ZkRvOBjbdCjMywvVHb4kU8/1EL05AP0OSXHuXHNwywT1NnRZ5qxKE= X-Received: by 2002:a19:674d:: with SMTP id e13mr13993327lfj.176.1565561563343; Sun, 11 Aug 2019 15:12:43 -0700 (PDT) MIME-Version: 1.0 References: <20190811221111.99401-1-joel@joelfernandes.org> In-Reply-To: <20190811221111.99401-1-joel@joelfernandes.org> From: Joel Fernandes Date: Sun, 11 Aug 2019 18:12:32 -0400 Message-ID: Subject: Re: [PATCH 1/3] workqueue: Convert for_each_wq to use built-in list check (v2) To: LKML Cc: Greg Kroah-Hartman , Jonathan Corbet , Josh Triplett , Lai Jiangshan , "open list:DOCUMENTATION" , Mathieu Desnoyers , "Paul E. McKenney" , "Rafael J. Wysocki" , rcu , Steven Rostedt , Tejun Heo Content-Type: text/plain; charset="UTF-8" Sender: rcu-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org On Sun, Aug 11, 2019 at 6:11 PM Joel Fernandes (Google) wrote: > > list_for_each_entry_rcu now has support to check for RCU reader sections > as well as lock. Just use the support in it, instead of explicitly > checking in the caller. > > Signed-off-by: Joel Fernandes (Google) Tejun, Could you please Ack this patch? I have resent it here. Thank you, - Joel > --- > kernel/workqueue.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index 601d61150b65..e882477ebf6e 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -364,11 +364,6 @@ static void workqueue_sysfs_unregister(struct workqueue_struct *wq); > !lockdep_is_held(&wq_pool_mutex), \ > "RCU or wq_pool_mutex should be held") > > -#define assert_rcu_or_wq_mutex(wq) \ > - RCU_LOCKDEP_WARN(!rcu_read_lock_held() && \ > - !lockdep_is_held(&wq->mutex), \ > - "RCU or wq->mutex should be held") > - > #define assert_rcu_or_wq_mutex_or_pool_mutex(wq) \ > RCU_LOCKDEP_WARN(!rcu_read_lock_held() && \ > !lockdep_is_held(&wq->mutex) && \ > @@ -425,9 +420,8 @@ static void workqueue_sysfs_unregister(struct workqueue_struct *wq); > * ignored. > */ > #define for_each_pwq(pwq, wq) \ > - list_for_each_entry_rcu((pwq), &(wq)->pwqs, pwqs_node) \ > - if (({ assert_rcu_or_wq_mutex(wq); false; })) { } \ > - else > + list_for_each_entry_rcu((pwq), &(wq)->pwqs, pwqs_node, \ > + lock_is_held(&(wq->mutex).dep_map)) > > #ifdef CONFIG_DEBUG_OBJECTS_WORK > > -- > 2.23.0.rc1.153.gdeed80330f-goog >