rcu.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joel Fernandes <joel@joelfernandes.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Uladzislau Rezki <urezki@gmail.com>,
	Neeraj Upadhyay <neeraju@codeaurora.org>,
	Liu Song <fishland@aliyun.com>,
	liu.song11@zte.com.cn, rcu <rcu@vger.kernel.org>
Subject: Re: [PATCH] rcu: Use per_cpu_ptr to get the pointer of per_cpu variable
Date: Thu, 1 Jul 2021 16:03:58 -0400	[thread overview]
Message-ID: <CAEXW_YT9emLvb=n5mHgg_BsGH=mdDKgN6VOLdHwJSfc+zf1jSQ@mail.gmail.com> (raw)
In-Reply-To: <20210701195701.GG4397@paulmck-ThinkPad-P17-Gen-1>

On Thu, Jul 1, 2021 at 3:57 PM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> On Thu, Jul 01, 2021 at 08:39:33PM +0200, Uladzislau Rezki wrote:
> > On Thu, Jul 01, 2021 at 10:35:43PM +0530, Neeraj Upadhyay wrote:
> > >
> > >
> > > On 7/1/2021 10:01 PM, Paul E. McKenney wrote:
> > > > On Thu, Jul 01, 2021 at 08:24:32PM +0530, Neeraj Upadhyay wrote:
> > > > >
> > > > >
> > > > > On 6/30/2021 7:38 PM, Liu Song wrote:
> > > > > > From: Liu Song <liu.song11@zte.com.cn>
> > > > > >
> > > > > > In rcu, most codes have used per_cpu_ptr to obtain per_cpu variable
> > > > > > pointers. This patch adjusts a few codes that have not done so.
> > > > > >
> > > > >
> > > > > Minor: Can we also add below statement?
> > > > > "This patch doesn't introduce any functional change."
> > > > >
> > > > > > Signed-off-by: Liu Song <liu.song11@zte.com.cn>
> > > >
> > > > Applied with the usual wordsmithing, including adding words to this
> > > > effect, so thank you all!  I removed the obsolete chunk that Neeraj
> > > > pointed out as well.
> > > >
> > > > Please take a look and check to see if all is well.
> > > >
> > >
> > > Looks good to me
> > >
> > Same to me. Looks good.
> >
> > There are two dots though in the commit message: "change.." :)
>
> Good eyes, fixed, thank you!

LGTM as well, thanks!
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>

  reply	other threads:[~2021-07-01 20:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210630140802.39138-1-fishland@aliyun.com>
2021-06-30 18:57 ` [PATCH] rcu: Use per_cpu_ptr to get the pointer of per_cpu variable Uladzislau Rezki
2021-07-01 14:54 ` Neeraj Upadhyay
2021-07-01 16:31   ` Paul E. McKenney
2021-07-01 17:05     ` Neeraj Upadhyay
2021-07-01 18:39       ` Uladzislau Rezki
2021-07-01 19:57         ` Paul E. McKenney
2021-07-01 20:03           ` Joel Fernandes [this message]
2021-07-01 23:47             ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEXW_YT9emLvb=n5mHgg_BsGH=mdDKgN6VOLdHwJSfc+zf1jSQ@mail.gmail.com' \
    --to=joel@joelfernandes.org \
    --cc=fishland@aliyun.com \
    --cc=liu.song11@zte.com.cn \
    --cc=neeraju@codeaurora.org \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).