From: Paul Moore <paul@paul-moore.com>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: Jeff Vander Stoep <jeffv@google.com>,
SElinux list <selinux@vger.kernel.org>,
Stephen Smalley <sds@tycho.nsa.gov>,
Will Deacon <will@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
rcu@vger.kernel.org, Jovana Knezevic <jovanak@google.com>
Subject: Re: [PATCH v9] selinux: sidtab: reverse lookup hash table
Date: Thu, 5 Dec 2019 09:08:38 -0500 [thread overview]
Message-ID: <CAHC9VhSVsmu6hjmUAi2wM6wAkkQnUDx7MM1G8Ln9OLAzwFmz6A@mail.gmail.com> (raw)
In-Reply-To: <CAFqZXNvQV+syzOE0CGczzTvi9g65AUT8bdsG0YN6NcHzd5GVHQ@mail.gmail.com>
On Thu, Dec 5, 2019 at 6:47 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> On Thu, Dec 5, 2019 at 12:52 AM Paul Moore <paul@paul-moore.com> wrote:
> > On Wed, Dec 4, 2019 at 4:11 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> > > On Tue, Dec 3, 2019 at 1:33 AM Paul Moore <paul@paul-moore.com> wrote:
> > > > Thanks Jeff, as well as everyone else who contributed reviews and feedback.
> > > >
> > > > I've pulled this into a working branch and I'll be merging it with the
> > > > other sidtab patches before posting it to a "next-queue" branch for
> > > > review later this week. When done, I'll send a note to the list, as
> > > > well as the relevant patch authors; your help in reviewing the merge
> > > > would be greatly appreciated.
> > >
> > > I tried doing the merge on my own here [1], you can use it as a sanity
> > > check if we came to the same/similar result. I based it off your
> > > existing next-queue, which contains only Jeff's patch at the time of
> > > writing. I only build-tested it so far.
> >
> > Thanks, that was a good sanity check. There are some minor diffs from
> > what I ended up with, but nothing substantive that I can see.
> >
> > Although I'll be honest, the merge wasn't as bad as I thought it would
> > be; most of the fuzz was simply due shuffling and renaming of data
> > structures, which generally isn't too bad. Although I'm still
> > building the kernel to test it, so let's see if that statement still
> > holds (although it looks like it passed Stephen's testing). ;)
> >
> > If you haven't noticed already, the merge currently lives in the
> > selinux/next-queue branch; if you notice anything off, feel free to
> > send a fixup patch.
>
> It looks OK semantically when compared to my merge. I only see
> reordering/comment/whitespace differences.
Thanks for the double check. Unfortunately my kernel build locks my
test VM in early boot; it appears to be non-SELinux related and since
the test build is based on selinux/next+patches (which is based off
v5.4-rc1) I imagine there might be some unrelated problems in the
build. I'm going to rebase my test build to Linus' current and try
this again.
> > > Note that there are two whitespace cleanups included in the string
> > > cache commit that I intuitively did while resolving the merge
> > > conflicts. You might want to move those to the first commit or just
> > > ignore them.
> >
> > When looking at the combined diff between the two sidtab patches and
> > comparing it to your merge I did make a few additional small cosmetic
> > tweaks. Assuming the testing goes well, I'll probably go over
> > everything one more time to make sure the style looks okay, but today
> > I was focusing more on the correctness.
>
> The whitespace misalignment introduced by Jeff's patch is still there
> in your branch. Personally, I'd prefer that we fix them now rather
> than deferring it to a future patch, because it seems that no one ever
> has time to bother sending whitespace fixup patches :) But I'll
> understand it if you prefer not to touch it more than necessary, so I
> won't fight about this further.
Like I said, I only quickly scanned the combined diff for style
problems so it doesn't surprise me that there are still some issues.
I'll give it a closer look once I can get a kernel build passing all
the tests.
As an aside, I keep debating doing a big style-fix patch (likely
automated via astyle or similar, likely with some additional fixes by
hand, and passed through checkpatch.pl) after one of the -rc1 rebases
to clean up all these little things that have crept into the code over
the years. I dislike the idea of the churn that would likely bring,
but it should make life a little bit better, and help cut down on the
trivial "checkpatch patches" we get from time to time (although that
really hasn't been too bad of an issue).
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2019-12-05 14:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 9:33 [PATCH v9] selinux: sidtab: reverse lookup hash table Jeff Vander Stoep
2019-11-22 14:21 ` Stephen Smalley
2019-12-03 0:32 ` Paul Moore
2019-12-04 9:11 ` Ondrej Mosnacek
2019-12-04 15:48 ` Stephen Smalley
2019-12-04 23:52 ` Paul Moore
2019-12-05 11:48 ` Ondrej Mosnacek
2019-12-05 14:08 ` Paul Moore [this message]
2019-12-05 17:41 ` Paul Moore
2019-12-05 18:10 ` Stephen Smalley
2019-12-05 18:14 ` Paul Moore
2019-12-06 0:50 ` Paul Moore
2019-12-06 13:45 ` Stephen Smalley
2019-12-06 15:08 ` Paul Moore
2019-12-09 21:17 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhSVsmu6hjmUAi2wM6wAkkQnUDx7MM1G8Ln9OLAzwFmz6A@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=jeffv@google.com \
--cc=jovanak@google.com \
--cc=omosnace@redhat.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).