From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94E7CC6377D for ; Thu, 22 Jul 2021 14:00:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 724346128A for ; Thu, 22 Jul 2021 14:00:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232148AbhGVNTw (ORCPT ); Thu, 22 Jul 2021 09:19:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:36474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232105AbhGVNTw (ORCPT ); Thu, 22 Jul 2021 09:19:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0BE6661244; Thu, 22 Jul 2021 14:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626962426; bh=vYStKlL0lfpbehwAhl3t7pf+aiD3WIfX+cNEvQkFKEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BU9bztdBMi5Ej7JJmuiMsLpZJlyrnjWZ6zNuH77O+G/Fz0hVvxfQiPT8ddS+bEnjE Ad9P3IjoLHTovV15f412VlMK5ozt/bjbe3EZGqB+aauu3E3EgW3FJXiZB8PzSToctp cw5jr6AEqTH5dFXzEs3knNNtNVuvd87hAIfYCOJU= Date: Thu, 22 Jul 2021 16:00:24 +0200 From: Greg KH To: Matthew Wilcox Cc: Zhouyi Zhou , Chris Clayton , Oleksandr Natalenko , Miaohe Lin , Boqun Feng , paulmck@kernel.org, linux-kernel , stable@vger.kernel.org, Chris Rankin , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , rcu , Andrew Morton , Linux-MM , "Huang, Ying" Subject: Re: linux-5.13.2: warning from kernel/rcu/tree_plugin.h:359 Message-ID: References: <5812280.fcLxn8YiTP@natalenko.name> <2237123.PRLUojbHBq@natalenko.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org On Thu, Jul 22, 2021 at 03:26:52PM +0200, Greg KH wrote: > On Thu, Jul 22, 2021 at 01:36:02PM +0100, Matthew Wilcox wrote: > > On Thu, Jul 22, 2021 at 04:57:57PM +0800, Zhouyi Zhou wrote: > > > Thanks for reviewing, > > > > > > What I have deduced from the dmesg is: > > > In function do_swap_page, > > > after invoking > > > 3385 si = get_swap_device(entry); /* rcu_read_lock */ > > > and before > > > 3561 out: > > > 3562 if (si) > > > 3563 put_swap_device(si); > > > The thread got scheduled out in > > > 3454 locked = lock_page_or_retry(page, vma->vm_mm, vmf->flags); > > > > > > I am only familiar with Linux RCU subsystem, hope mm people can solve our > > > confusions. > > > > I don't understamd why you're still talking. The problem is understood. > > You need to revert the unnecessary backport of 2799e77529c2 and > > 2efa33fc7f6e > > Sorry for the delay, will go do so in a minute... Both now reverted from 5.10.y and 5.13.y. thanks, greg k-h