From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Jason Wessel <jason.wessel@windriver.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Douglas Anderson <dianders@chromium.org>,
Aaron Tomlin <atomlin@redhat.com>,
Luis Chamberlain <mcgrof@kernel.org>,
kgdb-bugreport@lists.sourceforge.net,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
David Gow <davidgow@google.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
tangmeng <tangmeng@uniontech.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <quic_neeraju@quicinc.com>,
Josh Triplett <josh@joshtriplett.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
rcu@vger.kernel.org
Subject: locking API: was: [PATCH printk v1 00/18] serial: 8250: implement non-BKL console
Date: Tue, 28 Mar 2023 15:33:46 +0200 [thread overview]
Message-ID: <ZCLsuln0nHr7S9a5@alley> (raw)
In-Reply-To: <87wn3zsz5x.fsf@jogness.linutronix.de>
On Thu 2023-03-02 21:04:50, John Ogness wrote:
> Implement the necessary callbacks to allow the 8250 console driver
> to perform as a non-BKL console. Remove the implementation for the
> legacy console callback (write) and add implementations for the
> non-BKL consoles (write_atomic, write_thread, port_lock) and add
> CON_NO_BKL to the initial flags.
>
> This is an all-in-one commit meant only for testing the new printk
> non-BKL infrastructure. It is not meant to be included mainline in
> this form. In particular, it includes mainline driver fixes that
> need to be submitted individually.
>
> Although non-BKL consoles can coexist with legacy consoles, you
> will only receive all the benefits of the non-BKL consoles, if
> this console driver is the only console. That means no netconsole,
> no tty1, no earlyprintk, no earlycon. Just the uart8250.
>
> For example: console=ttyS0,115200
>
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> +static void atomic_console_reacquire(struct cons_write_context *wctxt,
> + struct cons_write_context *wctxt_init)
> +{
> + memcpy(wctxt, wctxt_init, sizeof(*wctxt));
> + while (!console_try_acquire(wctxt)) {
> + cpu_relax();
> + memcpy(wctxt, wctxt_init, sizeof(*wctxt));
> + }
> +}
> +
> /*
> - * Print a string to the serial port using the device FIFO
> - *
> - * It sends fifosize bytes and then waits for the fifo
> - * to get empty.
> + * It should be possible to support a hostile takeover in an unsafe
> + * section if it is write_atomic() that is being taken over. But where
> + * to put this policy?
> */
> -static void serial8250_console_fifo_write(struct uart_8250_port *up,
> - const char *s, unsigned int count)
> +bool serial8250_console_write_atomic(struct uart_8250_port *up,
> + struct cons_write_context *wctxt)
> {
> - int i;
> - const char *end = s + count;
> - unsigned int fifosize = up->tx_loadsz;
> - bool cr_sent = false;
> -
> - while (s != end) {
> - wait_for_lsr(up, UART_LSR_THRE);
> -
> - for (i = 0; i < fifosize && s != end; ++i) {
> - if (*s == '\n' && !cr_sent) {
> - serial_out(up, UART_TX, '\r');
> - cr_sent = true;
> - } else {
> - serial_out(up, UART_TX, *s++);
> - cr_sent = false;
> - }
> + struct cons_write_context wctxt_init = {};
> + struct cons_context *ctxt_init = &ACCESS_PRIVATE(&wctxt_init, ctxt);
> + struct cons_context *ctxt = &ACCESS_PRIVATE(wctxt, ctxt);
> + bool can_print = true;
> + unsigned int ier;
> +
> + /* With write_atomic, another context may hold the port->lock. */
> +
> + ctxt_init->console = ctxt->console;
> + ctxt_init->prio = ctxt->prio;
> + ctxt_init->thread = ctxt->thread;
> +
> + touch_nmi_watchdog();
> +
> + /*
> + * Enter unsafe in order to disable interrupts. If the console is
> + * lost before the interrupts are disabled, bail out because another
> + * context took over the printing. If the console is lost after the
> + * interrutps are disabled, the console must be reacquired in order
> + * to re-enable the interrupts. However in that case no printing is
> + * allowed because another context took over the printing.
> + */
> +
> + if (!console_enter_unsafe(wctxt))
> + return false;
> +
> + if (!__serial8250_clear_IER(up, wctxt, &ier))
> + return false;
> +
> + if (console_exit_unsafe(wctxt)) {
> + can_print = atomic_print_line(up, wctxt);
> + if (!can_print)
> + atomic_console_reacquire(wctxt, &wctxt_init);
I am trying to review the 9th patch adding console_can_proceed(),
console_enter_unsafe(), console_exit_unsafe() API. And I wanted
to see how the struct cons_write_context was actually used.
I am confused now. I do not understand the motivation for the extra
@wctxt_init copy and atomic_console_reacquire().
Why do we need a copy? And why we need to reacquire it?
My feeling is that it is needed only to call
console_exit_unsafe(wctxt) later. Or do I miss anything?
> +
> + if (can_print) {
> + can_print = console_can_proceed(wctxt);
> + if (can_print)
> + wait_for_xmitr(up, UART_LSR_BOTH_EMPTY);
> + else
> + atomic_console_reacquire(wctxt, &wctxt_init);
> + }
> + } else {
> + atomic_console_reacquire(wctxt, &wctxt_init);
> + }
> +
> + /*
> + * Enter unsafe in order to enable interrupts. If the console is
> + * lost before the interrupts are enabled, the console must be
> + * reacquired in order to re-enable the interrupts.
> + */
> +
> + for (;;) {
> + if (console_enter_unsafe(wctxt) &&
> + __serial8250_set_IER(up, wctxt, ier)) {
> + break;
> }
> +
> + /* HW-IRQs still disabled. Reacquire to enable them. */
> + atomic_console_reacquire(wctxt, &wctxt_init);
> }
> +
> + console_exit_unsafe(wctxt);
> +
> + return can_print;
> }
Best Regards,
Petr
next prev parent reply other threads:[~2023-03-28 13:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 19:56 [PATCH printk v1 00/18] threaded/atomic console support John Ogness
2023-03-02 19:56 ` [PATCH printk v1 17/18] rcu: Add atomic write enforcement for rcu stalls John Ogness
2023-04-13 12:10 ` Petr Mladek
2023-03-02 19:58 ` [PATCH printk v1 00/18] serial: 8250: implement non-BKL console John Ogness
2023-03-28 13:33 ` Petr Mladek [this message]
2023-03-28 13:57 ` locking API: was: " John Ogness
2023-03-28 15:10 ` Petr Mladek
2023-03-28 21:47 ` John Ogness
2023-03-29 8:03 ` Petr Mladek
2023-03-28 13:59 ` [PATCH printk v1 00/18] POC: serial: 8250: implement nbcon console John Ogness
2023-03-09 10:55 ` [PATCH printk v1 00/18] threaded/atomic console support Daniel Thompson
2023-03-09 11:14 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCLsuln0nHr7S9a5@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=atomlin@redhat.com \
--cc=daniel.thompson@linaro.org \
--cc=daniel.vetter@ffwll.ch \
--cc=davidgow@google.com \
--cc=dianders@chromium.org \
--cc=frederic@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jason.wessel@windriver.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=john.ogness@linutronix.de \
--cc=josh@joshtriplett.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mcgrof@kernel.org \
--cc=paulmck@kernel.org \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tangmeng@uniontech.com \
--cc=tglx@linutronix.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).