From: Markus Elfring <Markus.Elfring@web.de>
To: Valentin Schneider <valentin.schneider@arm.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
dm-devel@redhat.com, linux-block@vger.kernel.org,
rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Ingo Molnar <mingo@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Peter Zijlstra <peterz@infradead.org>,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: sched: make struct task_struct::state 32-bit
Date: Tue, 24 Sep 2019 10:07:54 +0200 [thread overview]
Message-ID: <af969579-116c-fba7-fd32-15a876ac0445@web.de> (raw)
In-Reply-To: <32d65b15-1855-e7eb-e9c4-81560fab62ea@arm.com>
> // FIXME: current not recognized as task_struct*, fixhack with regexp
> identifier current =~ "^current$";
Would you really like to use a regular expression for finding a single word?
> identifier state_var;
> position pos;
> @@
>
> (
> p->state & state_var@pos
> |
> current->state & state_var@pos
> |
I see further opportunities to make such a SmPL disjunction more succinct.
*
( ( \( p \| current \) ) -> state & state_var@pos
|
…
* How do you think about to work with a SmPL constraint
for a metavariable with the type “binary operator”?
> set_current_state(state_var@pos)
> |
> set_special_state(state_var@pos)
| \( set_current_state \| set_special_state \) (state_var@pos)
> |
> signal_pending_state(state_var@pos, p)
> |
> signal_pending_state(state_var@pos, current)
| signal_pending_state(state_var@pos, \( p \| current \) )
Regards,
Markus
next prev parent reply other threads:[~2019-09-24 8:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 21:05 [PATCH] sched: make struct task_struct::state 32-bit Alexey Dobriyan
2019-09-02 23:02 ` Valentin Schneider
2019-09-03 16:23 ` Alexey Dobriyan
2019-09-03 16:31 ` Valentin Schneider
2019-09-03 6:51 ` [dm-devel] " Christoph Hellwig
2019-09-03 7:13 ` Peter Zijlstra
2019-09-03 17:29 ` Valentin Schneider
2019-09-03 18:19 ` Alexey Dobriyan
2019-09-03 21:51 ` Valentin Schneider
2019-09-04 12:07 ` Valentin Schneider
2019-09-04 17:48 ` Valentin Schneider
2019-09-05 15:51 ` Markus Elfring
2019-09-05 16:52 ` Valentin Schneider
2019-09-23 10:26 ` Valentin Schneider
2019-09-23 10:34 ` Julia Lawall
2019-09-23 11:26 ` Valentin Schneider
2019-09-23 11:43 ` Julia Lawall
2019-09-23 13:23 ` Valentin Schneider
2019-09-24 8:28 ` Markus Elfring
2019-09-24 8:07 ` Markus Elfring [this message]
2019-09-04 9:43 ` [PATCH] " David Laight
2019-09-04 10:25 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af969579-116c-fba7-fd32-15a876ac0445@web.de \
--to=markus.elfring@web.de \
--cc=aarcange@redhat.com \
--cc=adobriyan@gmail.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).