From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: madhuparnabhowmik04@gmail.com, mike.marciniszyn@intel.com,
jgg@ziepe.ca, paulmck@kernel.org
Cc: joel@joelfernandes.org, frextrite@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
rcu@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] infiniband: sw: rdmavt: mcast.c: Use built-in RCU list checking
Date: Fri, 14 Feb 2020 12:26:34 -0500 [thread overview]
Message-ID: <b9a48945-7fc7-2463-2b56-61ad43e54754@intel.com> (raw)
In-Reply-To: <20200114162536.20388-1-madhuparnabhowmik04@gmail.com>
On 1/14/2020 11:25 AM, madhuparnabhowmik04@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>
> Use built-in RCU and lock-checking for list_for_each_entry_rcu()
> by passing the cond argument.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> ---
> drivers/infiniband/sw/rdmavt/mcast.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rdmavt/mcast.c b/drivers/infiniband/sw/rdmavt/mcast.c
> index dd11c6fcd060..31c7f12c7665 100644
> --- a/drivers/infiniband/sw/rdmavt/mcast.c
> +++ b/drivers/infiniband/sw/rdmavt/mcast.c
> @@ -224,7 +224,7 @@ static int rvt_mcast_add(struct rvt_dev_info *rdi, struct rvt_ibport *ibp,
> }
>
> /* Search the QP list to see if this is already there. */
> - list_for_each_entry_rcu(p, &tmcast->qp_list, list) {
> + list_for_each_entry_rcu(p, &tmcast->qp_list, list, lockdep_is_held(&(ibp->lock))) {
> if (p->qp == mqp->qp) {
> ret = ESRCH;
> goto bail;
>
This one is OK. The lock is held and it is the correct one to use when
updating the list.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
next prev parent reply other threads:[~2020-02-14 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 16:25 [PATCH 3/3] infiniband: sw: rdmavt: mcast.c: Use built-in RCU list checking madhuparnabhowmik04
2020-02-14 17:26 ` Dennis Dalessandro [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-07 19:31 madhuparnabhowmik04
2020-01-07 17:35 [PATCH 1/3] infiniband: hw: hfi1: verbs.c: " madhuparnabhowmik04
2020-01-07 17:35 ` [PATCH 3/3] infiniband: sw: rdmavt: mcast.c: " madhuparnabhowmik04
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9a48945-7fc7-2463-2b56-61ad43e54754@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=frextrite@gmail.com \
--cc=jgg@ziepe.ca \
--cc=joel@joelfernandes.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=madhuparnabhowmik04@gmail.com \
--cc=mike.marciniszyn@intel.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).