regressions.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Stefan Fritsch <sf@sfritsch.de>
To: Dan Moulding <dmoulding@me.com>
Cc: bskeggs@redhat.com, christian.koenig@amd.com,
	dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	regressions@leemhuis.info, regressions@lists.linux.dev
Subject: Re: [Nouveau] Regression in 5.15 in nouveau
Date: Wed, 8 Dec 2021 18:43:37 +0100	[thread overview]
Message-ID: <011690dd-ad46-c66b-7a8e-26ad3520f14d@sfritsch.de> (raw)
In-Reply-To: <20211207204528.6740-1-dmoulding@me.com>

On 07.12.21 21:45, Dan Moulding wrote:
>> There is a pretty obvious typo in there:
>>
>> --- a/drivers/gpu/drm/nouveau/nouveau_fence.c
>> +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
>> @@ -359,7 +359,7 @@ nouveau_fence_sync(struct nouveau_bo *nvbo, struct
>> nouveau_channel *chan, bool e
>>                   fobj = dma_resv_shared_list(resv);
>>           }
>>
>> -       for (i = 0; (i < fobj ? fobj->shared_count : 0) && !ret; ++i) {
>> +       for (i = 0; i < (fobj ? fobj->shared_count : 0) && !ret; ++i) {
>>                   struct nouveau_channel *prev = NULL;
>>                   bool must_wait = true;
>>
>>
>> With that it works and I don't see the flickering in a short test. I
>> will do more testing, but maybe Dan can test, too.
>>
>> Cheers,
>> Stefan
> 
> After fixing the typo the patch is working for me, also. dmesg is also
> clean. I will continue running the patched kernel. If I see any
> issues, I will report back here.

OK, looks good: I have tested it on top of v5.15.5 for a day and no 
black flickering and no other problems. I am not qualified to review the 
patch, though.

Thanks for the quick responses to everyone.

Cheers,
Stefan

  reply	other threads:[~2021-12-08 17:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <da142fb9-07d7-24fe-4533-0247b8d16cdd@sfritsch.de>
2021-12-06 13:19 ` Regression in 5.15 in nouveau Thorsten Leemhuis
2021-12-06 13:41   ` Christian König
2021-12-06 18:37   ` [Nouveau] " Dan Moulding
2021-12-07  9:52     ` Christian König
2021-12-07 17:32       ` Karol Herbst
2021-12-07 18:30         ` Daniel Vetter
2021-12-07 19:01       ` Dan Moulding
2021-12-07 19:22         ` Stefan Fritsch
2021-12-07 20:45           ` Dan Moulding
2021-12-08 17:43             ` Stefan Fritsch [this message]
2021-12-09 10:25             ` Christian König
2021-12-21 17:24   ` Regression in 5.15 in nouveau #forregzbot Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=011690dd-ad46-c66b-7a8e-26ad3520f14d@sfritsch.de \
    --to=sf@sfritsch.de \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=dmoulding@me.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).