From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: Manuel Ullmann <labre@posteo.de>,
Jordan Leppert <jordanleppert@protonmail.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: Crash on resume after suspend (5.17.5 and 5.15.36)
Date: Wed, 4 May 2022 22:58:29 +0200 [thread overview]
Message-ID: <18466b6a-b040-c72c-e33d-fe37c5ff6a9d@applied-asynchrony.com> (raw)
In-Reply-To: <87levhnlqu.fsf@posteo.de>
On 2022-05-04 21:25, Manuel Ullmann wrote:
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.17.y&id=cbe6c3a8f8f4315b96e46e1a1c70393c06d95a4c
> Yup, that’s my fault and I reproduced this myself yesterday. I actually
> expected this to happen and attempted to test suspend with the patch,
> but must have screwed up by kexec-rebooting into an unpatched kernel
> version or something like that. I’ll disable the kexec service in the
> future, if I ever need to prepare a patch again.
>> 05:00.0 Ethernet controller: Aquantia Corp. AQC107 NBase-T/IEEE 802.3bz Ethernet Controller [AQtion] (rev 02)
> Yes, I have the same one.
>
>> Please let me know if there is any more info I can give that will help.
> Can you confirm, that hibernation works with the patch, but not without
> it? The patch was an attempt to fix it, because I had the same behaviour
Cannot test hibernation, but..
> with hibernation. I tried to make sense of the deep parameter in
> atl_resume_common pm function calls, but apparently it’s always required
> to be true and thus obsolete.
..I patched 5.15.38 to pass true as deep arg everywhere, and now resume
seems to work again reliably, 5 out of 5. \o/
> I’ll leave the cleanup of that parameter to the maintainers for mainline
> and prepare a patch. Last time I sent it against mainline. If this fixup
> of a stable patch regression should be posted differently, it would be
> nice, if someone could give me a pointer.
Send fix to mainline first, with Fixes: <mainline commit id> tag and
Cc: stable mentioning the affected versions.
cheers
Holger
next prev parent reply other threads:[~2022-05-04 20:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <refZ3y2HAXztrRkMMmFbBaF7Dz1CctWgjchSdBtcSNlpk-TL0fqLepVVHfw9qXtIQF9uFzBvFdjQiiX9Jv2zW9oaWej952s1IYwu61d1REo=@protonmail.com>
2022-05-04 15:07 ` Crash on resume after suspend (5.17.5 and 5.15.36) Jordan Leppert
2022-05-04 16:38 ` Jordan Leppert
2022-05-04 17:50 ` Holger Hoffstätte
2022-05-04 18:31 ` Holger Hoffstätte
2022-05-04 19:25 ` Manuel Ullmann
2022-05-04 20:58 ` Holger Hoffstätte [this message]
2022-05-04 22:10 ` Manuel Ullmann
[not found] ` <vcehgVc5mzweaw_ru0o1up63In2GGa9jtEWuaH8op7p2753Wfr2ezPhxFJdMPFxmpiPmrUB4XnH2nakuhC_BJby3wFa87cbpdLV-lDDb6Ko=@protonmail.com>
2022-05-04 22:21 ` Manuel Ullmann
2022-05-05 10:41 ` Jordan Leppert
2022-05-05 7:43 ` Thorsten Leemhuis
2022-05-09 6:59 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18466b6a-b040-c72c-e33d-fe37c5ff6a9d@applied-asynchrony.com \
--to=holger@applied-asynchrony.com \
--cc=davem@davemloft.net \
--cc=jordanleppert@protonmail.com \
--cc=labre@posteo.de \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).