From: Stanislaw Gruszka <stf_xl@wp.pl> To: Exuvo <exuvo@exuvo.se> Cc: Kalle Valo <kvalo@codeaurora.org>, Thorsten Leemhuis <regressions@leemhuis.info>, Stanislaw Gruszka <sgruszka@redhat.com>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, Helmut Schaa <helmut.schaa@googlemail.com>, "regressions@lists.linux.dev" <regressions@lists.linux.dev> Subject: [PATCH] rt2x00: do not mark device gone on EPROTO errors during start Date: Thu, 11 Nov 2021 15:10:03 +0100 [thread overview] Message-ID: <20211111141003.GA134627@wp.pl> (raw) In-Reply-To: <b3b9c143-485f-5fe1-312c-c64a8ce33f8a@exuvo.se> As reported by Exuvo is possible that we have lot's of EPROTO errors during device start i.e. firmware load. But after that device works correctly. Hence marking device gone by few EPROTO errors done by commit e383c70474db ("rt2x00: check number of EPROTO errors") caused regression - Exuvo device stop working after kernel update. To fix disable the check during device start. Reported-and-tested-by: Exuvo <exuvo@exuvo.se> Fixes: e383c70474db ("rt2x00: check number of EPROTO errors") Cc: stable@vger.kernel.org Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl> --- drivers/net/wireless/ralink/rt2x00/rt2x00usb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c index e4473a551241..74c3d8cb3100 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c @@ -25,6 +25,9 @@ static bool rt2x00usb_check_usb_error(struct rt2x00_dev *rt2x00dev, int status) if (status == -ENODEV || status == -ENOENT) return true; + if (!test_bit(DEVICE_STATE_STARTED, &rt2x00dev->flags)) + return false; + if (status == -EPROTO || status == -ETIMEDOUT) rt2x00dev->num_proto_errs++; else -- 2.25.4
next prev parent reply other threads:[~2021-11-11 14:10 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bff7d309-a816-6a75-51b6-5928ef4f7a8c@exuvo.se> [not found] ` <20190927080303.GA7667@redhat.com> [not found] ` <CA+GwT0B5SyRZnGLqwqOeuJK4CWMVc=dKaWre9VN8KQC6kBzKGw@mail.gmail.com> [not found] ` <20191203075736.GA701@redhat.com> [not found] ` <d74dab51-3a84-9035-d89e-ea8f63e89198@exuvo.se> [not found] ` <a8eeb0bc-95da-291a-7fb9-5d15d1174c27@exuvo.se> [not found] ` <c22673af-40e0-3af2-5ab7-69b23fc03598@exuvo.se> [not found] ` <f935dc15-08bd-2e28-fc1b-b27634c618be@exuvo.se> 2021-10-01 6:56 ` rt2x00 regression Kalle Valo 2021-10-01 8:24 ` Thorsten Leemhuis 2021-11-30 9:16 ` rt2x00 regression #forregzbot Thorsten Leemhuis 2021-11-05 13:25 ` rt2x00 regression Thorsten Leemhuis 2021-11-08 18:00 ` Thorsten Leemhuis [not found] ` <20211109073127.ga109212@wp.pl> 2021-11-09 7:31 ` Stanislaw Gruszka 2021-11-09 12:07 ` Stanislaw Gruszka 2021-11-09 15:22 ` Exuvo [not found] ` <cc85b4e8a038417b865069c6578acf50@grupawp.pl> 2021-11-10 6:59 ` Kalle Valo 2021-11-10 8:01 ` Stanislaw Gruszka 2021-11-11 10:54 ` Exuvo 2021-11-11 14:10 ` Stanislaw Gruszka [this message] 2021-11-18 6:16 ` [PATCH] rt2x00: do not mark device gone on EPROTO errors during start Thorsten Leemhuis 2021-11-19 14:19 ` Kalle Valo 2021-11-29 10:54 ` Kalle Valo [not found] <ca+gwt0b5syrznglqwqoeujk4cwmvc=dkawre9vn8kqc6kbzkgw@mail.gmail.com>
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211111141003.GA134627@wp.pl \ --to=stf_xl@wp.pl \ --cc=exuvo@exuvo.se \ --cc=helmut.schaa@googlemail.com \ --cc=kvalo@codeaurora.org \ --cc=linux-wireless@vger.kernel.org \ --cc=regressions@leemhuis.info \ --cc=regressions@lists.linux.dev \ --cc=sgruszka@redhat.com \ --subject='Re: [PATCH] rt2x00: do not mark device gone on EPROTO errors during start' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).