From: Mel Gorman <mgorman@techsingularity.net>
To: Mike Galbraith <efault@gmx.de>
Cc: Alexey Avramov <hakavlad@inbox.lv>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Rik van Riel <riel@surriel.com>, Darrick Wong <djwong@kernel.org>,
regressions@lists.linux.dev,
Linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] mm: vmscan: Reduce throttling due to a failure to make progress
Date: Tue, 30 Nov 2021 11:22:44 +0000 [thread overview]
Message-ID: <20211130112244.GQ3366@techsingularity.net> (raw)
In-Reply-To: <a20f17c4b1b5fdfade3f48375d148e97bd162dd6.camel@gmx.de>
On Tue, Nov 30, 2021 at 11:14:32AM +0100, Mike Galbraith wrote:
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index fb9584641ac7..1af12072f40e 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -1021,6 +1021,39 @@ static void handle_write_error(struct address_space *mapping,
> > unlock_page(page);
> > }
> >
> > +bool skip_throttle_noprogress(pg_data_t *pgdat)
> > +{
> > + int reclaimable = 0, write_pending = 0;
> > + int i;
> > +
> > + /*
> > + * If kswapd is disabled, reschedule if necessary but do not
> > + * throttle as the system is likely near OOM.
> > + */
> > + if (pgdat->kswapd_failures >= MAX_RECLAIM_RETRIES)
> > + return true;
> > +
> > + /*
> > + * If there are a lot of dirty/writeback pages then do not
> > + * throttle as throttling will occur when the pages cycle
> > + * towards the end of the LRU if still under writeback.
> > + */
> > + for (i = 0; i < MAX_NR_ZONES; i++) {
> > + struct zone *zone = pgdat->node_zones + i;
> > +
> > + if (!populated_zone(zone))
> > + continue;
> > +
> > + reclaimable += zone_reclaimable_pages(zone);
> > + write_pending += zone_page_state_snapshot(zone,
> > + NR_ZONE_WRITE_PENDING);
> > + }
> > + if (2 * write_pending <= reclaimable)
>
> That is always true here...
>
Always true for you or always true in general?
The intent of the check is "are a majority of reclaimable pages
marked WRITE_PENDING?". It's similar to the check that existed prior
to 132b0d21d21f ("mm/page_alloc: remove the throttling logic from the
page allocator").
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2021-11-30 11:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 15:18 [PATCH 1/1] mm: vmscan: Reduce throttling due to a failure to make progress Mel Gorman
2021-11-26 10:14 ` Vlastimil Babka
2021-11-26 10:26 ` Mike Galbraith
2021-11-26 16:12 ` Alexey Avramov
2021-11-26 16:52 ` Mel Gorman
2021-11-27 19:26 ` Alexey Avramov
2021-11-28 10:00 ` Mike Galbraith
2021-11-28 11:39 ` Mike Galbraith
2021-11-28 12:35 ` Mike Galbraith
2021-11-28 18:38 ` Mike Galbraith
2021-11-28 11:58 ` Alexey Avramov
2021-11-29 8:26 ` Mel Gorman
2021-11-29 15:01 ` Mel Gorman
2021-11-30 10:14 ` Mike Galbraith
2021-11-30 11:22 ` Mel Gorman [this message]
2021-11-30 12:00 ` Mike Galbraith
2021-11-30 12:51 ` Mike Galbraith
2021-11-30 13:09 ` Mel Gorman
2021-12-01 4:32 ` Mike Galbraith
2021-11-30 16:03 ` Alexey Avramov
2021-11-30 17:27 ` Mel Gorman
2021-11-30 17:59 ` Mike Galbraith
2021-12-01 13:01 ` Mel Gorman
2021-12-01 13:52 ` Mike Galbraith
2021-12-01 15:06 ` Mel Gorman
2021-11-30 18:38 ` Alexey Avramov
2021-12-01 14:00 ` Mel Gorman
2021-12-01 17:29 ` Darrick J. Wong
2021-12-02 9:43 ` Mel Gorman
2021-12-02 16:09 ` Darrick J. Wong
2021-12-02 3:11 ` Mike Galbraith
2021-12-02 10:13 ` Mel Gorman
2021-12-02 10:51 ` Mike Galbraith
2021-12-02 11:42 ` Alexey Avramov
2021-12-02 12:14 ` Alexey Avramov
2021-12-02 12:15 ` Mel Gorman
2021-12-02 12:22 ` Alexey Avramov
2021-12-02 13:18 Mel Gorman
2021-12-02 14:51 ` kernel test robot
2021-12-02 16:02 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130112244.GQ3366@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=djwong@kernel.org \
--cc=efault@gmx.de \
--cc=hakavlad@inbox.lv \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=regressions@lists.linux.dev \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).