From: Jakub Kicinski <kuba@kernel.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Manish Chopra <manishc@marvell.com>,
netdev@vger.kernel.org, Ariel Elior <aelior@marvell.com>,
regressions@lists.linux.dev, stable@vger.kernel.org,
it+netdev@molgen.mpg.de
Subject: Re: [EXT] Re: [PATCH net] bnx2x: fix built-in kernel driver load failure
Date: Thu, 17 Mar 2022 08:33:14 -0700 [thread overview]
Message-ID: <20220317083314.54f360b3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1986e70f-9e3b-cc64-4c15-dbc2abd1dc8d@molgen.mpg.de>
On Thu, 17 Mar 2022 14:31:45 +0100 Paul Menzel wrote:
> >> I think it’s important to document, that the firmware was not present in the
> >> initrd.
> >
> > I believe this problem has nothing to do with initrd module/FW but
> > rather a module built in the kernel/vmlinuz (CONFIG_BNX2X=y) itself,
> > A module load from initrd works fine and can access the initrd FW
> > files present in initrd file system even during the probe. For
> > example, when I had CONFIG_BNX2X=m, it loads the module fine from
> > initrd with FW files present in initrd file system. When I had
> > CONFIG_BNX2X=y, which I believe doesn't install/load module in/from
> > initrd but in kernel (vmlinuz) itself, that's where it can't access
> > the firmware file and cause the load failure.
>
> I can only say, that adding the firmware to the initrd worked around the
> problem on our side with `CONFIG_BNX2X=y`.
Hi Paul, I'd like to ship this one to Linus today. It sounds like it's
okay from functional perspective, can I improve the commit message as
you were suggesting and leave the comment / print improvements to a
later patch?
next prev parent reply other threads:[~2022-03-17 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 21:46 [PATCH net] bnx2x: fix built-in kernel driver load failure Manish Chopra
2022-03-17 7:32 ` Paul Menzel
2022-03-17 9:55 ` [EXT] " Manish Chopra
2022-03-17 13:31 ` Paul Menzel
2022-03-17 15:33 ` Jakub Kicinski [this message]
2022-03-17 16:28 ` Paul Menzel
2022-03-17 16:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317083314.54f360b3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=it+netdev@molgen.mpg.de \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).