From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Akira Shimahara <akira215corp@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stefan Wahren <stefan.wahren@chargebyte.com>,
regressions@lists.linux.dev
Subject: Re: Regression: w1_therm: sysfs w1_slave sometimes report 85 degrees Celsius
Date: Wed, 26 Apr 2023 16:01:07 +0200 [thread overview]
Message-ID: <2023042645-attentive-amends-7b0b@gregkh> (raw)
In-Reply-To: <b1093de5-9f62-6714-0063-7c719dc4f6ca@i2se.com>
On Wed, Apr 26, 2023 at 03:39:15PM +0200, Stefan Wahren wrote:
> Hi,
>
> recently we switch on our Tarragon board (i.MX6ULL) to Linux 6.1 and noticed
> that the connected 1-wire temperature sensors (w1_therm.w1_strong_pull=0)
> sometimes (~ 1 of 20 times) report 85 degrees Celsius, which is AFAIK the
> only way to report errors to the 1-wire master:
>
> sys/bus/w1/devices/28-04168158faff# cat w1_slave
> 50 05 4b 46 7f ff 0c 10 1c : crc=1c YES
> 50 05 4b 46 7f ff 0c 10 1c t=85000
>
> I wasn't able to reproduce this issue with the old kernel 4.9.
>
> After that i successfully bisected the issue to this commit:
> 67b392f7b8ed ("w1_therm: optimizing temperature read timings")
>
> Unfortunately this commit contains a lot of independent changes, which makes
> it hard to figured out the cause of this issue. So i tried to split this
> patch in seven independent changes [1]. Now i was able to bisect the cause
> further to this change [2] which seems to rework the pullup handling within
> read_therm().
>
> Looking closer at the code change and verify it some debug messages, the
> change inverted the locking behavior (before: no pullup -> keep lock, after:
> no pullup -> release lock during sleep).
>
> Before:
> if (external_power) {
> mutex_unlock(&dev_master->bus_mutex);
>
> sleep_rem = msleep_interruptible(tm);
> if (sleep_rem != 0) {
> ret = -EINTR;
> goto dec_refcnt;
> }
>
> ret = mutex_lock_interruptible(&dev_master->bus_mutex);
> if (ret != 0)
> goto dec_refcnt;
> } else if (!w1_strong_pullup) {
> sleep_rem = msleep_interruptible(tm);
> if (sleep_rem != 0) {
> ret = -EINTR;
> goto mt_unlock;
> }
> }
>
> After:
> if (strong_pullup) { /*some device need pullup */
> sleep_rem = msleep_interruptible(tm);
> if (sleep_rem != 0) {
> ret = -EINTR;
> goto mt_unlock;
> }
> } else { /*no device need pullup */
> mutex_unlock(&dev_master->bus_mutex);
>
> sleep_rem = msleep_interruptible(tm);
> if (sleep_rem != 0) {
> ret = -EINTR;
> goto dec_refcnt;
> }
>
> ret = mutex_lock_interruptible(&dev_master->bus_mutex);
> if (ret != 0)
> goto dec_refcnt;
> }
>
> I don't believe this is intended. After inverting the strong_pullup check,
> the issue wasn't reproducible on our platform anymore. But i'm not sure this
> is clean.
>
> Best regards
>
> #regzbot introduced: 67b392f7b8ed
>
> [1] - https://github.com/chargebyte/linux/commits/v6.1-tarragon_w1
> [2] - https://github.com/chargebyte/linux/commit/17ca863a32a6a1bdd376959f05c954bef12fc1b5
Can you send a patch that shows the change you wish to have made here so
that you can get credit for fixing the issue?
thanks,
greg k-h
next prev parent reply other threads:[~2023-04-26 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 13:39 Regression: w1_therm: sysfs w1_slave sometimes report 85 degrees Celsius Stefan Wahren
2023-04-26 14:01 ` Greg Kroah-Hartman [this message]
2023-04-27 11:47 ` Stefan Wahren
2023-05-22 10:44 ` Linux regression tracking #update (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023042645-attentive-amends-7b0b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akira215corp@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=stefan.wahren@chargebyte.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).