Re: Regression in 5.15 in nouveau

Re: Regression in 5.15 in nouveau

[Thorsten Leemhuis]

[TLDR: adding this regression to regzbot; most of this mail is compiled
from a few templates paragraphs some of you will have seen aready.]

Hi, this is your Linux kernel regression tracker speaking.

Top-posting for once, to make this easy accessible to everyone.

Adding the regression mailing list to the list of recipients, as it
should be in the loop for all regressions, as explained here:
https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html

To be sure this issue doesn't fall through the cracks unnoticed, I'm
adding it to regzbot, my Linux kernel regression tracking bot:

#regzbot ^introduced 3e1ad79bf66165bdb2baca3989f9227939241f11
#regzbot title drm: nouveau: annoying black flickering in some
applications with KDE Plasma with Xorg
#regzbot ignore-activity

Reminder: when fixing the issue, please add a 'Link:' tag with the URL
to the report (the parent of this mail), then regzbot will automatically
mark the regression as resolved once the fix lands in the appropriate
tree. For more details about regzbot see footer.

Sending this to everyone that got the initial report, to make all aware
of the tracking. I also hope that messages like this motivate people to
directly get at least the regression mailing list and ideally even
regzbot involved when dealing with regressions, as messages like this
wouldn't be needed then.

Don't worry, I'll send further messages wrt to this regression just to
the lists (with a tag in the subject so people can filter them away), as
long as they are intended just for regzbot. With a bit of luck no such
messages will be needed anyway.

Ciao, Thorsten, your Linux kernel regression tracker.

P.S.: As a Linux kernel regression tracker I'm getting a lot of reports
on my table. I can only look briefly into most of them. Unfortunately
therefore I sometimes will get things wrong or miss something important.
I hope that's not the case here; if you think it is, don't hesitate to
tell me about it in a public reply. That's in everyone's interest, as
what I wrote above might be misleading to everyone reading this; any
suggestion I gave they thus might sent someone reading this down the
wrong rabbit hole, which none of us wants.

BTW, I have no personal interest in this issue, which is tracked using
regzbot, my Linux kernel regression tracking bot
(https://linux-regtracking.leemhuis.info/regzbot/). I'm only posting
this mail to get things rolling again and hence don't need to be CC on
all further activities wrt to this regression.


On 04.12.21 17:40, Stefan Fritsch wrote:
> Hi,
> 
> when updating from 5.14 to 5.15 on a system with NVIDIA GP108 [GeForce
> GT 1030] (NV138) and Ryzen 9 3900XT using kde/plasma on X (not wayland),
> there is a regression: There is now some annoying black flickering in
> some applications, for example thunderbird, firefox, or mpv. It mostly
> happens when scrolling or when playing video. Only the window of the
> application flickers, not the whole screen. But the flickering is not
> limited to the scrolled area: for example in firefox the url and
> bookmark bars flicker, too, not only the web site. I have bisected the
> issue to this commit:
> 
> commit 3e1ad79bf66165bdb2baca3989f9227939241f11 (HEAD)
> Author: Christian König <christian.koenig@amd.com>
> Date:   Sun Jun 6 11:50:15 2021 +0200
> 
>     drm/nouveau: always wait for the exclusive fence
> 
>     Drivers also need to to sync to the exclusive fence when
>     a shared one is present.
> 
>     Signed-off-by: Christian König <christian.koenig@amd.com>
>     Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>     Link:
> https://patchwork.freedesktop.org/patch/msgid/20210702111642.17259-4-christian.koenig@amd.com
> 
> 
> 
> This sounds like performance is impacted severely by that commit. Can
> this be fixed somehow? A partial dmesg is below.
> 
> Cheers,
> Stefan
> 
> 
> dmesg |grep -i -e drm -e dri -e nvidia -e nouveau -e fb
> [    0.000000] BIOS-e820: [mem 0x00000000bc552000-0x00000000bc8fbfff]
> reserved
> [    0.004971] ACPI: XSDT 0x00000000BCFB0728 0000CC (v01 ALASKA A M I
> 01072009 AMI  01000013)
> [    0.010838] PM: hibernation: Registered nosave memory: [mem
> 0xbc552000-0xbc8fbfff]
> [    0.204873] Performance Events: Fam17h+ core perfctr, AMD PMU driver.
> [    0.292761] Registering PCC driver as Mailbox controller
> [    0.292761] acpiphp: ACPI Hot Plug PCI Controller Driver version: 0.5
> [    0.518295] pci 0000:06:00.0: reg 0x10: [mem 0xfb000000-0xfbffffff]
> [    0.519132] pci 0000:06:00.1: [10de:0fb8] type 00 class 0x040300
> [    0.519653] pci 0000:00:03.1:   bridge window [mem
> 0xfb000000-0xfc0fffff]
> [    0.549101] pci 0000:00:03.1:   bridge window [mem
> 0xfb000000-0xfc0fffff]
> [    0.550994] pci_bus 0000:06: resource 1 [mem 0xfb000000-0xfc0fffff]
> [    0.561285] Block layer SCSI generic (bsg) driver version 0.4 loaded
> (major 250)
> [    0.564152] shpchp: Standard Hot Plug PCI Controller Driver version: 0.4
> [    0.570870] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
> [    0.571531] AMD-Vi: AMD IOMMUv2 driver by Joerg Roedel <jroedel@suse.de>
> [    0.988343] microcode: Microcode Update Driver: v2.2.
> [    1.112435] ACPI: OSL: Resource conflict; ACPI support missing from
> driver?
> [    1.114174] usbcore: registered new interface driver usbfs
> [    1.114331] usbcore: registered new interface driver hub
> [    1.114599] usbcore: registered new device driver usb
> [    2.373857] hid: raw HID events driver (C) Jiri Kosina
> [    2.378553] usbcore: registered new interface driver usbhid
> [    2.378641] usbhid: USB HID core driver
> [    2.581069] ata3.00: supports DRM functions and may not be fully
> accessible
> [    2.582388] ata3.00: supports DRM functions and may not be fully
> accessible
> [    3.371574] ata5.00: supports DRM functions and may not be fully
> accessible
> [    3.396636] ata5.00: supports DRM functions and may not be fully
> accessible
> [    4.159005] sr 1:0:0:0: [sr0] scsi3-mmc drive: 48x/48x writer dvd-ram
> cd/rw xa/form2 cdda tray
> [    4.159120] cdrom: Uniform CD-ROM driver Revision: 3.20
> [    5.936017] systemd[1]: Starting Load Kernel Module drm...
> [    5.957038] systemd[1]: modprobe@drm.service: Deactivated successfully.
> [    5.957238] systemd[1]: Finished Load Kernel Module drm.
> [    6.104901] sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver
> [    6.122007] usbcore: registered new device driver apple-mfi-fastcharge
> [    6.213866] input: HDA NVidia HDMI/DP,pcm=3 as
> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input8
> [    6.236581] AMD64 EDAC driver v3.5.0
> [    6.259473] input: HDA NVidia HDMI/DP,pcm=7 as
> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input9
> [    6.259631] input: HDA NVidia HDMI/DP,pcm=8 as
> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input10
> [    6.260559] input: HDA NVidia HDMI/DP,pcm=9 as
> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input11
> [    6.260913] input: HDA NVidia HDMI/DP,pcm=10 as
> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input12
> [    6.485220] nouveau 0000:06:00.0: vgaarb: deactivate vga console
> [    6.486484] nouveau 0000:06:00.0: NVIDIA GP108 (138000a1)
> [    6.612994] nouveau 0000:06:00.0: bios: version 86.08.24.00.23
> [    6.617303] nouveau 0000:06:00.0: pmu: firmware unavailable
> [    6.621410] nouveau 0000:06:00.0: fb: 2048 MiB GDDR5
> [    6.653892] nouveau 0000:06:00.0: DRM: VRAM: 2048 MiB
> [    6.653895] nouveau 0000:06:00.0: DRM: GART: 536870912 MiB
> [    6.653897] nouveau 0000:06:00.0: DRM: BIT table 'A' not found
> [    6.653899] nouveau 0000:06:00.0: DRM: BIT table 'L' not found
> [    6.653900] nouveau 0000:06:00.0: DRM: TMDS table version 2.0
> [    6.653902] nouveau 0000:06:00.0: DRM: DCB version 4.1
> [    6.653904] nouveau 0000:06:00.0: DRM: DCB outp 00: 01800346 04600010
> [    6.653906] nouveau 0000:06:00.0: DRM: DCB outp 01: 01000342 00020010
> [    6.653908] nouveau 0000:06:00.0: DRM: DCB outp 02: 01011352 00020020
> [    6.653909] nouveau 0000:06:00.0: DRM: DCB conn 00: 00001046
> [    6.653911] nouveau 0000:06:00.0: DRM: DCB conn 01: 00002161
> [    6.654295] nouveau 0000:06:00.0: DRM: MM: using COPY for buffer copies
> [    6.655460] snd_hda_intel 0000:06:00.1: bound 0000:06:00.0 (ops
> nv50_audio_component_bind_ops [nouveau])
> [    6.828018] nouveau 0000:06:00.0: DRM: allocated 3840x2160 fb:
> 0x200000, bo 000000001a41f1fe
> [    6.828086] fbcon: nouveau (fb0) is primary device
> [    6.915486] nouveau 0000:06:00.0: [drm] fb0: nouveau frame buffer device
> [    6.939244] [drm] Initialized nouveau 1.3.1 20120801 for 0000:06:00.0
> on minor 0
> [   11.338075] audit: type=1400 audit(1638634273.245:6):
> apparmor="STATUS" operation="profile_load" profile="unconfined"
> name="nvidia_modprobe" pid=1354 comm="apparmor_parser"
> [   11.338078] audit: type=1400 audit(1638634273.245:7):
> apparmor="STATUS" operation="profile_load" profile="unconfined"
> name="nvidia_modprobe//kmod" pid=1354 comm="apparmor_parser"
> [   11.479123] RTL8226B_RTL8221B 2.5Gbps PHY r8169-500:00: attached PHY
> driver (mii_bus:phy_addr=r8169-500:00, irq=MAC)
> stf@k:~/comp/linux/linux$ sudo dmesg |less
> stf@k:~/comp/linux/linux$ sudo dmesg |grep -i -e drm -e dri -e nvidia -e
> nouveau -e fb
> [    0.000000] BIOS-e820: [mem 0x00000000bc552000-0x00000000bc8fbfff]
> reserved
> [    0.004971] ACPI: XSDT 0x00000000BCFB0728 0000CC (v01 ALASKA A M I
> 01072009 AMI  01000013)
> [    0.010838] PM: hibernation: Registered nosave memory: [mem
> 0xbc552000-0xbc8fbfff]
> [    0.204873] Performance Events: Fam17h+ core perfctr, AMD PMU driver.
> [    0.292761] Registering PCC driver as Mailbox controller
> [    0.292761] acpiphp: ACPI Hot Plug PCI Controller Driver version: 0.5
> [    0.518295] pci 0000:06:00.0: reg 0x10: [mem 0xfb000000-0xfbffffff]
> [    0.519132] pci 0000:06:00.1: [10de:0fb8] type 00 class 0x040300
> [    0.519653] pci 0000:00:03.1:   bridge window [mem
> 0xfb000000-0xfc0fffff]
> [    0.549101] pci 0000:00:03.1:   bridge window [mem
> 0xfb000000-0xfc0fffff]
> [    0.550994] pci_bus 0000:06: resource 1 [mem 0xfb000000-0xfc0fffff]
> [    0.561285] Block layer SCSI generic (bsg) driver version 0.4 loaded
> (major 250)
> [    0.564152] shpchp: Standard Hot Plug PCI Controller Driver version: 0.4
> [    0.570870] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
> [    0.571531] AMD-Vi: AMD IOMMUv2 driver by Joerg Roedel <jroedel@suse.de>
> [    0.988343] microcode: Microcode Update Driver: v2.2.
> [    1.112435] ACPI: OSL: Resource conflict; ACPI support missing from
> driver?
> [    1.114174] usbcore: registered new interface driver usbfs
> [    1.114331] usbcore: registered new interface driver hub
> [    1.114599] usbcore: registered new device driver usb
> [    2.373857] hid: raw HID events driver (C) Jiri Kosina
> [    2.378553] usbcore: registered new interface driver usbhid
> [    2.378641] usbhid: USB HID core driver
> [    2.581069] ata3.00: supports DRM functions and may not be fully
> accessible
> [    2.582388] ata3.00: supports DRM functions and may not be fully
> accessible
> [    3.371574] ata5.00: supports DRM functions and may not be fully
> accessible
> [    3.396636] ata5.00: supports DRM functions and may not be fully
> accessible
> [    4.159005] sr 1:0:0:0: [sr0] scsi3-mmc drive: 48x/48x writer dvd-ram
> cd/rw xa/form2 cdda tray
> [    4.159120] cdrom: Uniform CD-ROM driver Revision: 3.20
> [    5.936017] systemd[1]: Starting Load Kernel Module drm...
> [    5.957038] systemd[1]: modprobe@drm.service: Deactivated successfully.
> [    5.957238] systemd[1]: Finished Load Kernel Module drm.
> [    6.104901] sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver
> [    6.122007] usbcore: registered new device driver apple-mfi-fastcharge
> [    6.213866] input: HDA NVidia HDMI/DP,pcm=3 as
> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input8
> [    6.236581] AMD64 EDAC driver v3.5.0
> [    6.259473] input: HDA NVidia HDMI/DP,pcm=7 as
> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input9
> [    6.259631] input: HDA NVidia HDMI/DP,pcm=8 as
> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input10
> [    6.260559] input: HDA NVidia HDMI/DP,pcm=9 as
> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input11
> [    6.260913] input: HDA NVidia HDMI/DP,pcm=10 as
> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input12
> [    6.485220] nouveau 0000:06:00.0: vgaarb: deactivate vga console
> [    6.486484] nouveau 0000:06:00.0: NVIDIA GP108 (138000a1)
> [    6.612994] nouveau 0000:06:00.0: bios: version 86.08.24.00.23
> [    6.617303] nouveau 0000:06:00.0: pmu: firmware unavailable
> [    6.621410] nouveau 0000:06:00.0: fb: 2048 MiB GDDR5
> [    6.653892] nouveau 0000:06:00.0: DRM: VRAM: 2048 MiB
> [    6.653895] nouveau 0000:06:00.0: DRM: GART: 536870912 MiB
> [    6.653897] nouveau 0000:06:00.0: DRM: BIT table 'A' not found
> [    6.653899] nouveau 0000:06:00.0: DRM: BIT table 'L' not found
> [    6.653900] nouveau 0000:06:00.0: DRM: TMDS table version 2.0
> [    6.653902] nouveau 0000:06:00.0: DRM: DCB version 4.1
> [    6.653904] nouveau 0000:06:00.0: DRM: DCB outp 00: 01800346 04600010
> [    6.653906] nouveau 0000:06:00.0: DRM: DCB outp 01: 01000342 00020010
> [    6.653908] nouveau 0000:06:00.0: DRM: DCB outp 02: 01011352 00020020
> [    6.653909] nouveau 0000:06:00.0: DRM: DCB conn 00: 00001046
> [    6.653911] nouveau 0000:06:00.0: DRM: DCB conn 01: 00002161
> [    6.654295] nouveau 0000:06:00.0: DRM: MM: using COPY for buffer copies
> [    6.655460] snd_hda_intel 0000:06:00.1: bound 0000:06:00.0 (ops
> nv50_audio_component_bind_ops [nouveau])
> [    6.828018] nouveau 0000:06:00.0: DRM: allocated 3840x2160 fb:
> 0x200000, bo 000000001a41f1fe
> [    6.828086] fbcon: nouveau (fb0) is primary device
> [    6.915486] nouveau 0000:06:00.0: [drm] fb0: nouveau frame buffer device
> [    6.939244] [drm] Initialized nouveau 1.3.1 20120801 for 0000:06:00.0
> on minor 0
> [   11.338075] audit: type=1400 audit(1638634273.245:6):
> apparmor="STATUS" operation="profile_load" profile="unconfined"
> name="nvidia_modprobe" pid=1354 comm="apparmor_parser"
> [   11.338078] audit: type=1400 audit(1638634273.245:7):
> apparmor="STATUS" operation="profile_load" profile="unconfined"
> name="nvidia_modprobe//kmod" pid=1354 comm="apparmor_parser"
> [   11.479123] RTL8226B_RTL8221B 2.5Gbps PHY r8169-500:00: attached PHY
> driver (mii_bus:phy_addr=r8169-500:00, irq=MAC)
> 

Re: Regression in 5.15 in nouveau

[Christian König]

Thanks Thorsten for CCing me on your reply.

I was somehow not CCed on the original problem report.

Am 06.12.21 um 14:19 schrieb Thorsten Leemhuis:
> [SNIP]
>
> On 04.12.21 17:40, Stefan Fritsch wrote:
>> Hi,
>>
>> when updating from 5.14 to 5.15 on a system with NVIDIA GP108 [GeForce
>> GT 1030] (NV138) and Ryzen 9 3900XT using kde/plasma on X (not wayland),
>> there is a regression: There is now some annoying black flickering in
>> some applications, for example thunderbird, firefox, or mpv. It mostly
>> happens when scrolling or when playing video. Only the window of the
>> application flickers, not the whole screen. But the flickering is not
>> limited to the scrolled area: for example in firefox the url and
>> bookmark bars flicker, too, not only the web site. I have bisected the
>> issue to this commit:
>>
>> commit 3e1ad79bf66165bdb2baca3989f9227939241f11 (HEAD)
>> Author: Christian König <christian.koenig@amd.com>
>> Date:   Sun Jun 6 11:50:15 2021 +0200
>>
>>      drm/nouveau: always wait for the exclusive fence
>>
>>      Drivers also need to to sync to the exclusive fence when
>>      a shared one is present.

Mhm, that is really strange. The patch shouldn't have any functional 
effect, but just makes an already established rule more straight forward.

Let me double check the code once more.

Regards,
Christian.

Re: [Nouveau] Regression in 5.15 in nouveau

[Dan Moulding]

On 04.12.21 17:40, Stefan Fritsch wrote:
> Hi,
> 
> when updating from 5.14 to 5.15 on a system with NVIDIA GP108 [GeForce
> GT 1030] (NV138) and Ryzen 9 3900XT using kde/plasma on X (not wayland),
> there is a regression: There is now some annoying black flickering in
> some applications, for example thunderbird, firefox, or mpv. It mostly
> happens when scrolling or when playing video. Only the window of the
> application flickers, not the whole screen. But the flickering is not
> limited to the scrolled area: for example in firefox the url and
> bookmark bars flicker, too, not only the web site. I have bisected the
> issue to this commit:
> 
> commit 3e1ad79bf66165bdb2baca3989f9227939241f11 (HEAD)

I have been experiencing this same issue since switching to 5.15. I
can confirm that reverting the above mentioned commit fixes the issue
for me. I'm on GP104 hardware (GeForce GTX 1070), also running KDE
Plasma on X.

Cheers,

-- Dan

Re: [Nouveau] Regression in 5.15 in nouveau

[Christian König]

[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]

Am 06.12.21 um 19:37 schrieb Dan Moulding:
> On 04.12.21 17:40, Stefan Fritsch wrote:
>> Hi,
>>
>> when updating from 5.14 to 5.15 on a system with NVIDIA GP108 [GeForce
>> GT 1030] (NV138) and Ryzen 9 3900XT using kde/plasma on X (not wayland),
>> there is a regression: There is now some annoying black flickering in
>> some applications, for example thunderbird, firefox, or mpv. It mostly
>> happens when scrolling or when playing video. Only the window of the
>> application flickers, not the whole screen. But the flickering is not
>> limited to the scrolled area: for example in firefox the url and
>> bookmark bars flicker, too, not only the web site. I have bisected the
>> issue to this commit:
>>
>> commit 3e1ad79bf66165bdb2baca3989f9227939241f11 (HEAD)
> I have been experiencing this same issue since switching to 5.15. I
> can confirm that reverting the above mentioned commit fixes the issue
> for me. I'm on GP104 hardware (GeForce GTX 1070), also running KDE
> Plasma on X.

I'm still scratching my head what's going wrong here.

Either we trigger some performance problem because we now wait twice for 
submissions or nouveau is doing something very nasty and not syncing 
it's memory accesses correctly.

Attached is an only compile tested patch which might mitigate the first 
problem.

But if it's the second then nouveau has a really nasty design issue here 
and somebody with more background on that driver design needs to take a 
look.

Please test if that patch changes anything.

Thanks,
Christian.

>
> Cheers,
>
> -- Dan


[-- Attachment #2: 0001-drm-nouveau-wait-for-the-exclusive-fence-after-the-s.patch --]
[-- Type: text/x-patch, Size: 2321 bytes --]

From bcb86d62569c0131288c8b032f848f28f0178648 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>
Date: Tue, 7 Dec 2021 10:10:15 +0100
Subject: [PATCH] drm/nouveau: wait for the exclusive fence after the shared
 ones
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Always waiting for the exclusive fence resulted on some performance
regressions. So try to wait for the shared fences first, then the
exclusive fence should always be signaled already.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/nouveau/nouveau_fence.c | 25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c
index 05d0b3eb3690..0947e332371b 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fence.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
@@ -353,15 +353,19 @@ nouveau_fence_sync(struct nouveau_bo *nvbo, struct nouveau_channel *chan, bool e
 
 		if (ret)
 			return ret;
-	}
 
-	fobj = dma_resv_shared_list(resv);
-	fence = dma_resv_excl_fence(resv);
+		fobj = NULL;
+	} else {
+		fobj = dma_resv_shared_list(resv);
+	}
 
-	if (fence) {
+	for (i = 0; (i < fobj ? fobj->shared_count : 0) && !ret; ++i) {
 		struct nouveau_channel *prev = NULL;
 		bool must_wait = true;
 
+		fence = rcu_dereference_protected(fobj->shared[i],
+						dma_resv_held(resv));
+
 		f = nouveau_local_fence(fence, chan->drm);
 		if (f) {
 			rcu_read_lock();
@@ -373,20 +377,13 @@ nouveau_fence_sync(struct nouveau_bo *nvbo, struct nouveau_channel *chan, bool e
 
 		if (must_wait)
 			ret = dma_fence_wait(fence, intr);
-
-		return ret;
 	}
 
-	if (!exclusive || !fobj)
-		return ret;
-
-	for (i = 0; i < fobj->shared_count && !ret; ++i) {
+	fence = dma_resv_excl_fence(resv);
+	if (fence) {
 		struct nouveau_channel *prev = NULL;
 		bool must_wait = true;
 
-		fence = rcu_dereference_protected(fobj->shared[i],
-						dma_resv_held(resv));
-
 		f = nouveau_local_fence(fence, chan->drm);
 		if (f) {
 			rcu_read_lock();
@@ -398,6 +395,8 @@ nouveau_fence_sync(struct nouveau_bo *nvbo, struct nouveau_channel *chan, bool e
 
 		if (must_wait)
 			ret = dma_fence_wait(fence, intr);
+
+		return ret;
 	}
 
 	return ret;
-- 
2.25.1

Re: [Nouveau] Regression in 5.15 in nouveau

[Karol Herbst]

On Tue, Dec 7, 2021 at 10:52 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Am 06.12.21 um 19:37 schrieb Dan Moulding:
> > On 04.12.21 17:40, Stefan Fritsch wrote:
> >> Hi,
> >>
> >> when updating from 5.14 to 5.15 on a system with NVIDIA GP108 [GeForce
> >> GT 1030] (NV138) and Ryzen 9 3900XT using kde/plasma on X (not wayland),
> >> there is a regression: There is now some annoying black flickering in
> >> some applications, for example thunderbird, firefox, or mpv. It mostly
> >> happens when scrolling or when playing video. Only the window of the
> >> application flickers, not the whole screen. But the flickering is not
> >> limited to the scrolled area: for example in firefox the url and
> >> bookmark bars flicker, too, not only the web site. I have bisected the
> >> issue to this commit:
> >>
> >> commit 3e1ad79bf66165bdb2baca3989f9227939241f11 (HEAD)
> > I have been experiencing this same issue since switching to 5.15. I
> > can confirm that reverting the above mentioned commit fixes the issue
> > for me. I'm on GP104 hardware (GeForce GTX 1070), also running KDE
> > Plasma on X.
>
> I'm still scratching my head what's going wrong here.
>
> Either we trigger some performance problem because we now wait twice for
> submissions or nouveau is doing something very nasty and not syncing
> it's memory accesses correctly.
>
> Attached is an only compile tested patch which might mitigate the first
> problem.
>
> But if it's the second then nouveau has a really nasty design issue here
> and somebody with more background on that driver design needs to take a
> look.
>

Ben mentioned a few times that fences might be busted but we all have
no idea what's actually wrong. So it might be that your change is
indeed triggering something which was always broken or something else.

> Please test if that patch changes anything.
>
> Thanks,
> Christian.
>
> >
> > Cheers,
> >
> > -- Dan
>

Re: [Nouveau] Regression in 5.15 in nouveau

[Daniel Vetter]

On Tue, Dec 07, 2021 at 06:32:06PM +0100, Karol Herbst wrote:
> On Tue, Dec 7, 2021 at 10:52 AM Christian König
> <christian.koenig@amd.com> wrote:
> >
> > Am 06.12.21 um 19:37 schrieb Dan Moulding:
> > > On 04.12.21 17:40, Stefan Fritsch wrote:
> > >> Hi,
> > >>
> > >> when updating from 5.14 to 5.15 on a system with NVIDIA GP108 [GeForce
> > >> GT 1030] (NV138) and Ryzen 9 3900XT using kde/plasma on X (not wayland),
> > >> there is a regression: There is now some annoying black flickering in
> > >> some applications, for example thunderbird, firefox, or mpv. It mostly
> > >> happens when scrolling or when playing video. Only the window of the
> > >> application flickers, not the whole screen. But the flickering is not
> > >> limited to the scrolled area: for example in firefox the url and
> > >> bookmark bars flicker, too, not only the web site. I have bisected the
> > >> issue to this commit:
> > >>
> > >> commit 3e1ad79bf66165bdb2baca3989f9227939241f11 (HEAD)
> > > I have been experiencing this same issue since switching to 5.15. I
> > > can confirm that reverting the above mentioned commit fixes the issue
> > > for me. I'm on GP104 hardware (GeForce GTX 1070), also running KDE
> > > Plasma on X.
> >
> > I'm still scratching my head what's going wrong here.
> >
> > Either we trigger some performance problem because we now wait twice for
> > submissions or nouveau is doing something very nasty and not syncing
> > it's memory accesses correctly.
> >
> > Attached is an only compile tested patch which might mitigate the first
> > problem.
> >
> > But if it's the second then nouveau has a really nasty design issue here
> > and somebody with more background on that driver design needs to take a
> > look.
> >
> 
> Ben mentioned a few times that fences might be busted but we all have
> no idea what's actually wrong. So it might be that your change is
> indeed triggering something which was always broken or something else.

Description sounds a bit like we're doing a clear before Xorg has had a
chance to copy the pixmap to the frontbuffer perhaps? That would point to
a fencing issue in userspace, and somehow ignoring fences ensures that the
Xorg copy/blt completes before we get around to clearing stuff.

I'm assuming we're rendering with glamour, so is nouveau relying on kernel
implicit sync or doing it's own fencing in userspace?
-Daniel

> 
> > Please test if that patch changes anything.
> >
> > Thanks,
> > Christian.
> >
> > >
> > > Cheers,
> > >
> > > -- Dan
> >
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [Nouveau] Regression in 5.15 in nouveau

[Dan Moulding]

> Please test if that patch changes anything.

Looks like the driver is not functional after applying that patch. As
soon as the display manager is supposed to start I get a black screen
with just a (working) mouse pointer. VT switching doesn't work after
that point.

I got the following warning when compiling with that patch applied:

drivers/gpu/drm/nouveau/nouveau_fence.c: In function ‘nouveau_fence_sync’:
drivers/gpu/drm/nouveau/nouveau_fence.c:362:24: warning: comparison between pointer and integer
  362 |         for (i = 0; (i < fobj ? fobj->shared_count : 0) && !ret; ++i) {
      |                        ^

Below are the relevant portions from dmesg after attempting to run
with the patch applied.

Cheers,

-- Dan

dmesg:
=====

<snip>

[    0.269958] nouveau 0000:01:00.0: NVIDIA GP104 (134000a1)
[    0.377100] nouveau 0000:01:00.0: bios: version 86.04.50.80.13
[    0.377210] nouveau 0000:01:00.0: pmu: firmware unavailable
[    0.377711] nouveau 0000:01:00.0: fb: 8192 MiB GDDR5
[    0.391160] nouveau 0000:01:00.0: DRM: VRAM: 8192 MiB
[    0.391164] nouveau 0000:01:00.0: DRM: GART: 536870912 MiB
[    0.391166] nouveau 0000:01:00.0: DRM: BIT table 'A' not found
[    0.391168] nouveau 0000:01:00.0: DRM: BIT table 'L' not found
[    0.391170] nouveau 0000:01:00.0: DRM: TMDS table version 2.0
[    0.391172] nouveau 0000:01:00.0: DRM: DCB version 4.1
[    0.391174] nouveau 0000:01:00.0: DRM: DCB outp 00: 01000f42 00020030
[    0.391176] nouveau 0000:01:00.0: DRM: DCB outp 01: 04811f96 04600020
[    0.391178] nouveau 0000:01:00.0: DRM: DCB outp 02: 04011f92 00020020
[    0.391180] nouveau 0000:01:00.0: DRM: DCB outp 03: 04822f86 04600010
[    0.391182] nouveau 0000:01:00.0: DRM: DCB outp 04: 04022f82 00020010
[    0.391184] nouveau 0000:01:00.0: DRM: DCB outp 06: 02033f62 00020010
[    0.391186] nouveau 0000:01:00.0: DRM: DCB outp 07: 02844f76 04600020
[    0.391188] nouveau 0000:01:00.0: DRM: DCB outp 08: 02044f72 00020020
[    0.391190] nouveau 0000:01:00.0: DRM: DCB conn 00: 00001031
[    0.391191] nouveau 0000:01:00.0: DRM: DCB conn 01: 02000146
[    0.391193] nouveau 0000:01:00.0: DRM: DCB conn 02: 01000246
[    0.391194] nouveau 0000:01:00.0: DRM: DCB conn 03: 00010361
[    0.391196] nouveau 0000:01:00.0: DRM: DCB conn 04: 00020446
[    0.391489] nouveau 0000:01:00.0: DRM: MM: using COPY for buffer copies
[    0.891103] nouveau 0000:01:00.0: DRM: allocated 1920x1080 fb: 0x200000, bo 00000000bba11dd4
[    0.892559] fbcon: nouveau (fb0) is primary device
[    1.298487] tsc: Refined TSC clocksource calibration: 2999.999 MHz
[    1.298492] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x2b3e44b2357, max_idle_ns: 440795324996 ns
[    1.298555] clocksource: Switched to clocksource tsc
[    1.340790] Console: switching to colour frame buffer device 240x67
[    1.341249] nouveau 0000:01:00.0: [drm] fb0: nouveau frame buffer device
[    1.341412] [drm] Initialized nouveau 1.3.1 20120801 for 0000:01:00.0 on minor 0
[    1.341420] nouveau 0000:01:00.0: DRM: Disabling PCI power management to avoid bug

<snip>

[   19.742986] general protection fault, probably for non-canonical address 0x3e40c25cd2e657bd: 0000 [#1] SMP
[   19.742989] CPU: 0 PID: 3588 Comm: X Tainted: G                T 5.15.6p2+ #1
[   19.742991] Hardware name: Dell Inc. XPS 8930/0T2HR0, BIOS 1.1.17 06/22/2021
[   19.742992] RIP: 0010:nouveau_fence_sync+0x6f/0x240
[   19.742995] Code: 00 8b 7b 10 85 ff 0f 84 a7 00 00 00 41 89 cd 31 ed 31 d2 49 be ff ff ff ff ff ff ff 7f 4c 8b 7c d3 18 49 8b 94 24 90 00 00 00 <49> 8b 47 08 48 3d 00 37 0f a0 74 0c 48 3d 60 37 0f a0 0f 85 16 01
[   19.742996] RSP: 0018:ffffb3bc413e7c10 EFLAGS: 00010202
[   19.742998] RAX: 0000000000001001 RBX: ffff897383c07980 RCX: 0000000000000003
[   19.742999] RDX: ffff897380cce000 RSI: 0000000000000001 RDI: 0000000000000001
[   19.743000] RBP: 0000000000000001 R08: ffff897382af6c00 R09: ffff8973868641b8
[   19.743001] R10: 0000000000000002 R11: ffff8973868641dc R12: ffff897386862400
[   19.743001] R13: 0000000000000001 R14: 7fffffffffffffff R15: 3e40c25cd2e657b5
[   19.743002] FS:  00007f5e661be8c0(0000) GS:ffff897ae0c00000(0000) knlGS:0000000000000000
[   19.743003] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   19.743004] CR2: 000055c9e8e33d50 CR3: 00000001152b7001 CR4: 00000000003706f0
[   19.743005] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   19.743006] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[   19.743006] Call Trace:
[   19.743008]  <TASK>
[   19.743009]  nouveau_gem_ioctl_pushbuf+0x6ba/0x11a0
[   19.743011]  ? nouveau_gem_ioctl_new+0x100/0x100
[   19.743012]  drm_ioctl_kernel+0x9f/0xe0
[   19.743015]  drm_ioctl+0x214/0x3f0
[   19.743016]  ? nouveau_gem_ioctl_new+0x100/0x100
[   19.743017]  ? syscall_exit_to_user_mode+0x1d/0x40
[   19.743019]  ? do_syscall_64+0x63/0x80
[   19.743021]  __x64_sys_ioctl+0x80/0xa0
[   19.743023]  do_syscall_64+0x56/0x80
[   19.743025]  ? exc_page_fault+0x18c/0x4e0
[   19.743026]  ? __do_sys_getpid+0x15/0x20
[   19.743029]  entry_SYSCALL_64_after_hwframe+0x44/0xae
[   19.743030] RIP: 0033:0x7f5e666c52d7
[   19.743031] Code: 3c 1c e8 2c ff ff ff 85 c0 79 97 5b 49 c7 c4 ff ff ff ff 5d 4c 89 e0 41 5c c3 66 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 69 4b 0c 00 f7 d8 64 89 01 48
[   19.743032] RSP: 002b:00007ffe8a5c2588 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
[   19.743034] RAX: ffffffffffffffda RBX: 00007ffe8a5c25e0 RCX: 00007f5e666c52d7
[   19.743034] RDX: 00007ffe8a5c25e0 RSI: 00000000c0406481 RDI: 000000000000000e
[   19.743035] RBP: 00000000c0406481 R08: 0000000000000000 R09: 00007f5e6678ac00
[   19.743036] R10: 000055c9e96d3f10 R11: 0000000000000246 R12: 000055c9e8e17eb0
[   19.743036] R13: 000000000000000e R14: 000055c9e8e14340 R15: 000055c9e9791120
[   19.743037]  </TASK>
[   19.743038] ---[ end trace e5a33326c4208bdb ]---
[   19.743039] RIP: 0010:nouveau_fence_sync+0x6f/0x240
[   19.743040] Code: 00 8b 7b 10 85 ff 0f 84 a7 00 00 00 41 89 cd 31 ed 31 d2 49 be ff ff ff ff ff ff ff 7f 4c 8b 7c d3 18 49 8b 94 24 90 00 00 00 <49> 8b 47 08 48 3d 00 37 0f a0 74 0c 48 3d 60 37 0f a0 0f 85 16 01
[   19.743041] RSP: 0018:ffffb3bc413e7c10 EFLAGS: 00010202
[   19.743042] RAX: 0000000000001001 RBX: ffff897383c07980 RCX: 0000000000000003
[   19.743043] RDX: ffff897380cce000 RSI: 0000000000000001 RDI: 0000000000000001
[   19.743043] RBP: 0000000000000001 R08: ffff897382af6c00 R09: ffff8973868641b8
[   19.743044] R10: 0000000000000002 R11: ffff8973868641dc R12: ffff897386862400
[   19.743045] R13: 0000000000000001 R14: 7fffffffffffffff R15: 3e40c25cd2e657b5
[   19.743045] FS:  00007f5e661be8c0(0000) GS:ffff897ae0c00000(0000) knlGS:0000000000000000
[   19.743046] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   19.743047] CR2: 000055c9e8e33d50 CR3: 00000001152b7001 CR4: 00000000003706f0
[   19.743048] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   19.743048] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Re: [Nouveau] Regression in 5.15 in nouveau

[Stefan Fritsch]

There is a pretty obvious typo in there:

--- a/drivers/gpu/drm/nouveau/nouveau_fence.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
@@ -359,7 +359,7 @@ nouveau_fence_sync(struct nouveau_bo *nvbo, struct 
nouveau_channel *chan, bool e
                 fobj = dma_resv_shared_list(resv);
         }

-       for (i = 0; (i < fobj ? fobj->shared_count : 0) && !ret; ++i) {
+       for (i = 0; i < (fobj ? fobj->shared_count : 0) && !ret; ++i) {
                 struct nouveau_channel *prev = NULL;
                 bool must_wait = true;


With that it works and I don't see the flickering in a short test. I 
will do more testing, but maybe Dan can test, too.

Cheers,
Stefan

On 07.12.21 20:01, Dan Moulding wrote:
>> Please test if that patch changes anything.
> 
> Looks like the driver is not functional after applying that patch. As
> soon as the display manager is supposed to start I get a black screen
> with just a (working) mouse pointer. VT switching doesn't work after
> that point.
> 
> I got the following warning when compiling with that patch applied:
> 
> drivers/gpu/drm/nouveau/nouveau_fence.c: In function ‘nouveau_fence_sync’:
> drivers/gpu/drm/nouveau/nouveau_fence.c:362:24: warning: comparison between pointer and integer
>    362 |         for (i = 0; (i < fobj ? fobj->shared_count : 0) && !ret; ++i) {
>        |                        ^
> 
> Below are the relevant portions from dmesg after attempting to run
> with the patch applied.
> 
> Cheers,
> 
> -- Dan
> 
> dmesg:
> =====
> 
> <snip>
> 
> [    0.269958] nouveau 0000:01:00.0: NVIDIA GP104 (134000a1)
> [    0.377100] nouveau 0000:01:00.0: bios: version 86.04.50.80.13
> [    0.377210] nouveau 0000:01:00.0: pmu: firmware unavailable
> [    0.377711] nouveau 0000:01:00.0: fb: 8192 MiB GDDR5
> [    0.391160] nouveau 0000:01:00.0: DRM: VRAM: 8192 MiB
> [    0.391164] nouveau 0000:01:00.0: DRM: GART: 536870912 MiB
> [    0.391166] nouveau 0000:01:00.0: DRM: BIT table 'A' not found
> [    0.391168] nouveau 0000:01:00.0: DRM: BIT table 'L' not found
> [    0.391170] nouveau 0000:01:00.0: DRM: TMDS table version 2.0
> [    0.391172] nouveau 0000:01:00.0: DRM: DCB version 4.1
> [    0.391174] nouveau 0000:01:00.0: DRM: DCB outp 00: 01000f42 00020030
> [    0.391176] nouveau 0000:01:00.0: DRM: DCB outp 01: 04811f96 04600020
> [    0.391178] nouveau 0000:01:00.0: DRM: DCB outp 02: 04011f92 00020020
> [    0.391180] nouveau 0000:01:00.0: DRM: DCB outp 03: 04822f86 04600010
> [    0.391182] nouveau 0000:01:00.0: DRM: DCB outp 04: 04022f82 00020010
> [    0.391184] nouveau 0000:01:00.0: DRM: DCB outp 06: 02033f62 00020010
> [    0.391186] nouveau 0000:01:00.0: DRM: DCB outp 07: 02844f76 04600020
> [    0.391188] nouveau 0000:01:00.0: DRM: DCB outp 08: 02044f72 00020020
> [    0.391190] nouveau 0000:01:00.0: DRM: DCB conn 00: 00001031
> [    0.391191] nouveau 0000:01:00.0: DRM: DCB conn 01: 02000146
> [    0.391193] nouveau 0000:01:00.0: DRM: DCB conn 02: 01000246
> [    0.391194] nouveau 0000:01:00.0: DRM: DCB conn 03: 00010361
> [    0.391196] nouveau 0000:01:00.0: DRM: DCB conn 04: 00020446
> [    0.391489] nouveau 0000:01:00.0: DRM: MM: using COPY for buffer copies
> [    0.891103] nouveau 0000:01:00.0: DRM: allocated 1920x1080 fb: 0x200000, bo 00000000bba11dd4
> [    0.892559] fbcon: nouveau (fb0) is primary device
> [    1.298487] tsc: Refined TSC clocksource calibration: 2999.999 MHz
> [    1.298492] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x2b3e44b2357, max_idle_ns: 440795324996 ns
> [    1.298555] clocksource: Switched to clocksource tsc
> [    1.340790] Console: switching to colour frame buffer device 240x67
> [    1.341249] nouveau 0000:01:00.0: [drm] fb0: nouveau frame buffer device
> [    1.341412] [drm] Initialized nouveau 1.3.1 20120801 for 0000:01:00.0 on minor 0
> [    1.341420] nouveau 0000:01:00.0: DRM: Disabling PCI power management to avoid bug
> 
> <snip>
> 
> [   19.742986] general protection fault, probably for non-canonical address 0x3e40c25cd2e657bd: 0000 [#1] SMP
> [   19.742989] CPU: 0 PID: 3588 Comm: X Tainted: G                T 5.15.6p2+ #1
> [   19.742991] Hardware name: Dell Inc. XPS 8930/0T2HR0, BIOS 1.1.17 06/22/2021
> [   19.742992] RIP: 0010:nouveau_fence_sync+0x6f/0x240
> [   19.742995] Code: 00 8b 7b 10 85 ff 0f 84 a7 00 00 00 41 89 cd 31 ed 31 d2 49 be ff ff ff ff ff ff ff 7f 4c 8b 7c d3 18 49 8b 94 24 90 00 00 00 <49> 8b 47 08 48 3d 00 37 0f a0 74 0c 48 3d 60 37 0f a0 0f 85 16 01
> [   19.742996] RSP: 0018:ffffb3bc413e7c10 EFLAGS: 00010202
> [   19.742998] RAX: 0000000000001001 RBX: ffff897383c07980 RCX: 0000000000000003
> [   19.742999] RDX: ffff897380cce000 RSI: 0000000000000001 RDI: 0000000000000001
> [   19.743000] RBP: 0000000000000001 R08: ffff897382af6c00 R09: ffff8973868641b8
> [   19.743001] R10: 0000000000000002 R11: ffff8973868641dc R12: ffff897386862400
> [   19.743001] R13: 0000000000000001 R14: 7fffffffffffffff R15: 3e40c25cd2e657b5
> [   19.743002] FS:  00007f5e661be8c0(0000) GS:ffff897ae0c00000(0000) knlGS:0000000000000000
> [   19.743003] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [   19.743004] CR2: 000055c9e8e33d50 CR3: 00000001152b7001 CR4: 00000000003706f0
> [   19.743005] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [   19.743006] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> [   19.743006] Call Trace:
> [   19.743008]  <TASK>
> [   19.743009]  nouveau_gem_ioctl_pushbuf+0x6ba/0x11a0
> [   19.743011]  ? nouveau_gem_ioctl_new+0x100/0x100
> [   19.743012]  drm_ioctl_kernel+0x9f/0xe0
> [   19.743015]  drm_ioctl+0x214/0x3f0
> [   19.743016]  ? nouveau_gem_ioctl_new+0x100/0x100
> [   19.743017]  ? syscall_exit_to_user_mode+0x1d/0x40
> [   19.743019]  ? do_syscall_64+0x63/0x80
> [   19.743021]  __x64_sys_ioctl+0x80/0xa0
> [   19.743023]  do_syscall_64+0x56/0x80
> [   19.743025]  ? exc_page_fault+0x18c/0x4e0
> [   19.743026]  ? __do_sys_getpid+0x15/0x20
> [   19.743029]  entry_SYSCALL_64_after_hwframe+0x44/0xae
> [   19.743030] RIP: 0033:0x7f5e666c52d7
> [   19.743031] Code: 3c 1c e8 2c ff ff ff 85 c0 79 97 5b 49 c7 c4 ff ff ff ff 5d 4c 89 e0 41 5c c3 66 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 69 4b 0c 00 f7 d8 64 89 01 48
> [   19.743032] RSP: 002b:00007ffe8a5c2588 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> [   19.743034] RAX: ffffffffffffffda RBX: 00007ffe8a5c25e0 RCX: 00007f5e666c52d7
> [   19.743034] RDX: 00007ffe8a5c25e0 RSI: 00000000c0406481 RDI: 000000000000000e
> [   19.743035] RBP: 00000000c0406481 R08: 0000000000000000 R09: 00007f5e6678ac00
> [   19.743036] R10: 000055c9e96d3f10 R11: 0000000000000246 R12: 000055c9e8e17eb0
> [   19.743036] R13: 000000000000000e R14: 000055c9e8e14340 R15: 000055c9e9791120
> [   19.743037]  </TASK>
> [   19.743038] ---[ end trace e5a33326c4208bdb ]---
> [   19.743039] RIP: 0010:nouveau_fence_sync+0x6f/0x240
> [   19.743040] Code: 00 8b 7b 10 85 ff 0f 84 a7 00 00 00 41 89 cd 31 ed 31 d2 49 be ff ff ff ff ff ff ff 7f 4c 8b 7c d3 18 49 8b 94 24 90 00 00 00 <49> 8b 47 08 48 3d 00 37 0f a0 74 0c 48 3d 60 37 0f a0 0f 85 16 01
> [   19.743041] RSP: 0018:ffffb3bc413e7c10 EFLAGS: 00010202
> [   19.743042] RAX: 0000000000001001 RBX: ffff897383c07980 RCX: 0000000000000003
> [   19.743043] RDX: ffff897380cce000 RSI: 0000000000000001 RDI: 0000000000000001
> [   19.743043] RBP: 0000000000000001 R08: ffff897382af6c00 R09: ffff8973868641b8
> [   19.743044] R10: 0000000000000002 R11: ffff8973868641dc R12: ffff897386862400
> [   19.743045] R13: 0000000000000001 R14: 7fffffffffffffff R15: 3e40c25cd2e657b5
> [   19.743045] FS:  00007f5e661be8c0(0000) GS:ffff897ae0c00000(0000) knlGS:0000000000000000
> [   19.743046] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [   19.743047] CR2: 000055c9e8e33d50 CR3: 00000001152b7001 CR4: 00000000003706f0
> [   19.743048] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [   19.743048] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> 

Re: [Nouveau] Regression in 5.15 in nouveau

[Dan Moulding]

> There is a pretty obvious typo in there:
> 
> --- a/drivers/gpu/drm/nouveau/nouveau_fence.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
> @@ -359,7 +359,7 @@ nouveau_fence_sync(struct nouveau_bo *nvbo, struct 
> nouveau_channel *chan, bool e
>                  fobj = dma_resv_shared_list(resv);
>          }
> 
> -       for (i = 0; (i < fobj ? fobj->shared_count : 0) && !ret; ++i) {
> +       for (i = 0; i < (fobj ? fobj->shared_count : 0) && !ret; ++i) {
>                  struct nouveau_channel *prev = NULL;
>                  bool must_wait = true;
> 
> 
> With that it works and I don't see the flickering in a short test. I 
> will do more testing, but maybe Dan can test, too.
> 
> Cheers,
> Stefan

After fixing the typo the patch is working for me, also. dmesg is also
clean. I will continue running the patched kernel. If I see any
issues, I will report back here.

Cheers,

-- Dan

Re: [Nouveau] Regression in 5.15 in nouveau

[Stefan Fritsch]

On 07.12.21 21:45, Dan Moulding wrote:
>> There is a pretty obvious typo in there:
>>
>> --- a/drivers/gpu/drm/nouveau/nouveau_fence.c
>> +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
>> @@ -359,7 +359,7 @@ nouveau_fence_sync(struct nouveau_bo *nvbo, struct
>> nouveau_channel *chan, bool e
>>                   fobj = dma_resv_shared_list(resv);
>>           }
>>
>> -       for (i = 0; (i < fobj ? fobj->shared_count : 0) && !ret; ++i) {
>> +       for (i = 0; i < (fobj ? fobj->shared_count : 0) && !ret; ++i) {
>>                   struct nouveau_channel *prev = NULL;
>>                   bool must_wait = true;
>>
>>
>> With that it works and I don't see the flickering in a short test. I
>> will do more testing, but maybe Dan can test, too.
>>
>> Cheers,
>> Stefan
> 
> After fixing the typo the patch is working for me, also. dmesg is also
> clean. I will continue running the patched kernel. If I see any
> issues, I will report back here.

OK, looks good: I have tested it on top of v5.15.5 for a day and no 
black flickering and no other problems. I am not qualified to review the 
patch, though.

Thanks for the quick responses to everyone.

Cheers,
Stefan

Re: [Nouveau] Regression in 5.15 in nouveau

[Christian König]

Am 07.12.21 um 21:45 schrieb Dan Moulding:
>> There is a pretty obvious typo in there:
>>
>> --- a/drivers/gpu/drm/nouveau/nouveau_fence.c
>> +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
>> @@ -359,7 +359,7 @@ nouveau_fence_sync(struct nouveau_bo *nvbo, struct
>> nouveau_channel *chan, bool e
>>                   fobj = dma_resv_shared_list(resv);
>>           }
>>
>> -       for (i = 0; (i < fobj ? fobj->shared_count : 0) && !ret; ++i) {
>> +       for (i = 0; i < (fobj ? fobj->shared_count : 0) && !ret; ++i) {
>>                   struct nouveau_channel *prev = NULL;
>>                   bool must_wait = true;
>>
>>
>> With that it works and I don't see the flickering in a short test. I
>> will do more testing, but maybe Dan can test, too.
>>
>> Cheers,
>> Stefan
> After fixing the typo the patch is working for me, also. dmesg is also
> clean. I will continue running the patched kernel. If I see any
> issues, I will report back here.

Thanks for fixing that stupid typo. I've just send out an updated 
version to the mailing list with everybody in CC.

Please review and/or comment further.

Regards,
Christian.

>
> Cheers,
>
> -- Dan

Re: Regression in 5.15 in nouveau #forregzbot

[Thorsten Leemhuis]

Hi, this is your Linux kernel regression tracker speaking. For the record:

https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=67f74302f45d5d862f22ced3297624e50ac352f0

#regzbot fixed-by: 67f74302f45d5d862f22ced3297624e50ac352f0

Ciao, Thorsten

P.S.: As a Linux kernel regression tracker I'm getting a lot of reports
on my table. I can only look briefly into most of them. Unfortunately
therefore I sometimes will get things wrong or miss something important.
I hope that's not the case here; if you think it is, don't hesitate to
tell me about it in a public reply. That's in everyone's interest, as
what I wrote above might be misleading to everyone reading this; any
suggestion I gave thus might sent someone reading this down the wrong
rabbit hole, which none of us wants.

BTW, I have no personal interest in this issue, which is tracked using
regzbot, my Linux kernel regression tracking bot
(https://linux-regtracking.leemhuis.info/regzbot/). I'm only posting
this mail to get things rolling again and hence don't need to be CC on
all further activities wrt to this regression.


TWIMC: this mail is primarily send for documentation purposes and for
regzbot, my Linux kernel regression tracking bot. These mails usually
contain '#forregzbot' in the subject, to make them easy to spot and filter.

Ciao, Thorsten, your Linux kernel regression tracker.

On 06.12.21 14:19, Thorsten Leemhuis wrote:
> [TLDR: adding this regression to regzbot; most of this mail is compiled
> from a few templates paragraphs some of you will have seen aready.]
> 
> Hi, this is your Linux kernel regression tracker speaking.
> 
> Top-posting for once, to make this easy accessible to everyone.
> 
> Adding the regression mailing list to the list of recipients, as it
> should be in the loop for all regressions, as explained here:
> https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html
> 
> To be sure this issue doesn't fall through the cracks unnoticed, I'm
> adding it to regzbot, my Linux kernel regression tracking bot:
> 
> #regzbot ^introduced 3e1ad79bf66165bdb2baca3989f9227939241f11
> #regzbot title drm: nouveau: annoying black flickering in some
> applications with KDE Plasma with Xorg
> #regzbot ignore-activity
> 
> Reminder: when fixing the issue, please add a 'Link:' tag with the URL
> to the report (the parent of this mail), then regzbot will automatically
> mark the regression as resolved once the fix lands in the appropriate
> tree. For more details about regzbot see footer.
> 
> Sending this to everyone that got the initial report, to make all aware
> of the tracking. I also hope that messages like this motivate people to
> directly get at least the regression mailing list and ideally even
> regzbot involved when dealing with regressions, as messages like this
> wouldn't be needed then.
> 
> Don't worry, I'll send further messages wrt to this regression just to
> the lists (with a tag in the subject so people can filter them away), as
> long as they are intended just for regzbot. With a bit of luck no such
> messages will be needed anyway.
> 
> Ciao, Thorsten, your Linux kernel regression tracker.
> 
> P.S.: As a Linux kernel regression tracker I'm getting a lot of reports
> on my table. I can only look briefly into most of them. Unfortunately
> therefore I sometimes will get things wrong or miss something important.
> I hope that's not the case here; if you think it is, don't hesitate to
> tell me about it in a public reply. That's in everyone's interest, as
> what I wrote above might be misleading to everyone reading this; any
> suggestion I gave they thus might sent someone reading this down the
> wrong rabbit hole, which none of us wants.
> 
> BTW, I have no personal interest in this issue, which is tracked using
> regzbot, my Linux kernel regression tracking bot
> (https://linux-regtracking.leemhuis.info/regzbot/). I'm only posting
> this mail to get things rolling again and hence don't need to be CC on
> all further activities wrt to this regression.
> 
> 
> On 04.12.21 17:40, Stefan Fritsch wrote:
>> Hi,
>>
>> when updating from 5.14 to 5.15 on a system with NVIDIA GP108 [GeForce
>> GT 1030] (NV138) and Ryzen 9 3900XT using kde/plasma on X (not wayland),
>> there is a regression: There is now some annoying black flickering in
>> some applications, for example thunderbird, firefox, or mpv. It mostly
>> happens when scrolling or when playing video. Only the window of the
>> application flickers, not the whole screen. But the flickering is not
>> limited to the scrolled area: for example in firefox the url and
>> bookmark bars flicker, too, not only the web site. I have bisected the
>> issue to this commit:
>>
>> commit 3e1ad79bf66165bdb2baca3989f9227939241f11 (HEAD)
>> Author: Christian König <christian.koenig@amd.com>
>> Date:   Sun Jun 6 11:50:15 2021 +0200
>>
>>     drm/nouveau: always wait for the exclusive fence
>>
>>     Drivers also need to to sync to the exclusive fence when
>>     a shared one is present.
>>
>>     Signed-off-by: Christian König <christian.koenig@amd.com>
>>     Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>     Link:
>> https://patchwork.freedesktop.org/patch/msgid/20210702111642.17259-4-christian.koenig@amd.com
>>
>>
>>
>> This sounds like performance is impacted severely by that commit. Can
>> this be fixed somehow? A partial dmesg is below.
>>
>> Cheers,
>> Stefan
>>
>>
>> dmesg |grep -i -e drm -e dri -e nvidia -e nouveau -e fb
>> [    0.000000] BIOS-e820: [mem 0x00000000bc552000-0x00000000bc8fbfff]
>> reserved
>> [    0.004971] ACPI: XSDT 0x00000000BCFB0728 0000CC (v01 ALASKA A M I
>> 01072009 AMI  01000013)
>> [    0.010838] PM: hibernation: Registered nosave memory: [mem
>> 0xbc552000-0xbc8fbfff]
>> [    0.204873] Performance Events: Fam17h+ core perfctr, AMD PMU driver.
>> [    0.292761] Registering PCC driver as Mailbox controller
>> [    0.292761] acpiphp: ACPI Hot Plug PCI Controller Driver version: 0.5
>> [    0.518295] pci 0000:06:00.0: reg 0x10: [mem 0xfb000000-0xfbffffff]
>> [    0.519132] pci 0000:06:00.1: [10de:0fb8] type 00 class 0x040300
>> [    0.519653] pci 0000:00:03.1:   bridge window [mem
>> 0xfb000000-0xfc0fffff]
>> [    0.549101] pci 0000:00:03.1:   bridge window [mem
>> 0xfb000000-0xfc0fffff]
>> [    0.550994] pci_bus 0000:06: resource 1 [mem 0xfb000000-0xfc0fffff]
>> [    0.561285] Block layer SCSI generic (bsg) driver version 0.4 loaded
>> (major 250)
>> [    0.564152] shpchp: Standard Hot Plug PCI Controller Driver version: 0.4
>> [    0.570870] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
>> [    0.571531] AMD-Vi: AMD IOMMUv2 driver by Joerg Roedel <jroedel@suse.de>
>> [    0.988343] microcode: Microcode Update Driver: v2.2.
>> [    1.112435] ACPI: OSL: Resource conflict; ACPI support missing from
>> driver?
>> [    1.114174] usbcore: registered new interface driver usbfs
>> [    1.114331] usbcore: registered new interface driver hub
>> [    1.114599] usbcore: registered new device driver usb
>> [    2.373857] hid: raw HID events driver (C) Jiri Kosina
>> [    2.378553] usbcore: registered new interface driver usbhid
>> [    2.378641] usbhid: USB HID core driver
>> [    2.581069] ata3.00: supports DRM functions and may not be fully
>> accessible
>> [    2.582388] ata3.00: supports DRM functions and may not be fully
>> accessible
>> [    3.371574] ata5.00: supports DRM functions and may not be fully
>> accessible
>> [    3.396636] ata5.00: supports DRM functions and may not be fully
>> accessible
>> [    4.159005] sr 1:0:0:0: [sr0] scsi3-mmc drive: 48x/48x writer dvd-ram
>> cd/rw xa/form2 cdda tray
>> [    4.159120] cdrom: Uniform CD-ROM driver Revision: 3.20
>> [    5.936017] systemd[1]: Starting Load Kernel Module drm...
>> [    5.957038] systemd[1]: modprobe@drm.service: Deactivated successfully.
>> [    5.957238] systemd[1]: Finished Load Kernel Module drm.
>> [    6.104901] sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver
>> [    6.122007] usbcore: registered new device driver apple-mfi-fastcharge
>> [    6.213866] input: HDA NVidia HDMI/DP,pcm=3 as
>> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input8
>> [    6.236581] AMD64 EDAC driver v3.5.0
>> [    6.259473] input: HDA NVidia HDMI/DP,pcm=7 as
>> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input9
>> [    6.259631] input: HDA NVidia HDMI/DP,pcm=8 as
>> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input10
>> [    6.260559] input: HDA NVidia HDMI/DP,pcm=9 as
>> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input11
>> [    6.260913] input: HDA NVidia HDMI/DP,pcm=10 as
>> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input12
>> [    6.485220] nouveau 0000:06:00.0: vgaarb: deactivate vga console
>> [    6.486484] nouveau 0000:06:00.0: NVIDIA GP108 (138000a1)
>> [    6.612994] nouveau 0000:06:00.0: bios: version 86.08.24.00.23
>> [    6.617303] nouveau 0000:06:00.0: pmu: firmware unavailable
>> [    6.621410] nouveau 0000:06:00.0: fb: 2048 MiB GDDR5
>> [    6.653892] nouveau 0000:06:00.0: DRM: VRAM: 2048 MiB
>> [    6.653895] nouveau 0000:06:00.0: DRM: GART: 536870912 MiB
>> [    6.653897] nouveau 0000:06:00.0: DRM: BIT table 'A' not found
>> [    6.653899] nouveau 0000:06:00.0: DRM: BIT table 'L' not found
>> [    6.653900] nouveau 0000:06:00.0: DRM: TMDS table version 2.0
>> [    6.653902] nouveau 0000:06:00.0: DRM: DCB version 4.1
>> [    6.653904] nouveau 0000:06:00.0: DRM: DCB outp 00: 01800346 04600010
>> [    6.653906] nouveau 0000:06:00.0: DRM: DCB outp 01: 01000342 00020010
>> [    6.653908] nouveau 0000:06:00.0: DRM: DCB outp 02: 01011352 00020020
>> [    6.653909] nouveau 0000:06:00.0: DRM: DCB conn 00: 00001046
>> [    6.653911] nouveau 0000:06:00.0: DRM: DCB conn 01: 00002161
>> [    6.654295] nouveau 0000:06:00.0: DRM: MM: using COPY for buffer copies
>> [    6.655460] snd_hda_intel 0000:06:00.1: bound 0000:06:00.0 (ops
>> nv50_audio_component_bind_ops [nouveau])
>> [    6.828018] nouveau 0000:06:00.0: DRM: allocated 3840x2160 fb:
>> 0x200000, bo 000000001a41f1fe
>> [    6.828086] fbcon: nouveau (fb0) is primary device
>> [    6.915486] nouveau 0000:06:00.0: [drm] fb0: nouveau frame buffer device
>> [    6.939244] [drm] Initialized nouveau 1.3.1 20120801 for 0000:06:00.0
>> on minor 0
>> [   11.338075] audit: type=1400 audit(1638634273.245:6):
>> apparmor="STATUS" operation="profile_load" profile="unconfined"
>> name="nvidia_modprobe" pid=1354 comm="apparmor_parser"
>> [   11.338078] audit: type=1400 audit(1638634273.245:7):
>> apparmor="STATUS" operation="profile_load" profile="unconfined"
>> name="nvidia_modprobe//kmod" pid=1354 comm="apparmor_parser"
>> [   11.479123] RTL8226B_RTL8221B 2.5Gbps PHY r8169-500:00: attached PHY
>> driver (mii_bus:phy_addr=r8169-500:00, irq=MAC)
>> stf@k:~/comp/linux/linux$ sudo dmesg |less
>> stf@k:~/comp/linux/linux$ sudo dmesg |grep -i -e drm -e dri -e nvidia -e
>> nouveau -e fb
>> [    0.000000] BIOS-e820: [mem 0x00000000bc552000-0x00000000bc8fbfff]
>> reserved
>> [    0.004971] ACPI: XSDT 0x00000000BCFB0728 0000CC (v01 ALASKA A M I
>> 01072009 AMI  01000013)
>> [    0.010838] PM: hibernation: Registered nosave memory: [mem
>> 0xbc552000-0xbc8fbfff]
>> [    0.204873] Performance Events: Fam17h+ core perfctr, AMD PMU driver.
>> [    0.292761] Registering PCC driver as Mailbox controller
>> [    0.292761] acpiphp: ACPI Hot Plug PCI Controller Driver version: 0.5
>> [    0.518295] pci 0000:06:00.0: reg 0x10: [mem 0xfb000000-0xfbffffff]
>> [    0.519132] pci 0000:06:00.1: [10de:0fb8] type 00 class 0x040300
>> [    0.519653] pci 0000:00:03.1:   bridge window [mem
>> 0xfb000000-0xfc0fffff]
>> [    0.549101] pci 0000:00:03.1:   bridge window [mem
>> 0xfb000000-0xfc0fffff]
>> [    0.550994] pci_bus 0000:06: resource 1 [mem 0xfb000000-0xfc0fffff]
>> [    0.561285] Block layer SCSI generic (bsg) driver version 0.4 loaded
>> (major 250)
>> [    0.564152] shpchp: Standard Hot Plug PCI Controller Driver version: 0.4
>> [    0.570870] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
>> [    0.571531] AMD-Vi: AMD IOMMUv2 driver by Joerg Roedel <jroedel@suse.de>
>> [    0.988343] microcode: Microcode Update Driver: v2.2.
>> [    1.112435] ACPI: OSL: Resource conflict; ACPI support missing from
>> driver?
>> [    1.114174] usbcore: registered new interface driver usbfs
>> [    1.114331] usbcore: registered new interface driver hub
>> [    1.114599] usbcore: registered new device driver usb
>> [    2.373857] hid: raw HID events driver (C) Jiri Kosina
>> [    2.378553] usbcore: registered new interface driver usbhid
>> [    2.378641] usbhid: USB HID core driver
>> [    2.581069] ata3.00: supports DRM functions and may not be fully
>> accessible
>> [    2.582388] ata3.00: supports DRM functions and may not be fully
>> accessible
>> [    3.371574] ata5.00: supports DRM functions and may not be fully
>> accessible
>> [    3.396636] ata5.00: supports DRM functions and may not be fully
>> accessible
>> [    4.159005] sr 1:0:0:0: [sr0] scsi3-mmc drive: 48x/48x writer dvd-ram
>> cd/rw xa/form2 cdda tray
>> [    4.159120] cdrom: Uniform CD-ROM driver Revision: 3.20
>> [    5.936017] systemd[1]: Starting Load Kernel Module drm...
>> [    5.957038] systemd[1]: modprobe@drm.service: Deactivated successfully.
>> [    5.957238] systemd[1]: Finished Load Kernel Module drm.
>> [    6.104901] sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver
>> [    6.122007] usbcore: registered new device driver apple-mfi-fastcharge
>> [    6.213866] input: HDA NVidia HDMI/DP,pcm=3 as
>> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input8
>> [    6.236581] AMD64 EDAC driver v3.5.0
>> [    6.259473] input: HDA NVidia HDMI/DP,pcm=7 as
>> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input9
>> [    6.259631] input: HDA NVidia HDMI/DP,pcm=8 as
>> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input10
>> [    6.260559] input: HDA NVidia HDMI/DP,pcm=9 as
>> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input11
>> [    6.260913] input: HDA NVidia HDMI/DP,pcm=10 as
>> /devices/pci0000:00/0000:00:03.1/0000:06:00.1/sound/card0/input12
>> [    6.485220] nouveau 0000:06:00.0: vgaarb: deactivate vga console
>> [    6.486484] nouveau 0000:06:00.0: NVIDIA GP108 (138000a1)
>> [    6.612994] nouveau 0000:06:00.0: bios: version 86.08.24.00.23
>> [    6.617303] nouveau 0000:06:00.0: pmu: firmware unavailable
>> [    6.621410] nouveau 0000:06:00.0: fb: 2048 MiB GDDR5
>> [    6.653892] nouveau 0000:06:00.0: DRM: VRAM: 2048 MiB
>> [    6.653895] nouveau 0000:06:00.0: DRM: GART: 536870912 MiB
>> [    6.653897] nouveau 0000:06:00.0: DRM: BIT table 'A' not found
>> [    6.653899] nouveau 0000:06:00.0: DRM: BIT table 'L' not found
>> [    6.653900] nouveau 0000:06:00.0: DRM: TMDS table version 2.0
>> [    6.653902] nouveau 0000:06:00.0: DRM: DCB version 4.1
>> [    6.653904] nouveau 0000:06:00.0: DRM: DCB outp 00: 01800346 04600010
>> [    6.653906] nouveau 0000:06:00.0: DRM: DCB outp 01: 01000342 00020010
>> [    6.653908] nouveau 0000:06:00.0: DRM: DCB outp 02: 01011352 00020020
>> [    6.653909] nouveau 0000:06:00.0: DRM: DCB conn 00: 00001046
>> [    6.653911] nouveau 0000:06:00.0: DRM: DCB conn 01: 00002161
>> [    6.654295] nouveau 0000:06:00.0: DRM: MM: using COPY for buffer copies
>> [    6.655460] snd_hda_intel 0000:06:00.1: bound 0000:06:00.0 (ops
>> nv50_audio_component_bind_ops [nouveau])
>> [    6.828018] nouveau 0000:06:00.0: DRM: allocated 3840x2160 fb:
>> 0x200000, bo 000000001a41f1fe
>> [    6.828086] fbcon: nouveau (fb0) is primary device
>> [    6.915486] nouveau 0000:06:00.0: [drm] fb0: nouveau frame buffer device
>> [    6.939244] [drm] Initialized nouveau 1.3.1 20120801 for 0000:06:00.0
>> on minor 0
>> [   11.338075] audit: type=1400 audit(1638634273.245:6):
>> apparmor="STATUS" operation="profile_load" profile="unconfined"
>> name="nvidia_modprobe" pid=1354 comm="apparmor_parser"
>> [   11.338078] audit: type=1400 audit(1638634273.245:7):
>> apparmor="STATUS" operation="profile_load" profile="unconfined"
>> name="nvidia_modprobe//kmod" pid=1354 comm="apparmor_parser"
>> [   11.479123] RTL8226B_RTL8221B 2.5Gbps PHY r8169-500:00: attached PHY
>> driver (mii_bus:phy_addr=r8169-500:00, irq=MAC)
>>
>