From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5132428EF for ; Tue, 14 Mar 2023 09:35:43 +0000 (UTC) Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1pc14E-0005Zv-CV; Tue, 14 Mar 2023 10:35:38 +0100 Message-ID: <4268d0ac-278a-28e4-66d1-e0347f011f46@leemhuis.info> Date: Tue, 14 Mar 2023 10:35:33 +0100 Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [REGRESSION] suspend to ram fails in 6.2-rc1 due to tpm errors Content-Language: en-US, de-DE To: "Jason A. Donenfeld" Cc: James Bottomley , Vlastimil Babka , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Jan Dabros , regressions@lists.linux.dev, LKML , linux-integrity@vger.kernel.org, Dominik Brodowski , Herbert Xu , Linus Torvalds , Johannes Altmanninger References: <7cbe96cf-e0b5-ba63-d1b4-f63d2e826efa@suse.cz> <7ebab1ff-48f1-2737-f0d3-25c72666d041@leemhuis.info> From: Thorsten Leemhuis In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1678786543;a6c33ef7; X-HE-SMSGID: 1pc14E-0005Zv-CV On 09.01.23 17:08, Jason A. Donenfeld wrote: > On Thu, Jan 05, 2023 at 02:59:15PM +0100, Thorsten Leemhuis wrote: >> On 29.12.22 05:03, Jason A. Donenfeld wrote: >>> On Wed, Dec 28, 2022 at 06:07:25PM -0500, James Bottomley wrote: >>>> On Wed, 2022-12-28 at 21:22 +0100, Vlastimil Babka wrote: >>>>> Ugh, while the problem [1] was fixed in 6.1, it's now happening again >>>>> on the T460 with 6.2-rc1. Except I didn't see any oops message or >>>>> "tpm_try_transmit" error this time. The first indication of a problem >>>>> is this during a resume from suspend to ram: >>>>> tpm tpm0: A TPM error (28) occurred continue selftest >>>>> and then periodically >>>>> tpm tpm0: A TPM error (28) occurred attempting get random >>>> >>>> That's a TPM 1.2 error which means the TPM failed the selftest. The >>>> original problem was reported against TPM 2.0 because of a missing >>>> try_get_ops(). >>> >>> No, I'm pretty sure the original bug, which was fixed by "char: tpm: >>> Protect tpm_pm_suspend with locks" regards 1.2 as well, especially >>> considering it's the same hardware from Vlastimil causing this. I also >>> recall seeing this in 1.2 when I ran this with the TPM emulator. So >>> that's not correct. > [...] > So, this is now in rc3: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1382999aa0548a171a272ca817f6c38e797c458c > > That should help avoid the worst of the issue -- laptop not sleeping. > But the race or whatever it is still does exist. So you might want to > keep this in your tracker to periodically nudge the TPM folks about it. I did, and with -rc2 out now is a good time to remind everybody about it. Jarkko even looked into it, but no real fix emerged afaics. Or did it? Ciao, Thorsten