From: Thorsten Leemhuis <regressions@leemhuis.info>
To: "regressions@lists.linux.dev" <regressions@lists.linux.dev>
Subject: Re: [PATCH][SMB3] fix multiuser mount regression #forregzbot
Date: Sat, 19 Mar 2022 05:55:15 +0100 [thread overview]
Message-ID: <52d3ab3d-52a1-c6bb-ce42-2a90023da0dd@leemhuis.info> (raw)
In-Reply-To: <045ed627-e054-a42d-c3ec-e4e44bd1cf81@leemhuis.info>
On 18.03.22 15:41, Thorsten Leemhuis wrote:
> TWIMC: this mail is primarily send for documentation purposes and for
> regzbot, my Linux kernel regression tracking bot. These mails usually
> contain '#forregzbot' in the subject, to make them easy to spot and filter.
#regzbot fixed-by: e3ee9fb22652f228
> Seems below regression soon will be getting fixed, but with the nearing
> final I want to have this in the tracking to make sure everyone is aware
> of it:
>
> #regzbot ^introduced 73f9bfbe3d81
> #regzbot title cifs: smb3: incorrect session setup check for multiuser
> mounts
> #regzbot ignore-activity
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>
> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> reports on my table. I can only look briefly into most of them and lack
> knowledge about most of the areas they concern. I thus unfortunately
> will sometimes get things wrong or miss something important. I hope
> that's not the case here; if you think it is, don't hesitate to tell me
> in a public reply, it's in everyone's interest to set the public record
> straight.
>
>
>
> On 17.03.22 04:20, Steve French wrote:
>> cifssmb3: fix incorrect session setup check for multiuser mounts
>>
>> A recent change to how the SMB3 server (socket) and session status
>> is managed regressed multiuser mounts by changing the check
>> for whether session setup is needed to the socket (TCP_Server_info)
>> structure instead of the session struct (cifs_ses). Add additional
>> check in cifs_setup_sesion to fix this.
>>
>> Fixes: 73f9bfbe3d81 ("cifs: maintain a state machine for tcp/smb/tcon sessions")
>> Reported-by: Ronnie Sahlberg <lsahlber@redhat.com>
>> Signed-off-by: Steve French <stfrench@microsoft.com>
>> ---
>> fs/cifs/connect.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
>> index 053cb449eb16..d3020abfe404 100644
>> --- a/fs/cifs/connect.c
>> +++ b/fs/cifs/connect.c
>> @@ -3924,7 +3924,8 @@ cifs_setup_session(const unsigned int xid,
>> struct cifs_ses *ses,
>>
>> /* only send once per connect */
>> spin_lock(&cifs_tcp_ses_lock);
>> - if (server->tcpStatus != CifsNeedSessSetup) {
>> + if ((server->tcpStatus != CifsNeedSessSetup) &&
>> + (ses->status == CifsGood)) {
>> spin_unlock(&cifs_tcp_ses_lock);
>> return 0;
>> }
>>
prev parent reply other threads:[~2022-03-19 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAH2r5mth2fYLzU5+oN09ipT7peRdyAiPCF-7_fLPsTpA-fKKLA@mail.gmail.com>
2022-03-18 14:41 ` [PATCH][SMB3] fix multiuser mount regression #forregzbot Thorsten Leemhuis
2022-03-19 4:55 ` Thorsten Leemhuis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52d3ab3d-52a1-c6bb-ce42-2a90023da0dd@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).