nfs: noresvport + nfsv4 no longer working as expected (fwd from bugzilla)

nfs: noresvport + nfsv4 no longer working as expected (fwd from bugzilla)

[Thorsten Leemhuis]

Hi, this is your Linux kernel regression tracker speaking.

There is a regression dealt with in bugzilla I'd like to add to the
tracking:

#regzbot introduced: v5.11.11..v5.12.19
#regzbot from: Daire Byrne <daire@dneg.com>
#regzbot title: nfs: noresvport + nfsv4 no longer working as expected
#regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=215526

Quote:

> When mounting with "-o vers=4.2,noresvport", it seems to be ignored such that the client still uses a reserved port (or ports with nconnect).
> 
> It still works as expected when doing "-o vers=3,noresvport".
> 
> A very quick test of some kernels I had prebuilt suggests this stopped working somewhere between 5.11.11 and 5.12.19. That might make it one of:
> 
>     * tag 'nfs-for-5.12-2' of git://git.linux-nfs.org/projects/anna/linux-nfs:
>       nfs: we don't support removing system.nfs4_acl
>       NFSv4.2: fix return value of _nfs4_get_security_label()
>       NFS: Fix open coded versions of nfs_set_cache_invalid() in NFSv4
>       NFS: Fix open coded versions of nfs_set_cache_invalid()
>       NFS: Clean up function nfs_mark_dir_for_revalidate()
>       NFS: Don't gratuitously clear the inode cache when lookup failed
>       NFS: Don't revalidate the directory permissions on a lookup failure
>       SUNRPC: Set memalloc_nofs_save() for sync tasks
>       NFS: Correct size calculation for create reply length
>       nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default
> 
> I will try and get a bisect done this week.

Ciao, Thorsten (wearing his 'Linux kernel regression tracker' hat)

P.S.: As a Linux kernel regression tracker I'm getting a lot of reports
on my table. I can only look briefly into most of them. Unfortunately
therefore I sometimes will get things wrong or miss something important.
I hope that's not the case here; if you think it is, don't hesitate to
tell me about it in a public reply, that's in everyone's interest.

BTW, I have no personal interest in this issue, which is tracked using
regzbot, my Linux kernel regression tracking bot
(https://linux-regtracking.leemhuis.info/regzbot/). I'm only posting
this mail to get things rolling again and hence don't need to be CC on
all further activities wrt to this regression.

---
Additional information about regzbot:

If you want to know more about regzbot, check out its web-interface, the
getting start guide, and/or the references documentation:

https://linux-regtracking.leemhuis.info/regzbot/
https://gitlab.com/knurd42/regzbot/-/blob/main/docs/getting_started.md
https://gitlab.com/knurd42/regzbot/-/blob/main/docs/reference.md

The last two documents will explain how you can interact with regzbot
yourself if your want to.

Hint for reporters: when reporting a regression it's in your interest to
tell #regzbot about it in the report, as that will ensure the regression
gets on the radar of regzbot and the regression tracker. That's in your
interest, as they will make sure the report won't fall through the
cracks unnoticed.

Hint for developers: you normally don't need to care about regzbot once
it's involved. Fix the issue as you normally would, just remember to
include a 'Link:' tag to the report in the commit message, as explained
in Documentation/process/submitting-patches.rst
That aspect was recently was made more explicit in commit 1f57bd42b77c:
https://git.kernel.org/linus/1f57bd42b77c

Re: nfs: noresvport + nfsv4 no longer working as expected (fwd from bugzilla) #forregzbot

[Thorsten Leemhuis]

TWIMC: this mail is primarily send for documentation purposes and for
regzbot, my Linux kernel regression tracking bot. These mails usually
contain '#forregzbot' in the subject, to make them easy to spot and filter.

#regzbot fixed-by: 468d126dab45718feeb7283

On 26.01.22 08:42, Thorsten Leemhuis wrote:
> Hi, this is your Linux kernel regression tracker speaking.
> 
> There is a regression dealt with in bugzilla I'd like to add to the
> tracking:
> 
> #regzbot introduced: v5.11.11..v5.12.19
> #regzbot from: Daire Byrne <daire@dneg.com>
> #regzbot title: nfs: noresvport + nfsv4 no longer working as expected
> #regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=215526
> 
> Quote:
> 
>> When mounting with "-o vers=4.2,noresvport", it seems to be ignored such that the client still uses a reserved port (or ports with nconnect).
>>
>> It still works as expected when doing "-o vers=3,noresvport".
>>
>> A very quick test of some kernels I had prebuilt suggests this stopped working somewhere between 5.11.11 and 5.12.19. That might make it one of:
>>
>>     * tag 'nfs-for-5.12-2' of git://git.linux-nfs.org/projects/anna/linux-nfs:
>>       nfs: we don't support removing system.nfs4_acl
>>       NFSv4.2: fix return value of _nfs4_get_security_label()
>>       NFS: Fix open coded versions of nfs_set_cache_invalid() in NFSv4
>>       NFS: Fix open coded versions of nfs_set_cache_invalid()
>>       NFS: Clean up function nfs_mark_dir_for_revalidate()
>>       NFS: Don't gratuitously clear the inode cache when lookup failed
>>       NFS: Don't revalidate the directory permissions on a lookup failure
>>       SUNRPC: Set memalloc_nofs_save() for sync tasks
>>       NFS: Correct size calculation for create reply length
>>       nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default
>>
>> I will try and get a bisect done this week.
> 
> Ciao, Thorsten (wearing his 'Linux kernel regression tracker' hat)
> 
> P.S.: As a Linux kernel regression tracker I'm getting a lot of reports
> on my table. I can only look briefly into most of them. Unfortunately
> therefore I sometimes will get things wrong or miss something important.
> I hope that's not the case here; if you think it is, don't hesitate to
> tell me about it in a public reply, that's in everyone's interest.
> 
> BTW, I have no personal interest in this issue, which is tracked using
> regzbot, my Linux kernel regression tracking bot
> (https://linux-regtracking.leemhuis.info/regzbot/). I'm only posting
> this mail to get things rolling again and hence don't need to be CC on
> all further activities wrt to this regression.
> 
> ---
> Additional information about regzbot:
> 
> If you want to know more about regzbot, check out its web-interface, the
> getting start guide, and/or the references documentation:
> 
> https://linux-regtracking.leemhuis.info/regzbot/
> https://gitlab.com/knurd42/regzbot/-/blob/main/docs/getting_started.md
> https://gitlab.com/knurd42/regzbot/-/blob/main/docs/reference.md
> 
> The last two documents will explain how you can interact with regzbot
> yourself if your want to.
> 
> Hint for reporters: when reporting a regression it's in your interest to
> tell #regzbot about it in the report, as that will ensure the regression
> gets on the radar of regzbot and the regression tracker. That's in your
> interest, as they will make sure the report won't fall through the
> cracks unnoticed.
> 
> Hint for developers: you normally don't need to care about regzbot once
> it's involved. Fix the issue as you normally would, just remember to
> include a 'Link:' tag to the report in the commit message, as explained
> in Documentation/process/submitting-patches.rst
> That aspect was recently was made more explicit in commit 1f57bd42b77c:
> https://git.kernel.org/linus/1f57bd42b77c