From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73D935385 for ; Mon, 17 Apr 2023 11:25:20 +0000 (UTC) Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1poMyw-0000Lo-Iw; Mon, 17 Apr 2023 13:25:14 +0200 Message-ID: <69602f1b-4afa-d864-b6d3-d8237f81a51d@leemhuis.info> Date: Mon, 17 Apr 2023 13:25:13 +0200 Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: kernel error at led trigger "phy0tpt" Content-Language: en-US, de-DE To: AngeloGioacchino Del Regno , Bagas Sanjaya , Tobias Dahms , Sean Wang Cc: stable@vger.kernel.org, Pavel Machek , Lee Jones , LKML , linux-leds@vger.kernel.org, linux-wireless@vger.kernel.org, Linux regressions mailing list , Matthias Brugger References: <91feceb2-0df4-19b9-5ffa-d37e3d344fdf@web.de> <3fcc707b-f757-e74b-2800-3b6314217868@leemhuis.info> <8b07ead5-f105-da86-e7da-ee49616f7c1d@collabora.com> From: "Linux regression tracking (Thorsten Leemhuis)" Reply-To: Linux regressions mailing list In-Reply-To: <8b07ead5-f105-da86-e7da-ee49616f7c1d@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1681730720;f968533a; X-HE-SMSGID: 1poMyw-0000Lo-Iw [adding Matthias to the list of recipients, who back then applied to culprit] Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone. AngeloGioacchino, Has any progress been made to fix below regression? It doesn't look like it from here, hence I wondered if it fall through the cracks. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page. #regzbot poke On 27.03.23 10:23, AngeloGioacchino Del Regno wrote: > Il 26/03/23 15:23, Bagas Sanjaya ha scritto: >> On 3/26/23 02:20, Tobias Dahms wrote: >>> Hello, >>> >>> the bisection gives following result: >>> -------------------------------------------------------------------- >>> 18c7deca2b812537aa4d928900e208710f1300aa is the first bad commit >>> commit 18c7deca2b812537aa4d928900e208710f1300aa >>> Author: AngeloGioacchino Del Regno >>> >>> Date:   Tue May 17 12:47:08 2022 +0200 >>> >>>      soc: mediatek: pwrap: Use readx_poll_timeout() instead of custom >>> function >>> >>>      Function pwrap_wait_for_state() is a function that polls an address >>>      through a helper function, but this is the very same operation that >>>      the readx_poll_timeout macro means to do. >>>      Convert all instances of calling pwrap_wait_for_state() to instead >>>      use the read_poll_timeout macro. >>> >>>      Signed-off-by: AngeloGioacchino Del Regno >>> >>>      Reviewed-by: Nícolas F. R. A. Prado >>>      Tested-by: Nícolas F. R. A. Prado >>>      Link: >>> https://lore.kernel.org/r/20220517104712.24579-2-angelogioacchino.delregno@collabora.com >>>      Signed-off-by: Matthias Brugger >>> >>>   drivers/soc/mediatek/mtk-pmic-wrap.c | 60 >>> ++++++++++++++++++++---------------- >>>   1 file changed, 33 insertions(+), 27 deletions(-) >>> -------------------------------------------------------------------- >>> >> >> OK, I'm updating the regression status: >> >> #regzbot introduced: 18c7deca2b8125 >> >> And for replying, don't top-post, but rather reply inline with >> appropriate context instead; hence I cut the replied context. >> > > There are two possible solutions to that, specifically, either: >  1. Change readx_poll_timeout() to readx_poll_timeout_atomic(); or >  2. Fix the mt6323-led driver so that this operation gets done >     out of atomic context, which is IMO the option to prefer. > > Ideas? > > Regards, > Angelo > >