regressions.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>
Cc: Dusty Mabe <dusty@dustymabe.com>, Ming Lei <ming.lei@redhat.com>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-raid@vger.kernel.org,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>
Subject: Re: regression caused by block: freeze the queue earlier in del_gendisk
Date: Wed, 21 Sep 2022 11:25:59 +0200	[thread overview]
Message-ID: <6a3660b2-fa7d-14a2-6977-f50926ad369c@leemhuis.info> (raw)
In-Reply-To: <9594af4b-eb16-0a51-9a4a-e21bbce3317d@kernel.dk>

On 20.09.22 16:14, Jens Axboe wrote:
> On 9/20/22 8:12 AM, Christoph Hellwig wrote:
>> On Tue, Sep 20, 2022 at 08:05:06AM -0600, Jens Axboe wrote:
>>> Christoph and I discussed this one last week, and he has a plan to try
>>> a flag approach. Christoph, did you get a chance to bang that out? Would
>>> be nice to get this one wrapped up.
>>
>> I gave up on that as it will be far too much change so late in
>> the cycle and sent you the revert yesterday.
> 
> Gotcha, haven't made it all the way through the emails of the morning yet.
> I'll queue it up.

Thx to both of you for taking care of this.

Nitpicking: that patch is missing a "CC: stable@..." tag to ensure
automatic and quick backporting to 5.19.y. Or is the block layer among
the subsystems that prefer to handle such things manually?

Ohh, and a fixes tag might have been good as well; a "Link:" tag
pointing to the report, too. If either would have been there, regzbot
would have noticed Christoph's patch posting and I wouldn't have
bothered you yesterday. :-) But whatever, not that important.

#regzbot fixed-by: 4c66a326b5ab784cddd72d

Ciao, Thorsten

  reply	other threads:[~2022-09-21  9:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <017845ae-fbae-70f6-5f9e-29aff2742b8c@dustymabe.com>
2022-08-28 10:24 ` regression caused by block: freeze the queue earlier in del_gendisk Thorsten Leemhuis
2022-08-31 12:36   ` Thorsten Leemhuis
     [not found] ` <YxBZ4BBjxvAkvI2A@T590>
     [not found]   ` <20220907073324.GB23826@lst.de>
     [not found]     ` <Yxr4SD4d0rZ9TZik@T590>
     [not found]       ` <20220912071618.GA4971@lst.de>
     [not found]         ` <Yx/jLTknQm9VeHi4@T590>
     [not found]           ` <95cbd47d-46ed-850e-7d4f-851b35d03069@dustymabe.com>
2022-09-20  9:11             ` Thorsten Leemhuis
2022-09-20 14:05               ` Jens Axboe
2022-09-20 14:12                 ` Christoph Hellwig
2022-09-20 14:14                   ` Jens Axboe
2022-09-21  9:25                     ` Thorsten Leemhuis [this message]
2022-09-21 14:34                       ` Jens Axboe
2022-09-21 14:47                         ` Greg KH
2022-09-21 14:56                           ` Jens Axboe
2022-09-23 15:17                             ` 1649986
2022-09-26  7:09                             ` Greg KH
2022-10-28 17:50                           ` Burt.Beauchamp
2022-12-20 13:25                           ` Robert.Briscoe
2023-03-21 11:17                         ` Geneveve.Pizarro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a3660b2-fa7d-14a2-6977-f50926ad369c@leemhuis.info \
    --to=regressions@leemhuis.info \
    --cc=axboe@kernel.dk \
    --cc=dusty@dustymabe.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).