From: Aditya Garg <gargaditya08@live.com>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Orlando Chamberlain <redecorating@protonmail.com>,
Daniel Winkler <danielwinkler@google.com>,
Johan Hedberg <johan.hedberg@intel.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
Sonny Sasaka <sonnysasaka@chromium.org>
Subject: Re: [PATCHv2] Bluetooth: quirk disabling LE Read Transmit Power
Date: Wed, 17 Nov 2021 09:59:31 +0000 [thread overview]
Message-ID: <7E546B37-E7DE-454B-8AD2-F54F9C8C690D@live.com> (raw)
In-Reply-To: <8919a36b-e485-500a-2722-529ffa0d2598@leemhuis.info>
> On 17-Nov-2021, at 3:12 PM, Thorsten Leemhuis <regressions@leemhuis.info> wrote:
>
> On 17.11.21 10:26, Aditya Garg wrote:
>>> On 17-Nov-2021, at 12:55 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>>> On Wed, Nov 17, 2021 at 03:28:29AM +0000, Aditya Garg wrote:
>>>>> On 16-Nov-2021, at 2:56 PM, Thorsten Leemhuis <regressions@leemhuis.info> wrote:
>>>>> On 16.11.21 10:02, Orlando Chamberlain wrote:
>>>>>>> Bluetooth maintainers, what's the status here? The proposed patch is
>>>>>>> fixing a regression. It's not a recent one (it afaics was introduced in
>>>>>>> v5.11-rc1). Nevertheless it would be good to get this finally resolved.
>>>>>>> But this thread seems inactive for more than a week now. Or was progress
>>>>>>> made, but is only visible somewhere else?
>>>>>>
>>>>>> I think the best solution is getting broadcom to update their firmware,
>>>>>> I've just sent them a message through a form on their website, I couldn't
>>>>>> seem to get it to tell me "Your message has been sent", so it's possible
>>>>>> that it didn't submit (more likely I've sent the same message several times).
>>>>>>
>>>>>> If I hear back from them I'll send something here.
>>>>>
>>>>> Thx for that. But FWIW: from the point of the regression tracker that's
>>>>> not the best solution, as according to your report this is a regression.
>>>>> IOW: we deal with something that used to up to a certain kernel version
>>>>> and was broken by a change to the kernel. That is something frown upon
>>>>> in Linux kernel development, hence changes introducing regression are
>>>>> often quickly reverted, if they can't get fixed by follow up change quickly.
>>>>>
>>>>> That sentence has two "quickly", as we want to prevent more people
>>>>> running into the issue, resulting in a loss of trust. But that's what
>>>>> will happen if we wait for a firmware update to get developed, tested,
>>>>> published, and rolled out. And even then we can't expect users to have
>>>>> the latest firmware installed when they switch to a new kernel.
>>>>>
>>>>> Hence the best solution *afaics* might be: fix this in the kernel
>>>>> somehow now with a workaround; once the firmware update is out, change
>>>>> the kernel again to only apply the workaround if the old firmware is in use.
>>>> I have an idea. Can we make LE Read Transmit Power as a module parameter and users can turn it off if it is causing trouble. I have a patch for the same but haven't tested it yet.
>>>
>>> Module parameters are for the 1990's, please never add new ones as they
>>> modify code, not data, and you want to do something like this on a
>>> per-device basis, not on "all devices in the system", right?
>>
>> Exactly. Since the issue affects only a few Macs and not all devices.
>> In fact I have spotted just 2 Macs yet affected with this issue.
> When Greg said "per-device basis", he afaics meant: per-device in a
> system, as a module parameter would also affect a second bluetooth
> controller if there was one (say one connected via USB) -- and that
> shouldn't happen.
>
> And FWIW: it's still a regression if something that used to work
> suddenly requires a module parameter to get working.
>
> So if this just affects two macs, why can't the fix be realized as a
> quirk that is only enabled on those two systems? Or are they impossible
> to detect clearly via DMI data or something like that?
<RESENDING AS PLAIN TEXT>
A part of the output of dmidecode is below :-
Handle 0x0005, DMI type 1, 27 bytes
System Information
Manufacturer: Apple Inc.
Product Name: MacBookPro16,1
Version: 1.0
Serial Number: <Removed for Privacy>
UUID: <Removed for Privacy>
Wake-up Type: Power Switch
SKU Number:
Family: MacBook Pro
Handle 0x0006, DMI type 2, 17 bytes
Base Board Information
Manufacturer: Apple Inc.
Product Name: Mac-E1008331FDC96864
Version: MacBookPro16,1
Serial Number: <Removed for Privacy>
Asset Tag:
Features:
Board is a hosting board
Location In Chassis:
Chassis Handle: 0x0007
Type: Motherboard
Contained Object Handles: 0
The product name, MacBookPro16,1 in my case, is unique for each model. If possible a quirk to disable LE Read Transmit Power can be made on this basis.
>
> Ciao, Thorsten
next prev parent reply other threads:[~2021-11-17 9:59 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 5:09 [regression] Bluetooth: Query LE tx power on startup broke Bluetooth on MacBookPro16,1 Orlando Chamberlain
2021-09-29 5:56 ` Thorsten Leemhuis
2021-09-30 6:32 ` Orlando Chamberlain
2021-09-30 6:51 ` Greg KH
2021-09-30 14:13 ` [PATCH] Bluetooth: add quirk disabling query LE tx power Orlando Chamberlain
2021-09-30 17:03 ` Thorsten Leemhuis
2021-09-30 17:58 ` Marcel Holtmann
2021-10-01 3:37 ` Orlando Chamberlain
2021-10-01 8:36 ` [PATCHv2] Bluetooth: quirk disabling LE Read Transmit Power Orlando Chamberlain
2021-10-01 9:35 ` Marcel Holtmann
2021-10-01 13:28 ` Orlando Chamberlain
2021-10-04 11:15 ` Orlando Chamberlain
2021-11-05 13:39 ` Thorsten Leemhuis
2021-11-05 21:47 ` Luiz Augusto von Dentz
2021-11-06 9:41 ` Aditya Garg
2021-11-06 11:49 ` Greg KH
2021-11-06 17:27 ` Aditya Garg
2021-11-07 8:35 ` Greg KH
2021-11-16 8:18 ` Thorsten Leemhuis
2021-11-16 9:02 ` Orlando Chamberlain
2021-11-16 9:26 ` Thorsten Leemhuis
2021-11-17 3:28 ` Aditya Garg
2021-11-17 7:25 ` Greg KH
2021-11-17 9:26 ` Aditya Garg
2021-11-17 9:42 ` Thorsten Leemhuis
2021-11-17 9:59 ` Aditya Garg [this message]
2021-11-17 12:48 ` Orlando Chamberlain
2021-11-17 19:01 ` Marcel Holtmann
2021-11-19 16:59 ` Aditya Garg
2021-11-25 12:26 ` Thorsten Leemhuis
2021-11-26 15:15 ` Aditya Garg
2021-11-29 7:12 ` Aditya Garg
2021-11-29 7:22 ` [PATCH 1/6] Bluetooth: add " Aditya Garg
2021-11-29 7:27 ` [PATCH 2/6] btbcm: disable read tx power for MacBook Pro 16,1 (16 inch, 2019) Aditya Garg
2021-11-29 7:28 ` [PATCH 3/6] btbcm: disable read tx power for MacBook Pro 16,2 (13 inch - 4 Thunderbolt Ports, 2020) Aditya Garg
2021-11-29 7:30 ` [PATCH 4/6] btbcm: disable read tx power for MacBook Pro 16,4 (16 inch, 2019) Aditya Garg
2021-11-29 7:31 ` [PATCH 5/6] btbcm: disable read tx power for iMac 20,1 (Retina 5K, 27-inch, 2020) Aditya Garg
2021-11-29 7:32 ` [PATCH 6/6] btbcm: disable read tx power for iMac 20,2 " Aditya Garg
2021-11-29 7:46 ` [PATCH v2 4/6] btbcm: disable read tx power for MacBook Pro 16,4 (16 inch, 2019) Aditya Garg
2021-11-29 7:45 ` [PATCH v2 3/6] btbcm: disable read tx power for MacBook Pro 16,2 (13 inch - 4 Thunderbolt Ports, 2020) Aditya Garg
2021-11-29 7:44 ` [PATCH v2 2/6] btbcm: disable read tx power for MacBook Pro 16,1 (16 inch, 2019) Aditya Garg
2021-11-29 8:08 ` [PATCH " Marcel Holtmann
2021-11-29 8:11 ` Aditya Garg
2021-11-29 8:22 ` Marcel Holtmann
2021-11-29 8:42 ` Aditya Garg
2021-11-29 7:32 ` [PATCH 1/6] Bluetooth: add quirk disabling LE Read Transmit Power Greg KH
2021-11-29 7:42 ` [PATCH v2 " Aditya Garg
2021-11-29 7:47 ` Greg KH
2021-11-29 7:49 ` Aditya Garg
2021-11-29 7:47 ` Greg KH
2021-11-29 8:05 ` Marcel Holtmann
2021-11-29 8:32 ` [PATCH v3 1/2] " Aditya Garg
2021-11-29 8:35 ` [PATCH v3 2/2] btbcm: disable read tx power for affected Macs with the T2 Security chip Aditya Garg
2021-11-29 8:50 ` [PATCH v3 resend " Aditya Garg
2021-11-29 9:05 ` [PATCH v4 " Aditya Garg
2021-11-29 9:25 ` [PATCH v5 " Aditya Garg
2021-11-29 11:03 ` [PATCH v3 resend " Marcel Holtmann
2021-11-29 12:01 ` Aditya Garg
2021-11-29 8:47 ` [PATCH v3 resend 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Aditya Garg
2021-11-29 9:03 ` [PATCH v4 " Aditya Garg
2021-11-29 9:24 ` [PATCH v5 " Aditya Garg
2021-11-29 13:59 ` [PATCH v6 " Aditya Garg
2021-11-29 14:00 ` [PATCH v6 2/2] btbcm: disable read tx power for affected Macs with the T2 Security chip Aditya Garg
2021-11-30 8:45 ` Aditya Garg
2021-11-30 8:54 ` Greg KH
2021-11-30 10:28 ` Orlando Chamberlain
2021-11-30 11:38 ` [PATCH v7 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Aditya Garg
2021-11-30 11:40 ` [PATCH v7 2/2] btbcm: disable read tx power for affected Macs with the T2 Security chip Aditya Garg
2021-11-30 11:41 ` [PATCH v7 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Greg KH
2021-11-30 11:50 ` Aditya Garg
2021-11-30 11:48 ` [PATCH v7 resend " Aditya Garg
2021-11-30 11:49 ` [PATCH v7 resend 2/2] btbcm: disable read tx power for affected Macs with the T2 Security chip Aditya Garg
2021-11-30 12:03 ` [PATCH v7 resend 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Greg KH
2021-11-30 12:53 ` Aditya Garg
2021-11-30 12:53 ` [PATCH v8 " Aditya Garg
2021-11-30 12:54 ` [PATCH v8 2/2] btbcm: disable read tx power for affected Macs with the T2 Security chip Aditya Garg
2021-12-01 7:25 ` [PATCH v8 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Marcel Holtmann
2021-12-02 10:15 ` [PATCH v9 " Aditya Garg
2021-12-02 10:16 ` [PATCH v9 2/2] btbcm: disable read tx power for affected Macs with the T2 Security chip Aditya Garg
2021-12-02 12:41 ` [PATCH v10 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Aditya Garg
2021-12-02 12:42 ` [PATCH v10 2/2] btbcm: disable read tx power for some Macs with the T2 Security chip Aditya Garg
2021-12-03 21:28 ` Marcel Holtmann
2021-12-21 13:44 ` Thorsten Leemhuis
2021-12-03 21:28 ` [PATCH v10 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Marcel Holtmann
2021-11-29 8:52 ` [PATCH v3 " Thorsten Leemhuis
2021-11-29 11:02 ` Marcel Holtmann
2021-11-07 3:25 ` [PATCHv2] Bluetooth: " Orlando Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7E546B37-E7DE-454B-8AD2-F54F9C8C690D@live.com \
--to=gargaditya08@live.com \
--cc=danielwinkler@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan.hedberg@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=redecorating@protonmail.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=sonnysasaka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).