From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 058662C82 for ; Wed, 10 Nov 2021 18:01:23 +0000 (UTC) Received: from ip4d173d4a.dynamic.kabel-deutschland.de ([77.23.61.74] helo=[192.168.66.200]); authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1mkruN-0000Aa-4Y; Wed, 10 Nov 2021 19:01:15 +0100 Message-ID: <7e7f180c-6cf6-ba86-e8fd-49b3b291e81e@leemhuis.info> Date: Wed, 10 Nov 2021 19:01:14 +0100 Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Content-Language: en-BW To: Alexei Starovoitov , Lorenz Bauer Cc: Alexei Starovoitov , kernel-team , bpf , regressions@lists.linux.dev, Andrii Nakryiko , Daniel Borkmann References: <20211105194952.xve6u6lgh2oy46dy@ast-mbp.dhcp.thefacebook.com> <20211110042530.6ye65mpspre7au5f@ast-mbp.dhcp.thefacebook.com> <20211110165044.kkjqrjpmnz7hkmq3@ast-mbp.dhcp.thefacebook.com> From: Thorsten Leemhuis Subject: Re: Verifier rejects previously accepted program In-Reply-To: <20211110165044.kkjqrjpmnz7hkmq3@ast-mbp.dhcp.thefacebook.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1636567284;c603b658; X-HE-SMSGID: 1mkruN-0000Aa-4Y On 10.11.21 17:50, Alexei Starovoitov wrote: > On Wed, Nov 10, 2021 at 11:41:09AM +0000, Lorenz Bauer wrote: >> >> uid changes on every invocation, and therefore regsafe() returns false? > > That's correct. > Could you please try the following fix. > I think it's less risky and more accurate than what I've tried before. > >>>From be7736582945b56e88d385ddd4a05e13e4bc6784 Mon Sep 17 00:00:00 2001 > From: Alexei Starovoitov > Date: Wed, 10 Nov 2021 08:47:52 -0800 > Subject: [PATCH] bpf: Fix inner map state pruning regression. > > Fixes: 3e8ce29850f1 ("bpf: Prevent pointer mismatch in bpf_timer_init.") > Signed-off-by: Alexei Starovoitov Thanks for working on a fix for this regression. There is one small detail that afaics could be improved (maybe you left that for later, if that's the case please simply stop reading and ignore this mail): The commit message would benefit from a link to the regression report. This is explained in Documentation/process/submitting-patches.rst, which recently was changed slightly to make this aspect clearer: https://git.kernel.org/linus/1f57bd42b77c E.g. add something like this Link: https://linux-regtracking.leemhuis.info/regzbot/regression/CACAyw99hVEJFoiBH_ZGyy=%2BoO-jyydoz6v1DeKPKs2HVsUH28w@mail.gmail.com/ Thanks in advance. FWIW, in case anyone wonders why I'm asking for this: yes, that link is not really crucial; but it's good to have if someone needs to look into the backstory of this change sometime in the future. But I care for a different reason. I'm tracking this regression (and others) with regzbot, my relative new Linux kernel regression tracking bot. The entry for this regression can be found at: https://linux-regtracking.leemhuis.info/regzbot/regression/CACAyw99hVEJFoiBH_ZGyy=%2BoO-jyydoz6v1DeKPKs2HVsUH28w@mail.gmail.com/ This bot will notice if a patch with a Link: tag to a tracked regression gets posted. It will record that and show a link in the web-interface, which allows anyone looking into a regression to quickly gasp the current status. The bot will also notice if a commit with a Link: tag to a regression report is applied by Linus and then automatically mark the regression as resolved then. IOW: this tag makes my life easier, as I otherwise have to tell regzbot manually about each and every fix for a regression manually. ;-) Ciao, your Linux kernel regression tracker (Thorsten)