From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5709BE4C8 for ; Mon, 20 Mar 2023 09:42:21 +0000 (UTC) Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1peC1x-0001Q1-WE; Mon, 20 Mar 2023 10:42:18 +0100 Message-ID: <84540c66-166e-067a-e1d9-961234640d2e@leemhuis.info> Date: Mon, 20 Mar 2023 10:42:17 +0100 Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] media: i2c: imx290: fix conditional function defintions Content-Language: en-US, de-DE To: Sakari Ailus , Linux regressions mailing list Cc: Manivannan Sadhasivam , Mauro Carvalho Chehab , Alexander Stein , Arnd Bergmann , Dave Stevenson , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Arnd Bergmann References: <20230207161316.293923-1-arnd@kernel.org> From: "Linux regression tracking (Thorsten Leemhuis)" Reply-To: Linux regressions mailing list In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1679305341;242e1ad1; X-HE-SMSGID: 1peC1x-0001Q1-WE On 20.03.23 10:32, Sakari Ailus wrote: > On Mon, Mar 20, 2023 at 10:18:23AM +0100, Linux regression tracking (Thorsten Leemhuis) wrote: >> On 07.02.23 17:40, Laurent Pinchart wrote: >>> On Tue, Feb 07, 2023 at 05:13:12PM +0100, Arnd Bergmann wrote: >>>> From: Arnd Bergmann >>>> >>>> The runtime suspend/resume functions are only referenced from the >>>> dev_pm_ops, but they use the old SET_RUNTIME_PM_OPS() helper >>>> that requires a __maybe_unused annotation to avoid a warning: >>>> >>>> drivers/media/i2c/imx290.c:1082:12: error: unused function 'imx290_runtime_resume' [-Werror,-Wunused-function] >>>> static int imx290_runtime_resume(struct device *dev) >>>> ^ >>>> drivers/media/i2c/imx290.c:1090:12: error: unused function 'imx290_runtime_suspend' [-Werror,-Wunused-function] >>>> static int imx290_runtime_suspend(struct device *dev) >>>> ^ >>>> >> >> I might be missing something (if so, please tell me), but to me it looks >> this fix for a build issue in 6.3-rc (which shows up in Guenters weekly >> reports to Linus) didn't make any progress in the past few weeks. Is >> there a reason why? Who actually needs to pick it up and send it towards >> mainline? Manivannan Sadhasivam? Sakari Ailus? > > Mauro has recently pulled my PR including this and I understand it's in > Mauro's tree now. Ahh, great, many thx. I checked Linux-next before writing my mail, but didn't sport it there. :-/ Ciao, Thorsten