From: Hans de Goede <hdegoede@redhat.com>
To: Linux regressions mailing list <regressions@lists.linux.dev>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Trolli Schmittlauch <t.schmittlauch@orlives.de>,
Mario Limonciello <mario.limonciello@amd.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: 6.8-rc: system freezes after resuming from suspend
Date: Sat, 17 Feb 2024 10:39:14 +0100 [thread overview]
Message-ID: <859c089d-2c3e-4cb9-ad60-baf3e168d6bd@redhat.com> (raw)
In-Reply-To: <687a566b-95cf-4fa6-bc8e-7ef0b0475a3f@leemhuis.info>
Hi,
On 2/17/24 09:13, Linux regression tracking (Thorsten Leemhuis) wrote:
> [/me among others adds Shyam (author of the culprit) and Hans (committed
> it) to the list of recipients]
>
> For the newly joined, this thread starts here:
> https://lore.kernel.org/all/ed2226ff-257b-4cfd-afd6-bf3be9785474@localhost/
Thanks (1)
Trolli, there are 2 PMF fixes pending for 6.8, one of which is
suspend-resume related:
https://patchwork.kernel.org/project/platform-driver-x86/patch/20240216064112.962582-1-Shyam-sundar.S-k@amd.com/
https://patchwork.kernel.org/project/platform-driver-x86/patch/20240216064112.962582-2-Shyam-sundar.S-k@amd.com/
I plan to merge these and send them in their way to Linus next week.
Can you build a 6.8-c4 with those 2 included and see if that fixes things ?
You can download mbox files from patchwork and then do "git am <file>"
to apply them.
Regards,
Hans
1) Note I'm subscribed to the regressions list so I was already following this.
> On 17.02.24 00:26, Trolli Schmittlauch wrote:
>>>> Still, I had the time to bisect the vanilla kernel and landed at
>>>> 7c45534afa4435c9fceeeb8ca33c0fdc269c2240 as the first bad commit.
>
> Reminder, that's 7c45534afa4435 ("platform/x86/amd/pmf: Add support for
> PMF Policy Binary") [v6.8-rc1]
>
>>>> Could be a red herring though[]
>>> If this turns out to be accurate, it's actually quite interesting.
>>> You can prove it's accurate by doing a module blacklist for the
>>> amd-pmf driver (even on 6.8-rc4+).
>>>
>>> If that works, it's a great hint at the problem scope and we need to
>>> pull Shyam into the conversation.
>> I just checked this with Linux version 6.8.0-rc4 (nixbld@localhost) (gcc
>> (GCC) 12.3.0, GNU ld (GNU Binutils) 2.40) #1-NixOS SMP PREEMPT_DYNAMIC
>> Sun Feb 11 20:18:13 UTC 2024.
>>
>> Blacklisting the "amd-pmf" module indeed resolves the issue, good catch.
>> I've attached to s2idle logs of 4 successful cycles without amd-pmf. To
>> be honest, I don't know why the script considers the kernel to be
>> tainted. I have compiled the kernel via the NixOS packaging
>> infrastracture though without checking whether the distro applies any
>> patches, but a guix user had also confirmed the issue in the Framework
>> forum so I guess this issue is vanilla enough.
>>
>> Looking forward to resolving this. I guess for most use cases I can just
>> keep the module blacklisted for now?
>
> Ciao, Thorsten
>
> P.S.: To be sure the issue doesn't fall through the cracks unnoticed,
> I'm adding it to regzbot, the Linux kernel regression tracking bot:
>
> #regzbot introduced 7c45534afa4435 /
> #regzbot title platform/x86/amd/pmf: system freezes after resuming from
> suspend
> #regzbot ignore-activity
>
next prev parent reply other threads:[~2024-02-17 9:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 2:42 6.8-rc: system freezes after resuming from suspend Trolli Schmittlauch
2024-02-16 5:05 ` Linux regression tracking (Thorsten Leemhuis)
2024-02-16 14:19 ` Mario Limonciello
2024-02-16 21:55 ` Trolli Schmittlauch
2024-02-16 23:01 ` Mario Limonciello
2024-02-16 23:26 ` Trolli Schmittlauch
2024-02-17 8:13 ` Linux regression tracking (Thorsten Leemhuis)
2024-02-17 9:39 ` Hans de Goede [this message]
2024-02-17 16:55 ` Mario Limonciello
2024-02-17 16:57 ` Trolli Schmittlauch
2024-02-16 23:13 ` Trolli Schmittlauch
2024-02-17 8:20 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=859c089d-2c3e-4cb9-ad60-baf3e168d6bd@redhat.com \
--to=hdegoede@redhat.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=t.schmittlauch@orlives.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).