From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from so254-9.mailgun.net (so254-9.mailgun.net [198.61.254.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D5FB3FC8 for ; Fri, 24 Sep 2021 09:07:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632474470; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=P3RD3M7+g2Yi/4ZTx3R1aVwoD6LBprfi6LPXWTp3dew=; b=hPYsnVPvzwHoIJrd1iS6CcLVS/WLRTnUXYuhuGy3nu5XAE2kRGb4HamVqKrkzwEljvVAS7IY CqEfC9rTn4D8fzhFgWCUT5r7/thZCR5s85utia9HD9Nr65nxZ5qnzurD4jyQQ+iJH3T7SKIo QSfJMbusTBHj01j1unGlULlOjGc= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0YzJmNCIsICJyZWdyZXNzaW9uc0BsaXN0cy5saW51eC5kZXYiLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 614d956444830700e1b0d781 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 24 Sep 2021 09:07:48 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E535AC43460; Fri, 24 Sep 2021 09:07:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 96D24C4360D; Fri, 24 Sep 2021 09:07:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 96D24C4360D Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Manivannan Sadhasivam Cc: Carl Huang , Loic Poulain , ath11k@lists.infradead.org, linux-arm-msm , linux-wireless@vger.kernel.org, regressions@lists.linux.dev Subject: Re: [regression] mhi: ath11k resume fails on some devices References: <871r5p0x2u.fsf@codeaurora.org> <20210916111218.GA12918@thinkpad> <20210916163529.GA9027@thinkpad> <87k0jgxyjp.fsf@codeaurora.org> <20210916171927.GB9027@thinkpad> <20210923085926.GD6083@thinkpad> Date: Fri, 24 Sep 2021 12:07:41 +0300 In-Reply-To: <20210923085926.GD6083@thinkpad> (Manivannan Sadhasivam's message of "Thu, 23 Sep 2021 14:29:26 +0530") Message-ID: <8735putk82.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Manivannan Sadhasivam writes: > For aid debugging, please see the state the device is in during mhi_pm_resume(). > You can use below diff: > > diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c > index fb99e3727155..482d55dd209e 100644 > --- a/drivers/bus/mhi/core/pm.c > +++ b/drivers/bus/mhi/core/pm.c > @@ -898,6 +898,9 @@ int mhi_pm_resume(struct mhi_controller *mhi_cntrl) > if (MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state)) > return -EIO; > > + dev_info(dev, "Device state: %s\n", > + TO_MHI_STATE_STR(mhi_get_mhi_state(mhi_cntrl))); > + > if (mhi_get_mhi_state(mhi_cntrl) != MHI_STATE_M3) > return -EINVAL; This is what I get with my NUC testbox: [ 970.488202] ACPI: EC: event unblocked [ 970.492484] hpet: Lost 1587 RTC interrupts [ 970.492749] mhi mhi0: Device state: RESET [ 970.492805] ath11k_pci 0000:06:00.0: failed to set mhi state: RESUME(6) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches