From: Takashi Iwai <tiwai@suse.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Takashi Iwai" <tiwai@suse.de>, "Pali Rohár" <pali@kernel.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
regressions@lists.linux.dev, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] wrong coord from Thinkpad TrackPoint since 6.2 kernel
Date: Wed, 29 Mar 2023 11:28:53 +0200 [thread overview]
Message-ID: <874jq3q52i.wl-tiwai@suse.de> (raw)
In-Reply-To: <3dec29bf-b772-d82d-fff9-6c8bcca5f464@redhat.com>
On Wed, 29 Mar 2023 11:22:18 +0200,
Hans de Goede wrote:
>
> Hi Takashi,
>
> On 3/29/23 10:16, Takashi Iwai wrote:
> > Hi,
> >
> > we've received a bug report about Thinkpad TrackPoint (ALPS DualPoint
> > Stick) on 6.2 kernel:
> > https://bugzilla.opensuse.org/show_bug.cgi?id=1209805
> >
> > The device reports the wrong values as the movements, e.g. sometimes a
> > value such as 255, 254 or -255 is returned while usually it should be
> > a smaller value like -1 or 2.
> >
> > The evtest on 6.2.x kernel shows the wrong values like:
> >
> > Event: time 1680037542.898747, type 2 (EV_REL), code 0 (REL_X), value 255
> > Event: time 1680037542.898747, -------------- SYN_REPORT ------------
> > Event: time 1680037543.145196, type 2 (EV_REL), code 0 (REL_X), value 1
> > Event: time 1680037543.145196, -------------- SYN_REPORT ------------
> > Event: time 1680037543.175087, type 2 (EV_REL), code 1 (REL_Y), value -255
> > Event: time 1680037543.175087, -------------- SYN_REPORT ------------
> > Event: time 1680037543.185421, type 2 (EV_REL), code 0 (REL_X), value 1
> > Event: time 1680037543.185421, type 2 (EV_REL), code 1 (REL_Y), value -255
> > Event: time 1680037543.185421, -------------- SYN_REPORT ------------
> >
> > while 6.1.x kernel shows the correct values like:
> >
> > Event: time 1680037386.318058, type 2 (EV_REL), code 0 (REL_X), value -1
> > Event: time 1680037386.318058, type 2 (EV_REL), code 1 (REL_Y), value -1
> > Event: time 1680037386.318058, -------------- SYN_REPORT ------------
> > Event: time 1680037386.328087, type 2 (EV_REL), code 0 (REL_X), value -1
> > Event: time 1680037386.328087, type 2 (EV_REL), code 1 (REL_Y), value -1
> > Event: time 1680037386.328087, -------------- SYN_REPORT ------------
> > Event: time 1680037386.338046, type 2 (EV_REL), code 0 (REL_X), value -1
> > Event: time 1680037386.338046, type 2 (EV_REL), code 1 (REL_Y), value -2
> > Event: time 1680037386.338046, -------------- SYN_REPORT ------------
> >
> > I couldn't see any relevant changes in alps.c between those versions,
> > so this is likely a breakage in a lower layer.
> >
> > Could you guys take a look?
>
> I believe this is caused by the kernel now using -funsigned-char
> everywhere and this should be fixed by this commit:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/commit/?h=for-linus&id=754ff5060daf5a1cf4474eff9b4edeb6c17ef7ab
Ah, that makes sense!
I'll build a test kernel with this fix and ask the reporter for
testing.
> And there is a similar issue in the focaltech touchpad driver:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/commit/?h=for-linus&id=8980f190947ba29f23110408e712444884b74251
>
> Dmitry, since this is hitting 6.2 users, perhaps you can send
> a pull-req for your current for-linus branch to get the fix
> on its way to stable ?
That'll be great.
Thanks!
Takashi
next prev parent reply other threads:[~2023-03-29 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 8:16 [REGRESSION] wrong coord from Thinkpad TrackPoint since 6.2 kernel Takashi Iwai
2023-03-29 9:22 ` Hans de Goede
2023-03-29 9:28 ` Takashi Iwai [this message]
2023-03-30 8:23 ` Takashi Iwai
2023-04-01 21:17 ` Dmitry Torokhov
2023-03-31 13:38 ` Linux regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jq3q52i.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).