regressions.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Exuvo <exuvo@exuvo.se>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
	 linux-wireless@vger.kernel.org,
	 Helmut Schaa <helmut.schaa@googlemail.com>,
	regressions@lists.linux.dev
Subject: Re: rt2x00 regression
Date: Fri, 01 Oct 2021 09:56:32 +0300	[thread overview]
Message-ID: <87czop5j33.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <f935dc15-08bd-2e28-fc1b-b27634c618be@exuvo.se> (Exuvo's message of "Wed, 29 Sep 2021 10:22:50 +0200")

(adding regressions list for easier tracking)

Exuvo <exuvo@exuvo.se> writes:

> I would like to get this resolved, is there any more information you need from me?
>
> I have been manually patching this all year with:
>
> drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
> - if (rt2x00dev->num_proto_errs > 8)
> -    return true;
>
> It seems to just be some part of rt2800_load_firmware that is not
> supported on my device and generating errors but it has been running
> without problems in AP mode with daily usage.

[...]

>>>>>>> This most likely is the problem introduced by commit:
>>>>>>>
>>>>>>> commit e383c70474db32b9d4a3de6dfbd08784d19e6751
>>>>>>> Author: Stanislaw Gruszka <sgruszka@redhat.com>
>>>>>>> Date:   Tue Mar 12 10:51:42 2019 +0100
>>>>>>>
>>>>>>>      rt2x00: check number of EPROTO errors
>>>>>>>
>>>>>>> Plase check below patch that increase number of EPROTO checks
>>>>>>> before marking device removed. If it does not help, plese
>>>>>>> check if reverting above commits helps.

Should we do a revert? Can someone submit that including an explanation
of the regression.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

       reply	other threads:[~2021-10-01  6:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bff7d309-a816-6a75-51b6-5928ef4f7a8c@exuvo.se>
     [not found] ` <20190927080303.GA7667@redhat.com>
     [not found]   ` <CA+GwT0B5SyRZnGLqwqOeuJK4CWMVc=dKaWre9VN8KQC6kBzKGw@mail.gmail.com>
     [not found]     ` <20191203075736.GA701@redhat.com>
     [not found]       ` <d74dab51-3a84-9035-d89e-ea8f63e89198@exuvo.se>
     [not found]         ` <a8eeb0bc-95da-291a-7fb9-5d15d1174c27@exuvo.se>
     [not found]           ` <c22673af-40e0-3af2-5ab7-69b23fc03598@exuvo.se>
     [not found]             ` <f935dc15-08bd-2e28-fc1b-b27634c618be@exuvo.se>
2021-10-01  6:56               ` Kalle Valo [this message]
2021-10-01  8:24                 ` rt2x00 regression Thorsten Leemhuis
2021-11-30  9:16                   ` rt2x00 regression #forregzbot Thorsten Leemhuis
2021-11-05 13:25                 ` rt2x00 regression Thorsten Leemhuis
2021-11-08 18:00                   ` Thorsten Leemhuis
     [not found]                     ` <20211109073127.ga109212@wp.pl>
2021-11-09  7:31                     ` Stanislaw Gruszka
2021-11-09 12:07                       ` Stanislaw Gruszka
2021-11-09 15:22                         ` Exuvo
     [not found]                           ` <cc85b4e8a038417b865069c6578acf50@grupawp.pl>
2021-11-10  6:59                             ` Kalle Valo
2021-11-10  8:01                               ` Stanislaw Gruszka
2021-11-11 10:54                                 ` Exuvo
2021-11-11 14:10                                   ` [PATCH] rt2x00: do not mark device gone on EPROTO errors during start Stanislaw Gruszka
2021-11-18  6:16                                     ` Thorsten Leemhuis
2021-11-19 14:19                                       ` Kalle Valo
2021-11-29 10:54                                     ` Kalle Valo
     [not found] <ca+gwt0b5syrznglqwqoeujk4cwmvc=dkawre9vn8kqc6kbzkgw@mail.gmail.com>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czop5j33.fsf@tynnyri.adurom.net \
    --to=kvalo@codeaurora.org \
    --cc=exuvo@exuvo.se \
    --cc=helmut.schaa@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).