From: Vinicius Costa Gomes <vinicius.gomes@intel.com> To: Stefan Dietrich <roots@gmx.de>, Thorsten Leemhuis <regressions@leemhuis.info> Cc: kuba@kernel.org, greg@kroah.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, regressions@lists.linux.dev Subject: Re: [PATCH] igc: Avoid possible deadlock during suspend/resume Date: Fri, 10 Dec 2021 16:41:32 -0800 [thread overview] Message-ID: <87h7bgrn0j.fsf@intel.com> (raw) In-Reply-To: <d4c9bb101aa79c5acaaa6dd7b42159fb0c91a341.camel@gmx.de> [-- Attachment #1: Type: text/plain, Size: 888 bytes --] Hi Stefan, Stefan Dietrich <roots@gmx.de> writes: > Agreed and thanks for the pointers; please see the log files and > .config attached as requested. > Thanks for the logs. Very interesting that the initialization of the device is fine, so it's something that happens later. Can you test the attached patch? If the patch works, I would also be interested if you notice any loss of functionality with your NIC. (I wouldn't think so, as far as I know, i225-V models have PTM support but don't have any PTP support). > > Cheers, > Stefan > > > On Fri, 2021-12-10 at 15:01 +0100, Thorsten Leemhuis wrote: >> On 10.12.21 14:45, Stefan Dietrich wrote: >> > thanks for keeping an eye on the issue. I've sent the files in >> > private >> > because I did not want to spam the mailing lists with them. Please >> > let >> > me know if this is the correct procedure. >> Cheers, -- Vinicius [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: test patch for deadlock in igc --] [-- Type: text/x-patch, Size: 1163 bytes --] From bc78a215cd3a68375ec62a05080070876e31d733 Mon Sep 17 00:00:00 2001 From: Vinicius Costa Gomes <vinicius.gomes@intel.com> Date: Fri, 10 Dec 2021 16:23:42 -0800 Subject: [TEST ONLY] igc: Do not enable crosstimestamping for i225-V models WIP WIP WIP Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> --- drivers/net/ethernet/intel/igc/igc_ptp.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c index 30568e3544cd..b525035a8a2b 100644 --- a/drivers/net/ethernet/intel/igc/igc_ptp.c +++ b/drivers/net/ethernet/intel/igc/igc_ptp.c @@ -768,7 +768,13 @@ int igc_ptp_get_ts_config(struct net_device *netdev, struct ifreq *ifr) */ static bool igc_is_crosststamp_supported(struct igc_adapter *adapter) { - return IS_ENABLED(CONFIG_X86_TSC) ? pcie_ptm_enabled(adapter->pdev) : false; + if (!IS_ENABLED(CONFIG_X86_TSC)) + return false; + + if (adapter->pdev->device == IGC_DEV_ID_I225_V) + return false; + + return pcie_ptm_enabled(adapter->pdev); } static struct system_counterval_t igc_device_tstamp_to_system(u64 tstamp) -- 2.33.1
next prev parent reply other threads:[~2021-12-11 0:41 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-24 7:28 [REGRESSION] Kernel 5.15 reboots / freezes upon ifup/ifdown Stefan Dietrich 2021-11-24 7:33 ` Greg KH 2021-11-24 7:42 ` Stefan Dietrich 2021-11-24 17:20 ` Stefan Dietrich 2021-11-24 23:34 ` Jakub Kicinski 2021-11-25 1:07 ` Vinicius Costa Gomes 2021-11-25 1:13 ` Jakub Kicinski 2021-11-25 8:41 ` Stefan Dietrich 2021-12-01 11:45 ` Thorsten Leemhuis 2021-12-01 17:47 ` Vinicius Costa Gomes 2021-12-01 18:57 ` [PATCH] igc: Avoid possible deadlock during suspend/resume Vinicius Costa Gomes 2021-12-02 6:41 ` Greg KH 2021-12-02 6:50 ` Vinicius Costa Gomes 2021-12-02 8:34 ` Stefan Dietrich 2021-12-02 22:34 ` Vinicius Costa Gomes 2021-12-10 9:40 ` Thorsten Leemhuis 2021-12-10 13:45 ` Stefan Dietrich 2021-12-10 14:01 ` Thorsten Leemhuis 2021-12-10 14:51 ` Stefan Dietrich 2021-12-11 0:41 ` Vinicius Costa Gomes [this message] 2021-12-11 9:50 ` Stefan Dietrich 2021-12-13 18:32 ` Vinicius Costa Gomes 2021-12-14 6:39 ` Stefan Dietrich 2021-11-24 7:48 ` [REGRESSION] Kernel 5.15 reboots / freezes upon ifup/ifdown Thorsten Leemhuis 2021-11-25 11:15 ` Thorsten Leemhuis 2021-11-24 8:05 ` Stefan Dietrich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87h7bgrn0j.fsf@intel.com \ --to=vinicius.gomes@intel.com \ --cc=greg@kroah.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=kuba@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=regressions@leemhuis.info \ --cc=regressions@lists.linux.dev \ --cc=roots@gmx.de \ --subject='Re: [PATCH] igc: Avoid possible deadlock during suspend/resume' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).