From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2239B2F34 for ; Thu, 17 Mar 2022 08:48:44 +0000 (UTC) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id D0D0222205; Thu, 17 Mar 2022 09:48:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1647506915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4a3Y2KbnQUavIG9wl141tJRVHNXn1CwqBXUisBhaUd4=; b=NZ9t78xnhuHUDDjP/0YFzN3J6vMiQe0j3kwSsCbKIbcZz+Fprpc0+HEHh8vMORaKPGKk++ 9meCilS92zd6+m1L4z6nTn3dhfRMW98yBBlSgVPNtw1JFfHnRFV6f2dteqiWXm2z0R9D6Z cFvgNtnxbY4bMJKb4DC+RnPdDo5KDVs= Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 17 Mar 2022 09:48:28 +0100 From: Michael Walle To: Andy Shevchenko Cc: Bartosz Golaszewski , Saravana Kannan , Marcelo Roberto Jimenez , Andrew Chant , Edmond Chung , Geert Uytterhoeven , Linus Walleij , "open list:GPIO SUBSYSTEM" , regressions@lists.linux.dev, Stephen Rothwell , stable , Sergio Tanzilli , Thierry Reding , Vidya Sagar , Will McVicker , Horatiu Vultur , Lars Povlsen Subject: Re: [PATCH] gpio: Revert regression in sysfs-gpio (gpiolib.c) In-Reply-To: References: <20211217153555.9413-1-marcelo.jimenez@gmail.com> <20220314155509.552218-1-michael@walle.cc> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <8a1a46f1e5b822fd49f56f2fe50c5396@walle.cc> X-Sender: michael@walle.cc Am 2022-03-17 09:37, schrieb Andy Shevchenko: > On Thu, Mar 17, 2022 at 7:36 AM Michael Walle wrote: >> Am 2022-03-15 16:32, schrieb Bartosz Golaszewski: >> > On Mon, Mar 14, 2022 at 4:55 PM Michael Walle wrote: > > ... > >> I started to try this out, but then I was wondering if there weren't >> other gpio/pinctrl drivers with the same problem. And judging by the >> reports [1], I'd say there are. Then I wasn't sure if this is actually >> the correct fix here - or if that old workaround [2] doesn't work >> anymore because it might have that empty ranges "feature". >> >> To answer your question: I don't know. But I don't know if that is >> actually the correct way of fixing this either. >> >> >> Also, I'm not sure if there are any other other driver which get >> >> broken by this. I.e. ones falling into the gpio_stub_drv category. > > I know that OF is a mess, but I want to understand why in ACPI we > haven't experienced such an issue. Any pointers would be appreciated. During debugging I've seen that the pinctrl-microchip-sgpio will report itself as gpio_stub_drv. You'll find that this driver was added by the following commit: commit 4731210c09f5977300f439b6c56ba220c65b2348 Author: Saravana Kannan Date: Fri Jan 22 11:35:59 2021 -0800 gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default The microchip driver has actually a binding which was described in that commit message. Thus I concluded, that it makes sense this driver falls into that workaround. That is where I stopped and wrote this mail. Actually, I haven't found out yet where that fallback to gpio_stub_drv is happening. -michael