From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 350A1807 for ; Mon, 27 Mar 2023 08:23:44 +0000 (UTC) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 06C9B6602087; Mon, 27 Mar 2023 09:23:41 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1679905422; bh=oMn8QjU8/8qTC6gWtoCH/9yMmplAzpyb0h0XKNTrk2M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=K5rfnodqvGxAWMjY8/S9KVsuWfTQAHGs0WoqV63XOC8E/2QNVMAjJ4HsHfyaYBd4K NKM2Xx2ObslQWygUvE3BLWJd30UvgTJxNEbZFuXdDpXqCAd8qFXlVuwbglZlrksm07 9+7WYqd7QSu70VQOgHEPP6SnXIU2EiU1dDYZYWS6Dx/PoKDJsvSTYKcoCE8ZF1SooG djKOXCAd+t4coqU5dwMtmxzLPTENlBE9Twc2G5zHLUVxaX4+TuhW4yzpLAzkOVC3EZ R9r2AwlBGpPEzcRc7vT7jcy92j4Wr31u6uHoDydgtE7DbHU9XkN2iR25rowkP8fZ/X sqbZDbtqKlyZQ== Message-ID: <8b07ead5-f105-da86-e7da-ee49616f7c1d@collabora.com> Date: Mon, 27 Mar 2023 10:23:39 +0200 Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: kernel error at led trigger "phy0tpt" Content-Language: en-US To: Bagas Sanjaya , Tobias Dahms , Sean Wang Cc: stable@vger.kernel.org, Pavel Machek , Lee Jones , LKML , linux-leds@vger.kernel.org, linux-wireless@vger.kernel.org, Linux regressions mailing list References: <91feceb2-0df4-19b9-5ffa-d37e3d344fdf@web.de> <3fcc707b-f757-e74b-2800-3b6314217868@leemhuis.info> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 26/03/23 15:23, Bagas Sanjaya ha scritto: > On 3/26/23 02:20, Tobias Dahms wrote: >> Hello, >> >> the bisection gives following result: >> -------------------------------------------------------------------- >> 18c7deca2b812537aa4d928900e208710f1300aa is the first bad commit >> commit 18c7deca2b812537aa4d928900e208710f1300aa >> Author: AngeloGioacchino Del Regno >> Date:   Tue May 17 12:47:08 2022 +0200 >> >>     soc: mediatek: pwrap: Use readx_poll_timeout() instead of custom >> function >> >>     Function pwrap_wait_for_state() is a function that polls an address >>     through a helper function, but this is the very same operation that >>     the readx_poll_timeout macro means to do. >>     Convert all instances of calling pwrap_wait_for_state() to instead >>     use the read_poll_timeout macro. >> >>     Signed-off-by: AngeloGioacchino Del Regno >> >>     Reviewed-by: Nícolas F. R. A. Prado >>     Tested-by: Nícolas F. R. A. Prado >>     Link: >> https://lore.kernel.org/r/20220517104712.24579-2-angelogioacchino.delregno@collabora.com >>     Signed-off-by: Matthias Brugger >> >>  drivers/soc/mediatek/mtk-pmic-wrap.c | 60 >> ++++++++++++++++++++---------------- >>  1 file changed, 33 insertions(+), 27 deletions(-) >> -------------------------------------------------------------------- >> > > OK, I'm updating the regression status: > > #regzbot introduced: 18c7deca2b8125 > > And for replying, don't top-post, but rather reply inline with > appropriate context instead; hence I cut the replied context. > There are two possible solutions to that, specifically, either: 1. Change readx_poll_timeout() to readx_poll_timeout_atomic(); or 2. Fix the mt6323-led driver so that this operation gets done out of atomic context, which is IMO the option to prefer. Ideas? Regards, Angelo