regressions.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Naresh Kamboju <naresh.kamboju@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	lkft-triage@lists.linaro.org,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 Linux-OMAP <linux-omap@vger.kernel.org>,
	regressions@lists.linux.dev,
	 Benoit Cousson <bcousson@baylibre.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	 Rob Herring <robh+dt@kernel.org>
Subject: Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")
Date: Thu, 6 May 2021 20:48:46 +0530	[thread overview]
Message-ID: <CA+G9fYv48aJ6tmSaf_HtRKHse4yN40hEYSPR5=A3W6HRoJ8p_g@mail.gmail.com> (raw)
In-Reply-To: <YJPYvsdkfx4JD4vT@atomide.com>

On Thu, 6 May 2021 at 17:23, Tony Lindgren <tony@atomide.com> wrote:
>
> Hi,
>
> * Naresh Kamboju <naresh.kamboju@linaro.org> [210506 11:00]:
> > Our bisect script pointed this as the first bad commit on linux
> > mainline master branch.
> >
> > Full test log:
> > ----------------
> > SATA detection failed log link,
> > https://lkft.validation.linaro.org/scheduler/job/2580998#L1973
> >
> > --
> > commit 98feab31ac491400f28b76a04dabd18ce21e91ba
> > Author: Tony Lindgren <tony@atomide.com>
> > Date:   Wed Mar 10 14:03:51 2021 +0200
> >
> >     ARM: OMAP2+: Drop legacy platform data for dra7 sata
>
> Thanks for the report, looks like we are now missing the sata related
> quirk flags compared to the patch above.
>
> Below is a quick patch to add the missing quirk flags that might help
> if you can give it a try.

The reported problem was solved by this patch. Thank you.
Please add reported and tested by tags.

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org>

>
> Regards,
>
> Tony
>
> 8< --------------------------
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -1459,6 +1459,8 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
>                    SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
>         SYSC_QUIRK("tptc", 0, 0, -ENODEV, -ENODEV, 0x40007c00, 0xffffffff,
>                    SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
> +       SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff,
> +                  SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
>         SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, 0x14, 0x50700100, 0xffffffff,
>                    SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
>         SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, -ENODEV, 0x50700101, 0xffffffff,
> @@ -1524,7 +1526,6 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
>         SYSC_QUIRK("prcm", 0, 0, -ENODEV, -ENODEV, 0x40000400, 0xffffffff, 0),
>         SYSC_QUIRK("rfbi", 0x4832a800, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0),
>         SYSC_QUIRK("rfbi", 0x58002000, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0),
> -       SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff, 0),
>         SYSC_QUIRK("scm", 0, 0, 0x10, -ENODEV, 0x40000900, 0xffffffff, 0),
>         SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4e8b0100, 0xffffffff, 0),
>         SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4f000100, 0xffffffff, 0),
> --
> 2.31.1


Tested full log,
https://lkft.validation.linaro.org/scheduler/job/2641881#L1940

- Naresh

  reply	other threads:[~2021-05-06 15:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 11:00 #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata") Naresh Kamboju
2021-05-06 11:53 ` Tony Lindgren
2021-05-06 15:18   ` Naresh Kamboju [this message]
2021-05-07  8:02     ` Tony Lindgren
2021-05-07  8:27       ` Thorsten Leemhuis
2021-05-07  9:23         ` Tony Lindgren
2021-05-07  9:27         ` Naresh Kamboju
2021-05-07  9:35         ` Tony Lindgren
2021-05-07  9:39           ` Thorsten Leemhuis
2021-05-07  9:40             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+G9fYv48aJ6tmSaf_HtRKHse4yN40hEYSPR5=A3W6HRoJ8p_g@mail.gmail.com' \
    --to=naresh.kamboju@linaro.org \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=regressions@lists.linux.dev \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).