From: Lorenz Bauer <lmb@cloudflare.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
kernel-team <kernel-team@cloudflare.com>,
bpf <bpf@vger.kernel.org>,
regressions@lists.linux.dev, Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: Verifier rejects previously accepted program
Date: Wed, 10 Nov 2021 17:05:26 +0000 [thread overview]
Message-ID: <CACAyw98qviPmc1rWCkm8WXDwFN-JLKzXeUTAz27OVLK_9B7DQA@mail.gmail.com> (raw)
In-Reply-To: <20211110165044.kkjqrjpmnz7hkmq3@ast-mbp.dhcp.thefacebook.com>
On Wed, 10 Nov 2021 at 16:50, Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Wed, Nov 10, 2021 at 11:41:09AM +0000, Lorenz Bauer wrote:
> >
> > uid changes on every invocation, and therefore regsafe() returns false?
>
> That's correct.
> Could you please try the following fix.
> I think it's less risky and more accurate than what I've tried before.
It works!
processed 295498 insns (limit 1000000) max_states_per_insn 29
total_states 14527 peak_states 1322 mark_read 53
Thanks for looking into this without a reproducer!
Lorenz
--
Lorenz Bauer | Systems Engineer
6th Floor, County Hall/The Riverside Building, SE1 7PB, UK
www.cloudflare.com
next prev parent reply other threads:[~2021-11-10 17:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 11:55 Verifier rejects previously accepted program Lorenz Bauer
2021-11-04 16:50 ` Alexei Starovoitov
2021-11-04 23:30 ` sdf
2021-11-05 1:20 ` Alexei Starovoitov
2021-11-05 4:13 ` Stanislav Fomichev
2021-11-05 10:41 ` Lorenz Bauer
2021-11-05 19:49 ` Alexei Starovoitov
2021-11-08 13:21 ` Lorenz Bauer
2021-11-10 4:25 ` Alexei Starovoitov
2021-11-10 11:41 ` Lorenz Bauer
2021-11-10 16:50 ` Alexei Starovoitov
2021-11-10 17:05 ` Lorenz Bauer [this message]
2021-11-10 18:01 ` Thorsten Leemhuis
2021-11-10 19:16 ` Alexei Starovoitov
2021-11-10 19:49 ` Thorsten Leemhuis
2021-11-16 9:26 ` Lorenz Bauer
2021-11-16 10:59 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACAyw98qviPmc1rWCkm8WXDwFN-JLKzXeUTAz27OVLK_9B7DQA@mail.gmail.com \
--to=lmb@cloudflare.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@cloudflare.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).