regressions.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: Felix Richter <judge@felixrichter.tech>
Cc: "Mahfooz, Hamza" <Hamza.Mahfooz@amd.com>,
	 Linux regressions mailing list <regressions@lists.linux.dev>,
	amd-gfx@lists.freedesktop.org,  dri-devel@lists.freedesktop.org
Subject: Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue
Date: Wed, 7 Jun 2023 14:05:42 -0400	[thread overview]
Message-ID: <CADnq5_Ojz=dTO-ve0KxrLb+v0OouwbQdGTn4Fm8vwEjR2Ww-gw@mail.gmail.com> (raw)
In-Reply-To: <076f493a-9e88-db37-f4a0-2a269e94d51e@felixrichter.tech>

[-- Attachment #1: Type: text/plain, Size: 6391 bytes --]

On Wed, Jun 7, 2023 at 4:42 AM Felix Richter <judge@felixrichter.tech> wrote:
>
> Hi Guys,
>
> so I checked, the kernel I am running has this commit
> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> /commit/?id=08da182175db4c7f80850354849d95f2670e8cd9) applied already!
>
> https://github.com/ju6ge/linux/commit/917680e6056aa288cac288d3afd2745d372beb61u
>
> And the bug of display flickering persists with or without the
> amdgpu.sg_display=0 variable applied!

That is unexpected.  Setting sg_display=0 should be equivalent to
reverting 81d0bcf9900932633d270d5bc4a54ff599c6ebdb.  Does the attached
patch (with sg_display=0 set) make any difference?

Alex


>
> Kind regards,
> Felix Richter
>
>
> On 6/5/23 16:11, Alex Deucher wrote:
> > + Hamza
> > This is a known issue.  You can workaround it by setting
> > amdgpu.sg_display=0.  It should be issue should be fixed in:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=08da182175db4c7f80850354849d95f2670e8cd9
> >
> > Alex
> >
> >
> >
> >> Now if this is the desired long term fix I do not know …
> >>
> >> Kind regards,
> >> Felix Richter
> >>
> >> On 02.05.23 16:12, Linux regression tracking (Thorsten Leemhuis) wrote:
> >>> On 02.05.23 15:48, Felix Richter wrote:
> >>>> On 5/2/23 15:34, Linux regression tracking (Thorsten Leemhuis) wrote:
> >>>>> On 02.05.23 15:13, Alex Deucher wrote:
> >>>>>> On Tue, May 2, 2023 at 7:45 AM Linux regression tracking (Thorsten
> >>>>>> Leemhuis)<regressions@leemhuis.info>  wrote:
> >>>>>>
> >>>>>>> On 30.04.23 13:44, Felix Richter wrote:
> >>>>>>>> Hi,
> >>>>>>>>
> >>>>>>>> I am running into an issue with the integrated GPU of the Ryzen 9
> >>>>>>>> 7950X. It seems to be a regression from kernel version 6.1 to 6.2.
> >>>>>>>> The bug materializes in from of my monitor blinking, meaning it
> >>>>>>>> turns full white shortly. This happens very often so that the
> >>>>>>>> system becomes unpleasant to use.
> >>>>>>>>
> >>>>>>>> I am running the Archlinux Kernel:
> >>>>>>>> The Issue happens on the bleeding edge kernel: 6.2.13
> >>>>>>>> Switching back to the LTS kernel resolves the issue: 6.1.26
> >>>>>>>>
> >>>>>>>> I have two monitors attached to the system. One 42 inch 4k Display
> >>>>>>>> and a 24 inch 1080p Display and am running sway as my desktop.
> >>>>>>>>
> >>>>>>>> Let me know if there is more information I could provide to help
> >>>>>>>> narrow down the issue.
> >>>>>>> Thanks for the report. To be sure the issue doesn't fall through the
> >>>>>>> cracks unnoticed, I'm adding it to regzbot, the Linux kernel regression
> >>>>>>> tracking bot:
> >>>>>>>
> >>>>>>> #regzbot ^introduced v6.1..v6.2
> >>>>>>> #regzbot title drm: amdgpu: system becomes unpleasant to use after
> >>>>>>> monitor starts blinking and turns full white
> >>>>>>> #regzbot ignore-activity
> >>>>>>>
> >>>>>>> This isn't a regression? This issue or a fix for it are already
> >>>>>>> discussed somewhere else? It was fixed already? You want to clarify
> >>>>>>> when
> >>>>>>> the regression started to happen? Or point out I got the title or
> >>>>>>> something else totally wrong? Then just reply and tell me -- ideally
> >>>>>>> while also telling regzbot about it, as explained by the page listed in
> >>>>>>> the footer of this mail.
> >>>>>>>
> >>>>>>> Developers: When fixing the issue, remember to add 'Link:' tags
> >>>>>>> pointing
> >>>>>>> to the report (the parent of this mail). See page linked in footer for
> >>>>>>> details.
> >>>>>> This sounds exactly like the issue that was fixed in this patch which
> >>>>>> is already on it's way to Linus:
> >>>>>> https://gitlab.freedesktop.org/agd5f/linux/-/commit/08da182175db4c7f80850354849d95f2670e8cd9
> >>>>> FWIW, you in the flood of emails likely missed that this is the same
> >>>>> thread where you yesterday replied "If the module parameter didn't help
> >>>>> then perhaps you are seeing some other issue.  Can you bisect?". That's
> >>>>> why I decided to add this to the tracking. Or am I missing something
> >>>>> obvious here?
> >>>>>
> >>>>> /me looks around again and can't see anything, but that doesn't have to
> >>>>> mean anything...
> >>>>>
> >>>>> Felix, btw, this guide might help you with the bisection, even if it's
> >>>>> just for kernel compilation:
> >>>>>
> >>>>> https://docs.kernel.org/next/admin-guide/quickly-build-trimmed-linux.html
> >>>>>
> >>>>> And to indirectly reply to your mail from yesterday[1]. You might want
> >>>>> to ignore the arch linux kernel git repo and just do a bisection between
> >>>>> 6.1 and the latest 6.2.y kernel using upstream repos; and if I were you
> >>>>> I'd also try 6.3 or even mainline before that, in case the issue was
> >>>>> fixed already.
> >>>>>
> >>>>> [1]
> >>>>> https://lore.kernel.org/all/04749ee4-0728-92fe-bcb0-a7320279eaac@felixrichter.tech/
> >>>>>
> >>>> Thanks for the pointers, I'll do a bisection on my desktop from 6.1 to
> >>>> the newest commit.
> >>> FWIW, I wonder what you actually mean with "newest commit" here: a
> >>> bisection between 6.1 and mainline HEAD might be a waste of time, *if*
> >>> this is something that only happens in 6.2.y (say due to a broken or
> >>> incomplete backport)
> >>>
> >>>> That was the part I was mostly unsure about … where
> >>>> to start from.
> >>>>
> >>>> I was planning to use PKGBUILD scripts from arch to achieve the same
> >>>> configuration as I would when installing
> >>>> the package and just rewrite the script to use a local copy of the
> >>>> source code instead of the repository.
> >>>> That way I can just use the bisect command, rebuild the package and test
> >>>> again.
> >>> In my experience trying to deal with Linux distro's package managers
> >>> creates more trouble than it's worth.
> >>>
> >>>> But I probably won't be able to finish it this week, since I am on
> >>>> vacation starting tomorrow and will not have access to the computer in
> >>>> question. I will be back next week, by that time the patch Alex is
> >>>> talking about might
> >>>> already be in mainline. So if that fixes it, I will notice and let you
> >>>> know. If not I will do the bisection to figure out what the actual issue
> >>>> is.
> >>> Enjoy your vacation!
> >>>
> >>> Ciao, Thorsten
>

[-- Attachment #2: sg_display_test.diff --]
[-- Type: text/x-patch, Size: 633 bytes --]

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index cc65c334cb64..195b4ff7a287 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -1631,10 +1631,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 		break;
 	}
 	if (init_data.flags.gpu_vm_support &&
-	    (amdgpu_sg_display == 0))
-		init_data.flags.gpu_vm_support = false;
-
-	if (init_data.flags.gpu_vm_support)
+	    (amdgpu_sg_display != 0))
 		adev->mode_info.gpu_vm_support = true;
 
 	if (amdgpu_dc_feature_mask & DC_FBC_MASK)

  reply	other threads:[~2023-06-07 18:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <46a7eb80-5f09-4f6a-4fd3-9550dafd497c@felixrichter.tech>
2023-05-02 11:44 ` PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue Linux regression tracking (Thorsten Leemhuis)
2023-05-02 13:13   ` Alex Deucher
2023-05-02 13:34     ` Linux regression tracking (Thorsten Leemhuis)
2023-05-02 13:39       ` Alex Deucher
2023-05-02 13:48       ` Felix Richter
2023-05-02 14:12         ` Linux regression tracking (Thorsten Leemhuis)
2023-06-03 14:52           ` Felix Richter
2023-06-05 14:11             ` Alex Deucher
2023-06-05 19:01               ` Felix Richter
2023-06-07  8:42               ` Felix Richter
2023-06-07 18:05                 ` Alex Deucher [this message]
2023-06-05 15:27             ` Hamza Mahfooz
2023-06-05 18:55               ` Felix Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADnq5_Ojz=dTO-ve0KxrLb+v0OouwbQdGTn4Fm8vwEjR2Ww-gw@mail.gmail.com' \
    --to=alexdeucher@gmail.com \
    --cc=Hamza.Mahfooz@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=judge@felixrichter.tech \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).