From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7414356B87 for ; Mon, 1 Apr 2024 23:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712013931; cv=none; b=olPY6JjD5fciVLe4EiOhr6SHPtGjXbRg4As76UBE0fLq088ylzB9KdjUXo6jFhfmZX6o8sZ/BiPTmKewaqAWVWyxUrHA2658AP0iPCmq7uHOWePQtkmpeiYosP05jFguj0Y53jgNjxBdEElLBLaM0P8gZJZqHveoh9G7pm3WZVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712013931; c=relaxed/simple; bh=7O6ujO5rc0L0/KR/mKMdDyxpsqTMox7YCAlN6/iMYXE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=ptt2ehb5dP5KCCQ45PBLKjUHq1nMhv6Xp8pelsHT3T3uz+couwuGrEruFjRahqR/zElN3ufA3H0G3eHe7fizgGDsTSEJpzBA7TIoiZA427hYKZcqpDs7LeD442EWybYrAym/rpJSeLSNsZTbekv3sv14zUpNvJ6myhj1XwqwPUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dNwGuKfM; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dNwGuKfM" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-432d55b0fa9so674331cf.1 for ; Mon, 01 Apr 2024 16:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712013928; x=1712618728; darn=lists.linux.dev; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RBFnvPatyDI2+u+ojuWnolOosfbwXQU3OHbOSZ7OXrI=; b=dNwGuKfMPe6iMw9E6xPtXPphO5UNVH9YpnqW8yn4loKnQsZhE4dOPFNALV/8JVRuxK As9p2KcKDmX/GOPbdxwiU9Bnumegk3oIJSNHPIiROxriqcZHMNftzMfQgIIsXXK1EV7K MrZVMVWHZVUcOx+yO5ZvWUEEtS1RA4x5vj6aTg+cmcU1dG2q8Xp7ex7tCia7NLEMmX4t /Um/NOAQDgxPykNZfJXUewXdEUs43yHQtJUE9X3xDTPxCXg9aJ8DrEOIykWCqScCLtEh wt2CDSZ5J6Y4UQrD7PTrSZtjtp1RLV0iG/YT4oVniJLfPvIU/AEQxPpAdTF08XO70+FO /zkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712013928; x=1712618728; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RBFnvPatyDI2+u+ojuWnolOosfbwXQU3OHbOSZ7OXrI=; b=vtAZ8YmRZdeCthnZntW6JWQwX2mnSFOoKsZGIHZ5eUJ9FX+5XRGpXNcLorfuot2D3n 4c07lzM+LqQXevd538okD7e+YXaxhuJwGlrws6Cze185ZDSAlq0RIN7PUBqqeTPIR+mH 5xWWW4em3wWvgZtvpLSDEzn4b4FH/KdcYd/zNhpMFdunnyEEEamspTYXtNV4cPCQB5k+ bkLCVdmqBfeV165obq4DAWFuDd1M2Pri1KNGCyhjc1ZmYbdfu7EBiZHcriUwUeuKwa3q ui4Fy1QH+Sxfuz5lALXb3QkW1yfqNfHnNzSKSXmkofNYG75Ri11hlCwvY16n7WZS8SAP ks0g== X-Forwarded-Encrypted: i=1; AJvYcCVP+jNHeT1qVnCt2jT6n+1zJIPVC1FzhJlv2c9kewkkXMn8oMNo2iPW/kdUt7+YrUyWTiONH+aIUfoqPH54hxfTexgFW5e5kdEBVd4= X-Gm-Message-State: AOJu0Yy25iTH3R1VNNF+ZIv7LQbAkHbqt8SYtzsT5NdFufn6s3G8xBOr YAGaHDNuB+RNiv5hZ51jub/PKWgMXNqaJ4QB/DNOwKziC5l6uj5qkYZTDLbyBEzQlYJqVitSF7d 5UJceTnHV2qGQhx6p+hXBzwipXdpgFLPOxPrr X-Google-Smtp-Source: AGHT+IFcZ8LGPNpxD+CyijkSEakaabqejnuTmSNnd7xvNofgmBOU9Q+hLp0gjmEcQ9dp7UWhkk+oSQSje588a0Wc16k= X-Received: by 2002:ac8:7fc2:0:b0:432:fea5:e3b4 with SMTP id b2-20020ac87fc2000000b00432fea5e3b4mr179052qtk.3.1712013928247; Mon, 01 Apr 2024 16:25:28 -0700 (PDT) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Saravana Kannan Date: Mon, 1 Apr 2024 16:24:51 -0700 Message-ID: Subject: Re: Fixing the devicetree of Rock 5 Model B (and possibly others) To: Dragan Simic Cc: Pratham Patel , sebastian.reichel@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, regressions@lists.linux.dev, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Mar 23, 2024 at 10:10=E2=80=AFAM Dragan Simic = wrote: > > Hello Pratham, > > On 2024-03-23 18:02, Pratham Patel wrote: > > Since the introduction of the `of: property: fw_devlink: Fix stupid > > bug in remote-endpoint parsing` patch, an issue with the device-tree > > of the Rock 5 Model B has been detected. All the stable kernels (6.7.y > > and 6.8.y) work on the Orange Pi 5, which has the Rockchip RK3588S SoC > > (same as the RK3588, but less I/O basically). So, being an owner of > > only two SBCs which use the RK3588* SoC, it appears that the Rock 5 > > Model B's DT is incorrect. > > > > I looked at the patch and tried several things, neither resulted in > > anything that would point me to the core issue. Then I tried this: > > Could you, please, clarify a bit what's the actual issue you're > experiencing on your Rock 5B? Pratham, can you reply to this please? I don't really understand what your issue is for me to be able to help. Also, can you give the output of /devices_deferred for the good vs bad case? Thanks, Saravana > > > ``` > > $ grep -C 3 remote-endpoint > > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > > > > port { > > es8316_p0_0: endpoint { > > remote-endpoint =3D <&i2s0_8ch_p0_0>; > > }; > > }; > > }; > > -- > > i2s0_8ch_p0_0: endpoint { > > dai-format =3D "i2s"; > > mclk-fs =3D <256>; > > remote-endpoint =3D <&es8316_p0_0>; > > }; > > }; > > }; > > ``` > > > > So, from a cursory look, the issue seems to be related to either the > > DT node for the audio codec or related to the es8316's binding itself. > > Though I doubt that the later is the issue because if that were the > > issue, _someone_ with a Pine64 Pinebook Pro would've raised alarms. So > > far, this seems to be related to the `rk3588-rock-5b.dts` and possibly > > with the `rk3588s-rock-5a.dts` too. > > > > I would **love** to help but I'm afraid I device-trees are not > > something that I am at-all familiar with. That said, I am open to > > methods of debugging this issue to provide a fix myself. > > > > I would have replied to the patch's link but unfortunately, I haven't > > yet setup neomutt and my email provider's web UI doesn't have a > > [straightforward] way to reply using the 'In-Reply-To' header, hence a > > new thread. Apologies for the inconvenience caused. > > > > -- Pratham Patel > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip