From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD24E1A27D for ; Wed, 22 Nov 2023 21:09:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="gIRPrKTH" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a00cbb83c80so28074666b.0 for ; Wed, 22 Nov 2023 13:09:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1700687340; x=1701292140; darn=lists.linux.dev; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DjZ3A9RnpMc/0GPOf8DzrpfaMDka4vJ8RxujHh4ePRw=; b=gIRPrKTHgYSQNWeA2r3JfEKv98VFPZ5N6FUQOaxiLK4WTTxT0YP6cXXY5Chb8NCJGm J6gL/wm6UgiPMNFuj/QTAFFzrXHekQ0JfadjDpAU8sBKoufgW5OB/GUKfOqfC6ysSAns EUtSN25C7KtRugTv0uMJ5uTsIp2RB0sD8mx1k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700687340; x=1701292140; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DjZ3A9RnpMc/0GPOf8DzrpfaMDka4vJ8RxujHh4ePRw=; b=nEJy47JutaIeWREv69ml8RO06r2uTKX/Il9ZfkGbw/zD2FfBgU0zUA9gqSR6WTh2Om bW9V6DZRUaJGqPapvUNpMYEUtr3Y2ue41DMgD6oQ55ziejUaERD89GUwZkR+hAZVU764 w+tBKZPKI0wMOiqhFoIQLHKaYBNukh6pEAEc4kPh75HNxBe+EIXG/pI9vgIrZUFXfXvD yTi4XcW1U93Bq1ZHw/TVGvUeoZCm0UF7Vi++3l3Sdm0y44lvrkmh3AvhKvl0vWugU1WO 24s95xcK/iq+JN9yp7/6NuBiyjKz7mg7XpTBETTQ2Gn+VB6c6S97DTeKZaul0tc++OlI VICA== X-Gm-Message-State: AOJu0YwxPt6ys5twVFTJ33NhEya+qDZ5MfrAIlaZceqPwsW2nlzrbW5B S3FFhqf65S23TyKao+l4AOfuoyOKvrc2p6njCVcSheSk X-Google-Smtp-Source: AGHT+IHzA1SLxn1PmL0MFAsXZBUwS44SPnXikgjIJbzIHc+N5ehgVa3J/z/2hgozmPpc8dRHSPNeFA== X-Received: by 2002:a17:906:1019:b0:a04:cc0e:ff3b with SMTP id 25-20020a170906101900b00a04cc0eff3bmr2092711ejm.27.1700687339693; Wed, 22 Nov 2023 13:08:59 -0800 (PST) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id y12-20020a170906470c00b009fd50aa6984sm217430ejq.83.2023.11.22.13.08.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 13:08:59 -0800 (PST) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5437d60fb7aso279801a12.3 for ; Wed, 22 Nov 2023 13:08:59 -0800 (PST) X-Received: by 2002:aa7:d050:0:b0:53e:1825:be81 with SMTP id n16-20020aa7d050000000b0053e1825be81mr2626539edo.21.1700687338666; Wed, 22 Nov 2023 13:08:58 -0800 (PST) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230825141226.13566-1-lukas.bulwahn@gmail.com> <20231112181036.GBZVEVHIIj/Oos1cx4@fat_crate.local> <0e9cbe6f-ac6c-47f2-b663-a22568799eca@leemhuis.info> <20231122115826.GAZV3s4krKXI002KQ0@fat_crate.local> <20231122155758.GEZV4lBgtZyzsP5Z4V@fat_crate.local> <20231122205135.GGZV5p157mBi6RYUNs@fat_crate.local> In-Reply-To: <20231122205135.GGZV5p157mBi6RYUNs@fat_crate.local> From: Linus Torvalds Date: Wed, 22 Nov 2023 13:08:41 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [regression] microcode files missing in initramfs imgages from dracut (was Re: [PATCH] x86: Clean up remaining references to CONFIG_MICROCODE_AMD) To: Borislav Petkov Cc: Linux regressions mailing list , lukas.bulwahn@gmail.com, dave.hansen@linux.intel.com, hpa@zytor.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de, x86@kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, 22 Nov 2023 at 12:51, Borislav Petkov wrote: > > My only worry here is that we're making a precedent and basically saying > that it is ok for tools to grep .config to figure out what is supported > by the kernel. And then other tools might follow. Yes, I agree that it's not optimal, but I would hate to have some odd "let's add another ELF note" churn too, for (presumably) increasingly obscure reasons. It looks like dracut has been doing this forever, and in fact back in 2015 apparently had the exact same issue (that never made it to kernel developers, or at least not to me), when the kernel CONFIG_MICROCODE_xyz_EARLY config went away, and became just CONFIG_MICROCODE_xyz. The whole "check kernel config" in dracut seems to go back to 2014, so it's been that way for almost a decade by now. Honestly, I think the right approach may be to just remove the check again from dracut entirely - the intent seems to be to make the initrd smaller when people don't support microcode updates, but does that ever actually *happen*? There are dracut command lines, like "--early-microcode" and "--no-early-microcode", so people who really want to save space could just force it that way. Doing the CONFIG_xyz check seems broken. But that's for the dracut people to worry about. I guess we on the kernel side could help with "make install" etc, but we've (intentionally) tried to insulate us from distros having distro-specific installkernel scripts, so we don't really haev a good way to pass information down to the installkernel side. It *would* make sense if we just had some actual arguments we might pass down. Right now we just do exec "${file}" "${KERNELRELEASE}" "${KBUILD_IMAGE}" System.map "${INSTALL_PATH}" so basically the only argument we pass down is that INSTALL_PATH (which is just "/boot" by default). Linus