From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DED72CA0 for ; Mon, 20 Dec 2021 14:57:40 +0000 (UTC) Received: by mail-ed1-f52.google.com with SMTP id b13so10859407edd.8 for ; Mon, 20 Dec 2021 06:57:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HUHmWuXX8VlTF9hpA1y1c+iXS8fi7L43NGXx9Hiegjg=; b=dvs02sSsAlxhiB6e0PVeHzVhBcEy2reW7+Wj9pgM3BKiZ/Gjqf8TFrL6XaVgX4k2HS ap3rX8JYih7erDXKhcGrmWwesnfbgjInwgVz6xHzv80g88dKY98/ke7o2GkeXbFvhLuG XZp3zYy0h/alewh36FJK29g0IxhZsEU8nsl+vCEP23gL/tf03swDjvG7KrM/ZyLLomjz Tw99P2+OhpdT3ADZD3wwlo+0ppbE7S1tqHD1tglcdmSivbKrKQZC8LN748Q9cfgLwc8h cyb+Y6c2gBfmq+eS/SHjTliQCRXg5SMEqfVqUtHaCXQVaIHhtA4UrJScca/BLpyfcprj wwQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HUHmWuXX8VlTF9hpA1y1c+iXS8fi7L43NGXx9Hiegjg=; b=WvDBbv1xAFRRg6U+m+VWpNufGNg22gaLALHzxvXHPw//d2e84ehk/UXHJQmIaGBhbu iD9HUZ4+8MABRgh88CGMIfcZTxx1AuKNWTqtuNlMJWLHXhq/UjW0YLcrBXpDT2zGb3MJ OOiQ0SR7yrsYK3xyQOEe7kbG+CoY90pfjIv4TQzfaaUyBkUXIM1UpVdU7hqYFK/BXom+ nvfrxbr8XJY180W3XPmriDGmtRIeibGxh6rPKpaxGwQxV+Ns8oaUVpkTqTzdOPBaeEXa Qd0d6pcrScAyTUQaxf93UF94VEpSZu1oHpl4ggN64NUbUh9HN+Dv7fzvZ8gyr33CfjTX kqEw== X-Gm-Message-State: AOAM532ySug2outSyvoBf2Zxe2sBriBVho19/y99bcSwUMgVUgc2tIfz 58OluI5JimsA2DQXz6xyUb4wfkQTwXVflH5IVlk/vg== X-Google-Smtp-Source: ABdhPJz9B8jdW71VfZkn6ik656/P3HPcergQlD1ReF7ru9atjKHTO6NZEt3lypROwqtqHQM4b1hb7fZyG+IO7ljSSQw= X-Received: by 2002:a17:907:6289:: with SMTP id nd9mr13119600ejc.101.1640012258769; Mon, 20 Dec 2021 06:57:38 -0800 (PST) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20211217153555.9413-1-marcelo.jimenez@gmail.com> In-Reply-To: From: Bartosz Golaszewski Date: Mon, 20 Dec 2021 15:57:28 +0100 Message-ID: Subject: Re: [PATCH] gpio: Revert regression in sysfs-gpio (gpiolib.c) To: Marcelo Roberto Jimenez , Thorsten Leemhuis Cc: stable , regressions@lists.linux.dev, Linus Walleij , "open list:GPIO SUBSYSTEM" , Thierry Reding , Vidya Sagar , Geert Uytterhoeven , Stephen Rothwell , Edmond Chung , Andrew Chant , Will McVicker , Sergio Tanzilli Content-Type: text/plain; charset="UTF-8" On Sat, Dec 18, 2021 at 7:28 AM Thorsten Leemhuis wrote: > > [TLDR: I'm adding this regression to regzbot, the Linux kernel > regression tracking bot; most text you find below is compiled from a few > templates paragraphs some of you might have seen already.] > > On 17.12.21 16:35, Marcelo Roberto Jimenez wrote: > > Some GPIO lines have stopped working after the patch > > commit 2ab73c6d8323f ("gpio: Support GPIO controllers without pin-ranges") > > > > And this has supposedly been fixed in the following patches > > commit 89ad556b7f96a ("gpio: Avoid using pin ranges with !PINCTRL") > > commit 6dbbf84603961 ("gpiolib: Don't free if pin ranges are not defined") > > There seems to be a backstory here. Are there any entries and bug > trackers or earlier discussions everyone that looks into this should be > aware of? > Agreed with Thorsten. I'd like to first try to determine what's wrong before reverting those, as they are correct in theory but maybe the implementation missed something. Have you tried tracing the execution on your platform in order to see what the driver is doing? Bart