From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B9402C81 for ; Wed, 10 Nov 2021 23:25:48 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D8D0761267 for ; Wed, 10 Nov 2021 23:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636586747; bh=w5E48ojVJEf9pLnUJB3vpyZm4JjYM02yvXnZ070vT1U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=s0maOYW9m0CwiD3Vvmc4J+Ys368QVEkECaoGuXhcfvlMniFHdVtg2J3CKbYbXPc+m /aGotfx+SY/l4F6hwN7EqcqeoAnl4Y/00bmGeypUx1v04HNalUahENxsQ8XEVd0MYc +zSv4Tgsr4owu1RKh+GTwOwzR9tqKB8F91uQuz5SC0gON6uG1WeP2Y8I3b22gMtxZY S3pxq92Bi4JKGU7ZCdqO95qU8gAPOh/di8/ui73MfhQrgmA2y60UUkwHjfp3J/eXi8 i2l8DVMdnH/wBXNinuL6gyuLuIT9ftJyjKb8BO4EoD3qRMROCy4fNMZzZl1y0SoVhU SmpSYO3v4iX7w== Received: by mail-ot1-f50.google.com with SMTP id w6-20020a9d77c6000000b0055e804fa524so6314580otl.3 for ; Wed, 10 Nov 2021 15:25:47 -0800 (PST) X-Gm-Message-State: AOAM533Gots4znncwbMuk/e/il4uxWIDUBcmeg2n3++ExsUlDt65Fj0O tt04RaXhwqRsanDUOCH8ag/C7OjWFqwJAXwSfec= X-Google-Smtp-Source: ABdhPJxqHkTXeHhqwAm7NMJDHQQm5a+fqWJbtR4CwSdRrgysO6oYvId3c/L3y0SjVJEl4S81SAZ/Q+wLq41jA+pFeDE= X-Received: by 2002:a05:6830:1514:: with SMTP id k20mr2280823otp.147.1636586747125; Wed, 10 Nov 2021 15:25:47 -0800 (PST) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20211110200253.rfudkt3edbd3nsyj@lahvuun> <20211110232157.xfeue3sbquyhtqmf@lahvuun> In-Reply-To: <20211110232157.xfeue3sbquyhtqmf@lahvuun> From: Ard Biesheuvel Date: Thu, 11 Nov 2021 00:25:35 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [REGRESSION]: drivers/firmware: move x86 Generic System Framebuffers support To: Ilya Trukhanov Cc: "# 3.4.x" , regressions@lists.linux.dev, linux-efi , Linux PM , Javier Martinez Canillas , Thomas Zimmermann , "Rafael J. Wysocki" , Len Brown , pavel@ucw.cz Content-Type: text/plain; charset="UTF-8" On Thu, 11 Nov 2021 at 00:22, Ilya Trukhanov wrote: > > On Wed, Nov 10, 2021 at 11:24:03PM +0100, Ard Biesheuvel wrote: > > Hi Ilya, > > > > On Wed, 10 Nov 2021 at 21:02, Ilya Trukhanov wrote: > > > > > > Suspend-to-RAM with elogind under Wayland stopped working in 5.15. > > > > > > This occurs with 5.15, 5.15.1 and latest master at > > > 89d714ab6043bca7356b5c823f5335f5dce1f930. 5.14 and earlier releases work > > > fine. > > > > > > git bisect gives d391c58271072d0b0fad93c82018d495b2633448. > > > > > > To reproduce: > > > - Use elogind and Linux 5.15.1 with CONFIG_SYSFB_SIMPLEFB=n. > > > - Start a Wayland session. I tested sway and weston, neither worked. > > > - In a terminal emulator (I used alacritty) execute `loginctl suspend`. > > > > > > Normally after the last step the system would suspend, but it no longer > > > does so after I upgraded to Linux 5.15. After running `loginctl suspend` > > > in dmesg I get the following: > > > [ 103.098782] elogind-daemon[2357]: Suspending system... > > > [ 103.098794] PM: suspend entry (deep) > > > [ 103.124621] Filesystems sync: 0.025 seconds > > > > > > But nothing happens afterwards. > > > > > > Suspend works as expected if I do any of the following: > > > - Revert d391c58271072d0b0fad93c82018d495b2633448. > > > - Build with CONFIG_SYSFB_SIMPLEFB=y. > > > > If this solves the issue, what else is there to discuss? > Sorry, I'm not a kernel developer, but I was under the impression > that this is a regression and should at least be brought to attention. > > I also think I'm probably not the last person to encounter this. I'm > fortunate because I had the time to bisect and get the idea to try > enabling that option, but others may not know how to fix it. > > The suspend not working is also not the only effect. After you execute > `loginctl suspend`, for example, the compositor just hangs if you try to > exit. Should you kill it with SysRq+I, the system suspends but after > resume doesn't respond to anything and has to be hard reset. I think > this is a pretty serious issue, even if it won't affect most users. > > Sorry if I wasn't meant to CC you. The issue reporting guide says that > you should CC maintainers of affected subsystems. No worries. You cc'ed the right people, and we appreciate the time you have spent to track down the root cause. So can you explain why the solution to this issue is not simply 'enable CONFIG_SYSFB_SIMPLEFB' ?