From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 649122F5A for ; Tue, 23 Aug 2022 17:14:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F7AEC433C1 for ; Tue, 23 Aug 2022 17:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661274841; bh=0l2e7AEMB26GbMicu+Gxo6P6hcCdemCnqhFgOYjvvwU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GPX40d4fBu6bu6C53o50ZTk7CX8C3uz4ujYaNZFSMI8s+QaevtYg0TDHvuSulKtIa wASqzdw/nZ0yxyXY3YMLULStLLBFcIVHp+jHaRoax4IhzDw1kOD4Bhay2FqRqqoEp9 7f5pDYmZAkgEHfvOkfvnWz0JUaQiYPYGqatKC7Ylofut01bykvEF/5Cfb/UqLlIco9 wC5M9CEvGwfuz1TOPoO35jHe9BTrG8tLWA8Nx3YcMdudFaAXoulKSv3wunKTKe1sIw HbSlXqYMzToFVbSJ9Y3z4rl8J++LLpvc0d+cvGzmDApDfTAIOfFC7uVCxMa1HnbsIZ JU9JLxfdnILZQ== Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-3321c2a8d4cso396890057b3.5 for ; Tue, 23 Aug 2022 10:14:01 -0700 (PDT) X-Gm-Message-State: ACgBeo1U4zOhnnslWK6lWvKFzXg0X+aPp30SxKw4jkS+mvG2PIt2Ykui V6TB9gg9AwL+JRLPj7nFiiafZWfHOEnhV/4Czik= X-Google-Smtp-Source: AA6agR7pK8zUJ/YyKcYl4BgvfFAQmRvmnt1ZvRaHC/VHHXvSpwujQl+eYE8kW4U1HUuWwv7tHueksFDat8UZE3nDZdg= X-Received: by 2002:a81:910d:0:b0:330:23a8:bec4 with SMTP id i13-20020a81910d000000b0033023a8bec4mr27044820ywg.148.1661274840199; Tue, 23 Aug 2022 10:14:00 -0700 (PDT) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <000401d8a746$3eaca200$bc05e600$@whissi.de> <000001d8ad7e$c340ad70$49c20850$@whissi.de> <2a2d1075-aa22-8c4d-ca21-274200dce2fc@leemhuis.info> <0FBCAB10-545E-45E2-A0C8-D7620817651D@digitalocean.com> <43e678ca-3fc3-6c08-f035-2c31a34dd889@whissi.de> <701f3fc0-2f0c-a32c-0d41-b489a9a59b99@whissi.de> <0192a465-d75d-c09a-732a-eb2215bf3479@whissi.de> <4f69659f-7160-7854-0ed5-6867e3eb2edb@whissi.de> <172d7663-ce22-f87a-6aa0-0b6145115711@whissi.de> In-Reply-To: <172d7663-ce22-f87a-6aa0-0b6145115711@whissi.de> From: Song Liu Date: Tue, 23 Aug 2022 10:13:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [REGRESSION] v5.17-rc1+: FIFREEZE ioctl system call hangs To: Thomas Deutschmann Cc: Christoph Hellwig , Vishal Verma , Thorsten Leemhuis , "stable@vger.kernel.org" , "regressions@lists.linux.dev" , Jens Axboe Content-Type: text/plain; charset="UTF-8" On Mon, Aug 22, 2022 at 8:15 PM Thomas Deutschmann wrote: > > On 2022-08-23 03:37, Song Liu wrote: > > Thomas, have you tried to bisect with the fio repro? > > Yes, just finished: > > > d32d3d0b47f7e34560ae3c55ddfcf68694813501 is the first bad commit > > commit d32d3d0b47f7e34560ae3c55ddfcf68694813501 > > Author: Christoph Hellwig > > Date: Mon Jun 14 13:17:34 2021 +0200 > > > > nvme-multipath: set QUEUE_FLAG_NOWAIT > > > > The nvme multipathing code just dispatches bios to one of the blk-mq > > based paths and never blocks on its own, so set QUEUE_FLAG_NOWAIT > > to support REQ_NOWAIT bios. > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d32d3d0b47f7e34560ae3c55ddfcf68694813501 > > > So another NOWAIT issue -- similar to the bad commit which is causing > the mdraid issue I already found > (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0f9650bd838efe5c52f7e5f40c3204ad59f1964d). > > Reverting the commit, i.e. deleting > > blk_queue_flag_set(QUEUE_FLAG_NOWAIT, head->disk->queue); > > fixes the problem for me. Well, sort of. Looks like this will disable > io_uring. fio reproducer fails with My system doesn't have multipath enabled. I guess bisect will point to something else here. I am afraid we won't get more information from bisect. Thanks, Song > > > $ fio reproducer.fio > > filename0: (g=0): rw=randwrite, bs=(R) 4096B-4096B, (W) 4096B-4096B, (T) 4096B-4096B, ioengine=io_uring, iodepth=1 > > fio-3.30 > > Starting 1 thread > > fio: io_u error on file /srv/machines/fio/filename0.0.0: Operation not supported: write offset=12648448, buflen=4096 > > fio: pid=1585, err=95/file:io_u.c:1846, func=io_u error, error=Operation not supported > > My MariaDB reproducer also doesn't trigger the problem anymore, but > probably for the same reason -- it cannot use io_uring anymore. >