From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.holtmann.org (coyote.holtmann.net [212.227.132.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ED8362C81 for ; Mon, 29 Nov 2021 08:08:18 +0000 (UTC) Received: from smtpclient.apple (p5b3d2e91.dip0.t-ipconnect.de [91.61.46.145]) by mail.holtmann.org (Postfix) with ESMTPSA id 31804CED21; Mon, 29 Nov 2021 09:08:17 +0100 (CET) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\)) Subject: Re: [PATCH 2/6] btbcm: disable read tx power for MacBook Pro 16,1 (16 inch, 2019) From: Marcel Holtmann In-Reply-To: <5B9FF471-42DD-44DA-A9CE-0A83BA7A4212@live.com> Date: Mon, 29 Nov 2021 09:08:16 +0100 Cc: Thorsten Leemhuis , Orlando Chamberlain , Daniel Winkler , Greg KH , Johan Hedberg , "linux-bluetooth@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Luiz Augusto von Dentz , "regressions@lists.linux.dev" , "sonnysasaka@chromium.org" , "stable@vger.kernel.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <20211001083412.3078-1-redecorating@protonmail.com> <70a875d0-7162-d149-dbc1-c2f5e1a8e701@leemhuis.info> <20211116090128.17546-1-redecorating@protonmail.com> <3B8E16FA-97BF-40E5-9149-BBC3E2A245FE@live.com> <52DEDC31-EEB2-4F39-905F-D5E3F2BBD6C0@live.com> <8919a36b-e485-500a-2722-529ffa0d2598@leemhuis.info> <20211117124717.12352-1-redecorating@protonmail.com> <40550C00-4EE5-480F-AFD4-A2ACA01F9DBB@live.com> <332a19f1-30f0-7058-ac18-c21cf78759bb@leemhuis.info> <5B9FF471-42DD-44DA-A9CE-0A83BA7A4212@live.com> To: Aditya Garg X-Mailer: Apple Mail (2.3693.20.0.1.32) Hi Aditya, > Bluetooth on Apple MacBook Pro 16,1 is unable to start due to LE = Min/Max Tx Power being queried on startup. Add a DMI based quirk so that = it is disabled. list all the MacBooks that you found problematic right now. We add the initial as a large batch instead of all individual. >=20 > Signed-off-by: Aditya Garg > Tested-by: Aditya Garg > --- > drivers/bluetooth/btbcm.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) >=20 > diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c > index e4182acee488c5..c1b0ca63880a68 100644 > --- a/drivers/bluetooth/btbcm.c > +++ b/drivers/bluetooth/btbcm.c > @@ -8,6 +8,7 @@ >=20 > #include > #include > +#include > #include >=20 > #include > @@ -343,9 +344,23 @@ static struct sk_buff = *btbcm_read_usb_product(struct hci_dev *hdev) > return skb; > } >=20 > +static const struct dmi_system_id = disable_broken_read_transmit_power[] =3D { > + { > + /* Match for Apple MacBook Pro 16,1 which needs > + * Read LE Min/Max Tx Power to be disabled. > + */ Actually leave the comment out. You are not adding any value that = isn=E2=80=99t already in the variable name or the DMI. It is just repeating the = obvious. > + .matches =3D { > + DMI_MATCH(DMI_BOARD_VENDOR, "Apple Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro16,1"), > + }, > + }, > + { } > +}; > + > static int btbcm_read_info(struct hci_dev *hdev) > { > struct sk_buff *skb; > + const struct dmi_system_id *dmi_id; >=20 > /* Read Verbose Config Version Info */ > skb =3D btbcm_read_verbose_config(hdev); > @@ -362,6 +377,11 @@ static int btbcm_read_info(struct hci_dev *hdev) >=20 > bt_dev_info(hdev, "BCM: features 0x%2.2x", skb->data[1]); > kfree_skb(skb); > + > + /* Read DMI and disable broken Read LE Min/Max Tx Power */ > + dmi_id =3D dmi_first_match(disable_broken_read_transmit_power); > + if (dmi_id) > + set_bit(HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER, = &hdev->quirks); if (dmi_first_match(..)) set_bit(.., &hdev->quirks); There is really no need to have a variable for this. Regards Marcel