From: Aditya Garg <gargaditya08@live.com>
To: Orlando Chamberlain <redecorating@protonmail.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"kbusch@kernel.org" <kbusch@kernel.org>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
"hare@suse.de" <hare@suse.de>,
"dwagner@suse.de" <dwagner@suse.de>, "hch@lst.de" <hch@lst.de>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"axboe@fb.com" <axboe@fb.com>,
"james.smart@broadcom.com" <james.smart@broadcom.com>,
"chaitanya.kulkarni@wdc.com" <chaitanya.kulkarni@wdc.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [REGRESSION] nvme: code command_id with a genctr for use-after-free validation crashes apple T2 SSD
Date: Mon, 27 Sep 2021 04:51:40 +0000 [thread overview]
Message-ID: <PNZPR01MB4415F35759F136E812A8F91DB8A79@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <31c4dc69-5d10-cc6a-4295-e42bbc0993d0@protonmail.com>
I am getting the same error.
________________________________________
From: Orlando Chamberlain <redecorating@protonmail.com>
Sent: Monday, September 27, 2021 4:22 AM
To: Sagi Grimberg; Aditya Garg; kbusch@kernel.org
Cc: linux-nvme@lists.infradead.org; regressions@lists.linux.dev; hare@suse.de; dwagner@suse.de; hch@lst.de
Subject: Re: [REGRESSION] nvme: code command_id with a genctr for use-after-free validation crashes apple T2 SSD
On 26/9/21 18:44, Sagi Grimberg wrote:
>
>> I checked out the proposal sent by Orlando Chamberlain to replace NVME_QUIRK_SHARED_TAGS , by NVME_QUIRK_SHARED_TAGS | given in the patch on http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html. The , still causes panics to the T2 as described before. In the case of |, the kernel boots correctly without panicking the T2, but in case we are having Linux on an External Drive, which is my case, then the internal SSD doesn't seem to be recognised at all. I've tested the patch on 5.14.7.
>
> That sounds like a separate issue, because with this patch applied,
> all tags should be within the queue entry range (with generation
> set to 0 always).
>
> Is it possible that the io_queue_depth is being set to something
> that exceeds NVME_PCI_MAX_QUEUE_SIZE (4095) ? the default is 1024
>
I've been able to reproduce it by using the same kernel Aditya is using:
https://github.com/AdityaGarg8/T2-Big-Sur-Ubuntu-Kernel/actions/runs/1275383460
From the initramfs:
# dmesg | grep nvme
nvme nvme0: pci function 0000:04:00.0
nvme nvme0: 1/0/0 default/read/poll queues
nvme nvme0: Identify NS List failed (status=0xb)
nvme nvme0: LightNVM init failure
It might be because this is 5.14.7, while I've been using 5.15-rc2. Additionally,
there are differences in kernel configs, I've put both configs in this gist
https://gist.github.com/Redecorating/c8cf574df969f9b4f626dfb9c6b2a758
next prev parent reply other threads:[~2021-09-27 4:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 13:10 [REGRESSION] nvme: code command_id with a genctr for use-after-free validation crashes apple T2 SSD Orlando Chamberlain
2021-09-25 17:16 ` Keith Busch
2021-09-25 23:40 ` Orlando Chamberlain
2021-09-26 2:08 ` Keith Busch
2021-09-26 3:53 ` Orlando Chamberlain
2021-09-26 4:35 ` Orlando Chamberlain
[not found] ` <PNZPR01MB4415801C6084E8CFD068A84AB8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
2021-09-26 8:44 ` Sagi Grimberg
2021-09-27 4:22 ` Orlando Chamberlain
2021-09-27 4:51 ` Aditya Garg [this message]
2021-09-27 6:05 ` Sven Peter
2021-09-27 15:02 ` Keith Busch
2021-09-26 5:59 ` Thorsten Leemhuis
2021-10-04 9:17 ` Thorsten Leemhuis
2021-10-04 9:27 ` Greg KH
2021-10-04 10:11 ` Thorsten Leemhuis
2021-10-04 11:36 ` Greg KH
2021-10-05 5:50 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PNZPR01MB4415F35759F136E812A8F91DB8A79@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM \
--to=gargaditya08@live.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=redecorating@protonmail.com \
--cc=regressions@lists.linux.dev \
--cc=sagi@grimberg.me \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).