#regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

#regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

[Naresh Kamboju]

[If it is already reported please ignore]

LKFT test reported regression on TI BeagleBoard-X15 arm32 bit platform as
The device was not able to detect SATA drive.

dmesg short log:
----------------------
jitterentropy: Initialization failed with host not compliant with
requirements: 2
ata1: SATA max UDMA/133 mmio [mem 0x4a140000-0x4a1410ff] port 0x100 irq 101
wkupaon-clkctrl:0068:0: failed to disable
ata1: SATA link down (SStatus 0 SControl 300)
ata1: softreset failed (1st FIS failed)

Our bisect script pointed this as the first bad commit on linux
mainline master branch.

Full test log:
----------------
SATA detection failed log link,
https://lkft.validation.linaro.org/scheduler/job/2580998#L1973

--
commit 98feab31ac491400f28b76a04dabd18ce21e91ba
Author: Tony Lindgren <tony@atomide.com>
Date:   Wed Mar 10 14:03:51 2021 +0200

    ARM: OMAP2+: Drop legacy platform data for dra7 sata

    We can now probe devices with ti-sysc interconnect driver and dts data.
    Let's drop the related platform data and custom ti,hwmods dts property.

    As we're just dropping data, and the early platform data init is based on
    the custom ti,hwmods property, we want to drop both the platform data and
    ti,hwmods property in a single patch.

    Signed-off-by: Tony Lindgren <tony@atomide.com>
-- 

steps to reproduce:
-------------------------
- Build arm zImage/dtb/modules on mainline tree and configs
- connect SATA drive and boot x15 device
- check the dmesg for failed logs
 - check to find /dev/sda

metadata:
  git branch: master
  git repo: https://gitlab.com/Linaro/lkft/mirrors/torvalds/linux-mainline
  git commit: f0728bfeb21a24bbb7d5ad1828b67a359550fa17
  kernel-config: https://builds.tuxbuild.com/1rjBx0LdvYwlWdINXaDPvIigvcC/config
  build-url: https://gitlab.com/Linaro/lkft/mirrors/torvalds/linux-mainline/-/pipelines/292686420

Steps to build:
--------------------
# TuxMake is a command line tool and Python library that provides
# portable and repeatable Linux kernel builds across a variety of
# architectures, toolchains, kernel configurations, and make targets.
#
# TuxMake supports the concept of runtimes.
# See https://docs.tuxmake.org/runtimes/, for that to work it requires
# that you install podman or docker on your system.
#
# To install tuxmake on your system globally:
# sudo pip3 install -U tuxmake
#
# See https://docs.tuxmake.org/ for complete documentation.


tuxmake --runtime podman --target-arch arm --toolchain gcc-9 --kconfig
defconfig --kconfig-add
https://raw.githubusercontent.com/Linaro/meta-lkft/sumo/recipes-kernel/linux/files/lkft.config
--kconfig-add https://raw.githubusercontent.com/Linaro/meta-lkft/sumo/recipes-kernel/linux/files/lkft-crypto.config
--kconfig-add https://raw.githubusercontent.com/Linaro/meta-lkft/sumo/recipes-kernel/linux/files/distro-overrides.config
--kconfig-add https://raw.githubusercontent.com/Linaro/meta-lkft/sumo/recipes-kernel/linux/files/systemd.config
--kconfig-add https://raw.githubusercontent.com/Linaro/meta-lkft/sumo/recipes-kernel/linux/files/virtio.config
--kconfig-add CONFIG_ARM_TI_CPUFREQ=y --kconfig-add
CONFIG_SERIAL_8250_OMAP=y --kconfig-add CONFIG_POSIX_MQUEUE=y
--kconfig-add CONFIG_OF=y --kconfig-add CONFIG_SYN_COOKIES=y


--
Linaro LKFT
https://lkft.linaro.org

Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

[Tony Lindgren]

Hi,

* Naresh Kamboju <naresh.kamboju@linaro.org> [210506 11:00]:
> Our bisect script pointed this as the first bad commit on linux
> mainline master branch.
> 
> Full test log:
> ----------------
> SATA detection failed log link,
> https://lkft.validation.linaro.org/scheduler/job/2580998#L1973
> 
> --
> commit 98feab31ac491400f28b76a04dabd18ce21e91ba
> Author: Tony Lindgren <tony@atomide.com>
> Date:   Wed Mar 10 14:03:51 2021 +0200
> 
>     ARM: OMAP2+: Drop legacy platform data for dra7 sata

Thanks for the report, looks like we are now missing the sata related
quirk flags compared to the patch above.

Below is a quick patch to add the missing quirk flags that might help
if you can give it a try.

Regards,

Tony

8< --------------------------
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -1459,6 +1459,8 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
 		   SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
 	SYSC_QUIRK("tptc", 0, 0, -ENODEV, -ENODEV, 0x40007c00, 0xffffffff,
 		   SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
+	SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff,
+		   SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
 	SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, 0x14, 0x50700100, 0xffffffff,
 		   SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
 	SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, -ENODEV, 0x50700101, 0xffffffff,
@@ -1524,7 +1526,6 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
 	SYSC_QUIRK("prcm", 0, 0, -ENODEV, -ENODEV, 0x40000400, 0xffffffff, 0),
 	SYSC_QUIRK("rfbi", 0x4832a800, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0),
 	SYSC_QUIRK("rfbi", 0x58002000, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0),
-	SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff, 0),
 	SYSC_QUIRK("scm", 0, 0, 0x10, -ENODEV, 0x40000900, 0xffffffff, 0),
 	SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4e8b0100, 0xffffffff, 0),
 	SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4f000100, 0xffffffff, 0),
-- 
2.31.1

Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

[Naresh Kamboju]

On Thu, 6 May 2021 at 17:23, Tony Lindgren <tony@atomide.com> wrote:
>
> Hi,
>
> * Naresh Kamboju <naresh.kamboju@linaro.org> [210506 11:00]:
> > Our bisect script pointed this as the first bad commit on linux
> > mainline master branch.
> >
> > Full test log:
> > ----------------
> > SATA detection failed log link,
> > https://lkft.validation.linaro.org/scheduler/job/2580998#L1973
> >
> > --
> > commit 98feab31ac491400f28b76a04dabd18ce21e91ba
> > Author: Tony Lindgren <tony@atomide.com>
> > Date:   Wed Mar 10 14:03:51 2021 +0200
> >
> >     ARM: OMAP2+: Drop legacy platform data for dra7 sata
>
> Thanks for the report, looks like we are now missing the sata related
> quirk flags compared to the patch above.
>
> Below is a quick patch to add the missing quirk flags that might help
> if you can give it a try.

The reported problem was solved by this patch. Thank you.
Please add reported and tested by tags.

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org>

>
> Regards,
>
> Tony
>
> 8< --------------------------
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -1459,6 +1459,8 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
>                    SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
>         SYSC_QUIRK("tptc", 0, 0, -ENODEV, -ENODEV, 0x40007c00, 0xffffffff,
>                    SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
> +       SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff,
> +                  SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
>         SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, 0x14, 0x50700100, 0xffffffff,
>                    SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
>         SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, -ENODEV, 0x50700101, 0xffffffff,
> @@ -1524,7 +1526,6 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
>         SYSC_QUIRK("prcm", 0, 0, -ENODEV, -ENODEV, 0x40000400, 0xffffffff, 0),
>         SYSC_QUIRK("rfbi", 0x4832a800, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0),
>         SYSC_QUIRK("rfbi", 0x58002000, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0),
> -       SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff, 0),
>         SYSC_QUIRK("scm", 0, 0, 0x10, -ENODEV, 0x40000900, 0xffffffff, 0),
>         SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4e8b0100, 0xffffffff, 0),
>         SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4f000100, 0xffffffff, 0),
> --
> 2.31.1


Tested full log,
https://lkft.validation.linaro.org/scheduler/job/2641881#L1940

- Naresh

Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

[Tony Lindgren]

* Naresh Kamboju <naresh.kamboju@linaro.org> [210506 15:19]:
> On Thu, 6 May 2021 at 17:23, Tony Lindgren <tony@atomide.com> wrote:
> >
> > Hi,
> >
> > * Naresh Kamboju <naresh.kamboju@linaro.org> [210506 11:00]:
> > > Our bisect script pointed this as the first bad commit on linux
> > > mainline master branch.
> > >
> > > Full test log:
> > > ----------------
> > > SATA detection failed log link,
> > > https://lkft.validation.linaro.org/scheduler/job/2580998#L1973
> > >
> > > --
> > > commit 98feab31ac491400f28b76a04dabd18ce21e91ba
> > > Author: Tony Lindgren <tony@atomide.com>
> > > Date:   Wed Mar 10 14:03:51 2021 +0200
> > >
> > >     ARM: OMAP2+: Drop legacy platform data for dra7 sata
> >
> > Thanks for the report, looks like we are now missing the sata related
> > quirk flags compared to the patch above.
> >
> > Below is a quick patch to add the missing quirk flags that might help
> > if you can give it a try.
> 
> The reported problem was solved by this patch. Thank you.
> Please add reported and tested by tags.
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org>

OK good to hear and thanks for testing. Will send out a proper patch.

Regards,

Tony

> > 8< --------------------------
> > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> > --- a/drivers/bus/ti-sysc.c
> > +++ b/drivers/bus/ti-sysc.c
> > @@ -1459,6 +1459,8 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
> >                    SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
> >         SYSC_QUIRK("tptc", 0, 0, -ENODEV, -ENODEV, 0x40007c00, 0xffffffff,
> >                    SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
> > +       SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff,
> > +                  SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
> >         SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, 0x14, 0x50700100, 0xffffffff,
> >                    SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
> >         SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, -ENODEV, 0x50700101, 0xffffffff,
> > @@ -1524,7 +1526,6 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
> >         SYSC_QUIRK("prcm", 0, 0, -ENODEV, -ENODEV, 0x40000400, 0xffffffff, 0),
> >         SYSC_QUIRK("rfbi", 0x4832a800, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0),
> >         SYSC_QUIRK("rfbi", 0x58002000, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0),
> > -       SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff, 0),
> >         SYSC_QUIRK("scm", 0, 0, 0x10, -ENODEV, 0x40000900, 0xffffffff, 0),
> >         SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4e8b0100, 0xffffffff, 0),
> >         SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4f000100, 0xffffffff, 0),
> > --
> > 2.31.1
> 
> 
> Tested full log,
> https://lkft.validation.linaro.org/scheduler/job/2641881#L1940
> 
> - Naresh

Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

[Thorsten Leemhuis]

On 07.05.21 10:02, Tony Lindgren wrote:
> * Naresh Kamboju <naresh.kamboju@linaro.org> [210506 15:19]:
>> On Thu, 6 May 2021 at 17:23, Tony Lindgren <tony@atomide.com> wrote:
>>> * Naresh Kamboju <naresh.kamboju@linaro.org> [210506 11:00]:
>>>> Our bisect script pointed this as the first bad commit on linux
>>>> mainline master branch.
>>>> commit 98feab31ac491400f28b76a04dabd18ce21e91ba
>>>> Author: Tony Lindgren <tony@atomide.com>
>>>> Date:   Wed Mar 10 14:03:51 2021 +0200
>>>>     ARM: OMAP2+: Drop legacy platform data for dra7 sata
>>> Thanks for the report, looks like we are now missing the sata related
>>> quirk flags compared to the patch above.
>>> Below is a quick patch to add the missing quirk flags that might help
>>> if you can give it a try.
>> The reported problem was solved by this patch. Thank you.
>> Please add reported and tested by tags.
>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>> Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> OK good to hear and thanks for testing. Will send out a proper patch.

Great to see that this is about to be fixed. And Naresh, many thx for
giving the #regzb tag a try, even if regzbot (shameless plug for the
unaware: https://linux-regtracking.leemhuis.info/post/regzbot-approach/
) is not up and running already, much appreciated!

But FWIW, you don't need to add the tag to the subject; in fact, better
use it for it's intended purpose. Instead add the tag to the mail's
body, like this:

#regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data
for dra7 sata")

Just ensure there is a blank line after that, as regzbot will have to
deal with line breaks (as can be seen above) and somehow needs to decide
where to stop. ;-)

Ohh, and Tony, if you want to do me a favour please include

Link:
https://lore.kernel.org/regressions/CA+G9fYtTN6ug3eBAW3wMcDeESUo+ebj7L5HBe5_fj4uqDExFQg@mail.gmail.com/

in the commit message of the fix, then I have some real data already at
hand to test regzbot in practice. :-D

Ciao, Thorsten

Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

[Tony Lindgren]

Hi,

* Thorsten Leemhuis <linux@leemhuis.info> [210507 08:27]:
> Ohh, and Tony, if you want to do me a favour please include
> 
> Link:
> https://lore.kernel.org/regressions/CA+G9fYtTN6ug3eBAW3wMcDeESUo+ebj7L5HBe5_fj4uqDExFQg@mail.gmail.com/
> 
> in the commit message of the fix, then I have some real data already at
> hand to test regzbot in practice. :-D

OK sent with a fixes and link tag. As a test, I sent it to the lists I
usually send patches to for this driver. The subject line is different,
and I left out all the extra Cc including you and regzb mailing list as
those are easy to forget to add to the mail. Let's see if regzb finds
the fix based on the Link or Fixes tag :)

Regards,

Tony

Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

[Naresh Kamboju]

On Fri, 7 May 2021 at 13:57, Thorsten Leemhuis <linux@leemhuis.info> wrote:
>
> On 07.05.21 10:02, Tony Lindgren wrote:
> > * Naresh Kamboju <naresh.kamboju@linaro.org> [210506 15:19]:
> >> On Thu, 6 May 2021 at 17:23, Tony Lindgren <tony@atomide.com> wrote:
> >>> * Naresh Kamboju <naresh.kamboju@linaro.org> [210506 11:00]:
> >>>> Our bisect script pointed this as the first bad commit on linux
> >>>> mainline master branch.
> >>>> commit 98feab31ac491400f28b76a04dabd18ce21e91ba
> >>>> Author: Tony Lindgren <tony@atomide.com>
> >>>> Date:   Wed Mar 10 14:03:51 2021 +0200
> >>>>     ARM: OMAP2+: Drop legacy platform data for dra7 sata
> >>> Thanks for the report, looks like we are now missing the sata related
> >>> quirk flags compared to the patch above.
> >>> Below is a quick patch to add the missing quirk flags that might help
> >>> if you can give it a try.
> >> The reported problem was solved by this patch. Thank you.
> >> Please add reported and tested by tags.
> >> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> >> Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> > OK good to hear and thanks for testing. Will send out a proper patch.
>
> Great to see that this is about to be fixed. And Naresh, many thx for
> giving the #regzb tag a try, even if regzbot (shameless plug for the
> unaware: https://linux-regtracking.leemhuis.info/post/regzbot-approach/
> ) is not up and running already, much appreciated!
>
> But FWIW, you don't need to add the tag to the subject; in fact, better
> use it for it's intended purpose. Instead add the tag to the mail's
> body, like this:
>
> #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data
> for dra7 sata")

Thanks for sharing more details about it.
Next time I will add this to the mail's body.

>
> Just ensure there is a blank line after that, as regzbot will have to
> deal with line breaks (as can be seen above) and somehow needs to decide
> where to stop. ;-)

Alright.

>
> Ohh, and Tony, if you want to do me a favour please include
>
> Link:
> https://lore.kernel.org/regressions/CA+G9fYtTN6ug3eBAW3wMcDeESUo+ebj7L5HBe5_fj4uqDExFQg@mail.gmail.com/
>
> in the commit message of the fix, then I have some real data already at
> hand to test regzbot in practice. :-D

- Naresh

Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

[Tony Lindgren]

* Thorsten Leemhuis <linux@leemhuis.info> [210507 08:27]:
> Great to see that this is about to be fixed. And Naresh, many thx for
> giving the #regzb tag a try, even if regzbot (shameless plug for the
> unaware: https://linux-regtracking.leemhuis.info/post/regzbot-approach/
> ) is not up and running already, much appreciated!

Hmm so the link above does not show where to git clone the regzb program
from? Or is that not yet published? Just wondering.

Regards,

Tony

Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

[Thorsten Leemhuis]

On 07.05.21 11:35, Tony Lindgren wrote:
> * Thorsten Leemhuis <linux@leemhuis.info> [210507 08:27]:
>> Great to see that this is about to be fixed. And Naresh, many thx for
>> giving the #regzb tag a try, even if regzbot (shameless plug for the
>> unaware: https://linux-regtracking.leemhuis.info/post/regzbot-approach/
>> ) is not up and running already, much appreciated!
>
> Hmm so the link above does not show where to git clone the regzb program
> from? Or is that not yet published? Just wondering.

The code is still very early WIP, so not yet published, but I'll publish
the first few bits in a week or two, even if they are not yet useful to
anyone besides myself. ;-)

Ciao, Thorsten

Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

[Tony Lindgren]

* Thorsten Leemhuis <linux@leemhuis.info> [210507 09:39]:
> On 07.05.21 11:35, Tony Lindgren wrote:
> > * Thorsten Leemhuis <linux@leemhuis.info> [210507 08:27]:
> >> Great to see that this is about to be fixed. And Naresh, many thx for
> >> giving the #regzb tag a try, even if regzbot (shameless plug for the
> >> unaware: https://linux-regtracking.leemhuis.info/post/regzbot-approach/
> >> ) is not up and running already, much appreciated!
> >
> > Hmm so the link above does not show where to git clone the regzb program
> > from? Or is that not yet published? Just wondering.
> 
> The code is still very early WIP, so not yet published, but I'll publish
> the first few bits in a week or two, even if they are not yet useful to
> anyone besides myself. ;-)

OK thanks for the update.

Tony