From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E27E365 for ; Mon, 26 Sep 2022 07:09:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF6EDC433C1; Mon, 26 Sep 2022 07:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664176154; bh=+wwySMrMtE5CQ6gKHpsT7ms5I9rHyoBUL87VEi0oDP0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J1+NL5oeoW+aj/l9B3+3Sh9nqoAlC6A3JngBgscVBPS0e/Vu4dNrTNcVropQczx/Q 1O0L1R7HvLYovDo+zujHFZyS0OZ94oVCnahT6vgs3N8shPACeqX+NDWud7TJQBlCwQ 6pyQ9zpd9zuV44nlicUdPuMIXSf38Km8N+l4sTJ0= Date: Mon, 26 Sep 2022 09:09:11 +0200 From: Greg KH To: Jens Axboe Cc: Thorsten Leemhuis , Christoph Hellwig , Dusty Mabe , Ming Lei , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, "regressions@lists.linux.dev" Subject: Re: regression caused by block: freeze the queue earlier in del_gendisk Message-ID: References: <95cbd47d-46ed-850e-7d4f-851b35d03069@dustymabe.com> <20220920141217.GA12560@lst.de> <9594af4b-eb16-0a51-9a4a-e21bbce3317d@kernel.dk> <6a3660b2-fa7d-14a2-6977-f50926ad369c@leemhuis.info> Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Sep 21, 2022 at 08:56:53AM -0600, Jens Axboe wrote: > On Wed, Sep 21, 2022 at 8:47 AM Greg KH wrote: > > > > On Wed, Sep 21, 2022 at 08:34:26AM -0600, Jens Axboe wrote: > > > On 9/21/22 3:25 AM, Thorsten Leemhuis wrote: > > > > On 20.09.22 16:14, Jens Axboe wrote: > > > >> On 9/20/22 8:12 AM, Christoph Hellwig wrote: > > > >>> On Tue, Sep 20, 2022 at 08:05:06AM -0600, Jens Axboe wrote: > > > >>>> Christoph and I discussed this one last week, and he has a plan to try > > > >>>> a flag approach. Christoph, did you get a chance to bang that out? Would > > > >>>> be nice to get this one wrapped up. > > > >>> > > > >>> I gave up on that as it will be far too much change so late in > > > >>> the cycle and sent you the revert yesterday. > > > >> > > > >> Gotcha, haven't made it all the way through the emails of the morning yet. > > > >> I'll queue it up. > > > > > > > > Thx to both of you for taking care of this. > > > > > > > > Nitpicking: that patch is missing a "CC: stable@..." tag to ensure > > > > automatic and quick backporting to 5.19.y. Or is the block layer among > > > > the subsystems that prefer to handle such things manually? > > > > > > > > Ohh, and a fixes tag might have been good as well; a "Link:" tag > > > > pointing to the report, too. If either would have been there, regzbot > > > > would have noticed Christoph's patch posting and I wouldn't have > > > > bothered you yesterday. :-) But whatever, not that important. > > > > > > We'll just have to ensure we ping stable on it when it goes in. > > > > If you have a git id that is not going to change, I can watch out for it > > to land in Linus's tree... > > This is the one: > > commit 4c66a326b5ab784cddd72de07ac5b6210e9e1b06 (origin/block-6.0, block-6.0) > Author: Christoph Hellwig > Date: Mon Sep 19 16:40:49 2022 +0200 > > Revert "block: freeze the queue earlier in del_gendisk" > > Thanks Greg! Now queued up, thanks. greg k-h