From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 125802F5A for ; Sat, 3 Sep 2022 22:00:07 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id q63so4963173pga.9 for ; Sat, 03 Sep 2022 15:00:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=Gm6usRBuViQMTZdHvwpmD6F0l3o1GEDbVd0wQwkYZq4=; b=DpZKsXVxh3/ck373aUGzS6k6rPWwRKMcx6cji7XOAi4kZ6wcAS83ajA3pf59MFEJkp lSs82WvqvpUYvcwZdUpV9QxyP43bvY/qeQfYaVN7fNWfJovhwPvkdGplxrrhnD2iKUze EEj4gJCa7iUG2N1WUJ6Cv9QlKfEoGvYDBVxFfPxH46ZpcsA8qHHJUZ76sN7kDhUlFBD9 OAq/QogOkEkG6bmVjJ+lmi4GEUzP5fhF114QEFZGvQ2WU57oqx7Ff2w6qxIXou3J+Vxp Jv1SWHXmsyhRrOeqdkPACSKN6Hsre7M/kUvd0ou0LsH73+LY4gkadnAozN1YUb62+YsZ bqOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=Gm6usRBuViQMTZdHvwpmD6F0l3o1GEDbVd0wQwkYZq4=; b=TC/7xCGayMhMAHR29Qf2cWkGEeZmqci2reasCdiZ4u43UbuMBSYDTzFM2+yrIsFRNo CUHnfEu+vw9eB9pMYKzNcExPTSqHTi7pKkuXANF7KB+6NzwLN8qor5xefknjRK9VOV9C s1levXwRa4L8r4nveJr+aqbI0nnaz6AHRduUIeOeCVqHehmzziEHvLavThBqvrMcBpCU oivxxfdy0S5rHDxHLitgWaAwlo7Wk99qSJcQtEH+hVYOoI+R5kXAsm1xdzfaxbuEkbUD 7Q2tvFAcWiW9JmDW6DCQp9bAkY8HNXa5FQC7yw9z8NPOItfu53hqGrYW45i3wItHXRPs MnoA== X-Gm-Message-State: ACgBeo2TusFaxB716cJAxsdZzNj4qf9/ix6IfeH8q5VSLTVP/5uT/zFm +3OnsDiZjJZSXZwhRPhbzfs= X-Google-Smtp-Source: AA6agR7y3zdpqy5HjA/yYykeVMbx4JbrwG2lpfDnt4TDVGHWoESf0N13hrFCQQBi3PFLn/vdkmutnA== X-Received: by 2002:a63:465e:0:b0:430:326c:7e6e with SMTP id v30-20020a63465e000000b00430326c7e6emr15500494pgk.84.1662242407445; Sat, 03 Sep 2022 15:00:07 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id x6-20020aa79a46000000b0052d432b4cc0sm4435733pfj.33.2022.09.03.15.00.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Sep 2022 15:00:06 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Sat, 3 Sep 2022 15:00:04 -0700 Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Issue in asus_ec_sensors in Fedora installations and other distributions Content-Language: en-US To: Eugene Shalygin Cc: Christopher Klooz , linux-hwmon@vger.kernel.org, regressions@lists.linux.dev References: <6026b5e2-a8f5-1058-6112-f191bde333a6@my.mail.de> <47e41e8f-f6b2-4bc7-de3f-0c811ee6fdf7@my.mail.de> <62fb8a16-bebd-5de7-0b4f-eed4d2593587@roeck-us.net> <5e42685d-ae82-d74d-4883-d8a9e9fcb243@roeck-us.net> From: Guenter Roeck In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/3/22 12:40, Eugene Shalygin wrote: >> I don't understand why that works either. Maybe it interferes with other >> PNP0C09 devices and/or the code in drivers/acpi/ec.c. > > Turns out the patch breaks sensors on a system where it should provide > output. The module gets loaded but provides no output (which should > mean the probe code is not executed). I will try to investigate > tomorrow. > >> Couple of comments: >> >> - You'll need to drop __init. >> - No need or reason to rename asus_ec_sensors_platform_driver >> to asus_ec_sensors_platform_driver_probe. > That's in order to not drop __init. > What does the name of the struct platform_driver data structure have to do with __init ? Thanks, Guenter