From: Jes Sorensen <jes@trained-monkey.org>
To: NeilBrown <neilb@suse.de>
Cc: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>,
Song Liu <song@kernel.org>,
Linux regressions mailing list <regressions@lists.linux.dev>,
linux-raid <linux-raid@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Nikolay Kichukov <hijacker@oldum.net>
Subject: Re: [PATCH - mdadm] mdopen: always try create_named_array()
Date: Mon, 20 Mar 2023 13:15:35 -0400 [thread overview]
Message-ID: <c36ee145-c258-5a02-f268-30c145996759@trained-monkey.org> (raw)
In-Reply-To: <167926378352.8008.3450187952660050637@noble.neil.brown.name>
On 3/19/23 18:09, NeilBrown wrote:
> On Mon, 20 Mar 2023, Jes Sorensen wrote:
>> On 3/13/23 20:06, NeilBrown wrote:
>>>
>>> mdopen() will use create_named_array() to ask the kernel to create the
>>> given md array, but only if it is given a number or name.
>>> If it is NOT given a name and is required to choose one itself using
>>> find_free_devnm() it does NOT use create_named_array().
>>>
>>> On kernels with CONFIG_BLOCK_LEGACY_AUTOLOAD not set, this can result in
>>> failure to assemble an array. This can particularly seen when the
>>> "name" of the array begins with a host name different to the name of the
>>> host running the command.
>>>
>>> So add the missing call to create_named_array().
>>>
>>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217074
>>> Signed-off-by: NeilBrown <neilb@suse.de>
>>
>> Applied!
>
> Thanks.
>
> Do you have plans for releasing 4.3? I'd like this patch to be in a
> numbered release for at least a few months before we change the kernel
> Kconfig to allow md to be built without CONFIG_BLOCK_LEGACY_AUTOLOAD.
No immediate plans, but no reason why we shouldn't do it. I think
Mariusz has some pending changes he wants to get in as well, like the
error number stuff.
So lets make this a call for submitting changes for mdadm that are
needed for the next release.
Thanks,
Jes
next prev parent reply other threads:[~2023-03-20 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 0:06 [PATCH - mdadm] mdopen: always try create_named_array() NeilBrown
2023-03-14 9:11 ` Mariusz Tkaczyk
2023-03-19 16:36 ` Jes Sorensen
2023-03-19 22:09 ` NeilBrown
2023-03-20 17:15 ` Jes Sorensen [this message]
2023-03-21 8:49 ` Mariusz Tkaczyk
2023-03-22 3:00 ` Xiao Ni
2023-03-22 3:24 ` NeilBrown
2023-03-22 6:51 ` Mariusz Tkaczyk
2023-03-23 2:09 ` Xiao Ni
2023-03-29 21:51 ` NeilBrown
2023-03-30 0:10 ` Xiao Ni
2023-03-30 3:15 ` NeilBrown
2023-03-30 4:55 ` Xiao Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c36ee145-c258-5a02-f268-30c145996759@trained-monkey.org \
--to=jes@trained-monkey.org \
--cc=hijacker@oldum.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mariusz.tkaczyk@linux.intel.com \
--cc=neilb@suse.de \
--cc=regressions@lists.linux.dev \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).