From: Jonas Bonn <firstname.lastname@example.org> To: Marcelo Roberto Jimenez <email@example.com>, firstname.lastname@example.org, Nicolas Ferre <email@example.com>, Alexandre Belloni <firstname.lastname@example.org>, Ludovic Desroches <email@example.com>, firstname.lastname@example.org, Cristian Birsan <email@example.com>, firstname.lastname@example.org, Greg Kroah-Hartman <email@example.com>, Felipe Balbi <firstname.lastname@example.org> Subject: Re: [PATCH] usb: gadget: atmel: Revert regression in USB Gadget (atmel_usba_udc) Date: Mon, 13 Dec 2021 11:02:41 +0100 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Hi Marcelo, On 11/12/2021 19:36, Marcelo Roberto Jimenez wrote: > The regression occurs on the second time a self powered gadget is > connected to the host. In this situation, the gadget no loger accepts > an address in the USB enumeration phase. > > The regression has been introduced in > commit 70a7f8be8598 ("usb: gadget: atmel: support USB suspend") > > Signed-off-by: Marcelo Roberto Jimenez <email@example.com> > --- > > Hi, > > I have been using an ACME Arietta board (Microchip AT91SAM9G25 MPU, ARM9@400Mhz) for some years, and from time to time I need to do a kernel upgrade to fix issues or introduce new required features. > > I have recently noticed a regression in the ethernet over USB Gadget. The system boots fine and when the device is first connected to a host it is recognized. But upon disconnection, the second time the device is connected to the host, it is no longer recognized. Of course, the gadget is self powered. > > I did a "git bisect" and found that the patch introducing the regression is this: > > commit 70a7f8be85986a3c2ffc7274c41b89552dfe2ad0 > Author: Jonas Bonn <firstname.lastname@example.org> > Date: Wed Feb 20 13:20:00 2019 +0100 > usb: gadget: atmel: support USB suspend > This patch adds support for USB suspend to the Atmel UDC. Given that the patch that you want to revert is almost 3 years old, it's a bit of a stretch to call this a regression. I suspect that a cleaner way forward is to introduce some kind of quirk for your board. I have a self-powered board where the USB suspend sequence works and device add/remove works fine. So fundamentally, I suspect that the driver is ok. With all that said, I'm not immediately in a position to run tests on my SAMA5D2 board right now and the kernel on that board is 5.2. I'm not sure when we we would notice that USB suspend stopped working because there is no kernel maintenance planned for that board, as far as I know; someday, however, that work might happen and the lack of working USB suspend will be a regression in and of itself. Thanks, Jonas
next prev parent reply other threads:[~2021-12-13 10:02 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-11 18:36 Marcelo Roberto Jimenez 2021-12-12 9:48 ` Thorsten Leemhuis 2022-01-26 12:20 ` Greg Kroah-Hartman 2022-01-26 12:54 ` Thorsten Leemhuis [not found] ` <CACjc_5o9eO5YTVt4jE7v1E9nirCwFMc1=Ub-jXSFCg1_8A2M-A@mail.gmail.com> 2022-01-26 13:43 ` Marcelo Roberto Jimenez 2021-12-13 10:02 ` Jonas Bonn [this message] [not found] ` <CACjc_5pHbLStniQnOVLDW5iLbKn8ovePuQsFFqeEnQPSSYxJoQ@mail.gmail.com> 2021-12-15 13:04 ` Cristian.Birsan 2021-12-15 15:54 ` Marcelo Roberto Jimenez 2021-12-20 14:50 ` Greg Kroah-Hartman 2021-12-22 18:33 ` Cristian.Birsan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] usb: gadget: atmel: Revert regression in USB Gadget (atmel_usba_udc)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).