From: Thorsten Leemhuis <regressions@leemhuis.info>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Tobias Dahms <dahms.tobias@web.de>,
Sean Wang <sean.wang@mediatek.com>
Cc: stable@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org, linux-wireless@vger.kernel.org,
Linux regressions mailing list <regressions@lists.linux.dev>,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: kernel error at led trigger "phy0tpt"
Date: Mon, 22 May 2023 10:17:42 +0200 [thread overview]
Message-ID: <d78088d6-7989-7538-c4e1-7976a21cf680@leemhuis.info> (raw)
In-Reply-To: <69602f1b-4afa-d864-b6d3-d8237f81a51d@leemhuis.info>
On 17.04.23 13:25, Linux regression tracking (Thorsten Leemhuis) wrote:
> [adding Matthias to the list of recipients, who back then applied to
> culprit]
>
> Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
> for once, to make this easily accessible to everyone.
>
> AngeloGioacchino, Has any progress been made to fix below regression? It
> doesn't look like it from here, hence I wondered if it fall through the
> cracks.
Hmmm, nobody replied. Does nobody (including the reporters!) care
anymore for valid reasons? Then I'd drop this from the tracking.
Or was progress made and I just missed it?
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.
#regzbot poke
> On 27.03.23 10:23, AngeloGioacchino Del Regno wrote:
>> Il 26/03/23 15:23, Bagas Sanjaya ha scritto:
>>> On 3/26/23 02:20, Tobias Dahms wrote:
>>>> Hello,
>>>>
>>>> the bisection gives following result:
>>>> --------------------------------------------------------------------
>>>> 18c7deca2b812537aa4d928900e208710f1300aa is the first bad commit
>>>> commit 18c7deca2b812537aa4d928900e208710f1300aa
>>>> Author: AngeloGioacchino Del Regno
>>>> <angelogioacchino.delregno@collabora.com>
>>>> Date: Tue May 17 12:47:08 2022 +0200
>>>>
>>>> soc: mediatek: pwrap: Use readx_poll_timeout() instead of custom
>>>> function
>>>>
>>>> Function pwrap_wait_for_state() is a function that polls an address
>>>> through a helper function, but this is the very same operation that
>>>> the readx_poll_timeout macro means to do.
>>>> Convert all instances of calling pwrap_wait_for_state() to instead
>>>> use the read_poll_timeout macro.
>>>>
>>>> Signed-off-by: AngeloGioacchino Del Regno
>>>> <angelogioacchino.delregno@collabora.com>
>>>> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>>>> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>>>> Link:
>>>> https://lore.kernel.org/r/20220517104712.24579-2-angelogioacchino.delregno@collabora.com
>>>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>>>
>>>> drivers/soc/mediatek/mtk-pmic-wrap.c | 60
>>>> ++++++++++++++++++++----------------
>>>> 1 file changed, 33 insertions(+), 27 deletions(-)
>>>> --------------------------------------------------------------------
>>>>
>>>
>>> OK, I'm updating the regression status:
>>>
>>> #regzbot introduced: 18c7deca2b8125
>>>
>>> And for replying, don't top-post, but rather reply inline with
>>> appropriate context instead; hence I cut the replied context.
>>>
>>
>> There are two possible solutions to that, specifically, either:
>> 1. Change readx_poll_timeout() to readx_poll_timeout_atomic(); or
>> 2. Fix the mt6323-led driver so that this operation gets done
>> out of atomic context, which is IMO the option to prefer.
>>
>> Ideas?
>>
>> Regards,
>> Angelo
>>
>>
next prev parent reply other threads:[~2023-05-22 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 19:44 kernel error at led trigger "phy0tpt" Tobias Dahms
2023-03-21 14:40 ` Linux regression tracking (Thorsten Leemhuis)
2023-03-21 20:22 ` Tobias Dahms
2023-03-22 16:59 ` Linux regression tracking (Thorsten Leemhuis)
2023-03-25 19:20 ` Tobias Dahms
2023-03-26 13:23 ` Bagas Sanjaya
2023-03-27 8:23 ` AngeloGioacchino Del Regno
2023-04-17 11:25 ` Linux regression tracking (Thorsten Leemhuis)
2023-05-22 8:17 ` Thorsten Leemhuis [this message]
2023-06-05 11:37 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d78088d6-7989-7538-c4e1-7976a21cf680@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bagasdotme@gmail.com \
--cc=dahms.tobias@web.de \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=regressions@lists.linux.dev \
--cc=sean.wang@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).