regressions.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: linux-input@vger.kernel.org
Cc: "José Expósito" <jose.exposito89@gmail.com>,
	"Peter Hutterer" <peter.hutterer@who-t.net>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	"Jiri Kosina" <jkosina@suse.cz>,
	stable@vger.kernel.org, regressions@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: [REGRESSION] Right touchpad button disabled on Dell 7750
Date: Fri, 18 Mar 2022 12:42:31 +0100	[thread overview]
Message-ID: <s5htubv32s8.wl-tiwai@suse.de> (raw)

Hi,

we received a bug report about the regression of the touchpad on Dell
7750 laptop, the right touchpad button is disabled on recent kernels:
  https://bugzilla.suse.com/show_bug.cgi?id=1197243

Note that it's a physical button, not a virtual clickpad button.

The regression seems introduced by the upstream commit
37ef4c19b4c659926ce65a7ac709ceaefb211c40 ("Input: clear
BTN_RIGHT/MIDDLE on buttonpads") that was backported to stable 5.16.x
kernel.

The device is managed by hid-multitouch driver, and the further
investigation revealed that it's rather an incorrectly recognized
buttonpad property; namely, ID_DG_BUTTONTYPE reports it being 0 =
clickable touchpad although it's not.  I built a test kernel to ignore
this check and it was confirmed to make the right button working again
by the reporter.

Is this check really correct in general?  Or do we need some
device-specific quirk?


thanks,

Takashi

             reply	other threads:[~2022-03-18 11:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 11:42 Takashi Iwai [this message]
2022-03-18 13:07 ` [REGRESSION] Right touchpad button disabled on Dell 7750 José Expósito
2022-03-18 13:11   ` Takashi Iwai
2022-03-18 14:06     ` Benjamin Tissoires
2022-03-18 14:28       ` José Expósito
2022-03-18 14:37       ` Takashi Iwai
2022-03-18 16:05         ` José Expósito
2022-03-18 22:01         ` [PATCH] HID: multitouch: fix Dell Precision 7550 and 7750 button type kernel test robot
2022-03-19  8:10       ` [REGRESSION] Right touchpad button disabled on Dell 7750 Takashi Iwai
2022-03-20 19:12         ` José Expósito
2022-03-18 14:47 ` [REGRESSION] Right touchpad button disabled on Dell 7750 #forregzbot Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htubv32s8.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jkosina@suse.cz \
    --cc=jose.exposito89@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.hutterer@who-t.net \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).