rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benno Lossin <benno.lossin@proton.me>
To: Wedson Almeida Filho <wedsonaf@gmail.com>,
	rust-for-linux@vger.kernel.org
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Andreas Hindborg" <a.hindborg@samsung.com>,
	"Alice Ryhl" <aliceryhl@google.com>,
	linux-kernel@vger.kernel.org,
	"Wedson Almeida Filho" <walmeida@microsoft.com>
Subject: Re: [PATCH v2 10/10] rust: kernel: remove usage of `allocator_api` unstable feature
Date: Wed, 27 Mar 2024 17:19:18 +0000	[thread overview]
Message-ID: <2b148cfb-0557-46de-b39f-f2506eb17afd@proton.me> (raw)
In-Reply-To: <20240327023531.187880-11-wedsonaf@gmail.com>

On 27.03.24 03:35, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <walmeida@microsoft.com>
> 
> With the adoption of `BoxExt` and `VecExt`, we don't need the functions
> provided by this feature (namely the methods prefixed with `try_` and
> different allocator per collection instance).
> 
> We do need `AllocError`, but we define our own as it is a trivial empty
> struct.
> 
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---
>  rust/kernel/alloc.rs         | 4 ++++
>  rust/kernel/alloc/box_ext.rs | 3 +--
>  rust/kernel/alloc/vec_ext.rs | 4 ++--
>  rust/kernel/error.rs         | 4 ++--
>  rust/kernel/init.rs          | 3 +--
>  rust/kernel/lib.rs           | 1 -
>  rust/kernel/str.rs           | 3 +--
>  rust/kernel/sync/arc.rs      | 4 ++--
>  rust/kernel/workqueue.rs     | 3 +--
>  9 files changed, 14 insertions(+), 15 deletions(-)

Reviewed-by: Benno Lossin <benno.lossin@proton.me>

-- 
Cheers,
Benno


      reply	other threads:[~2024-03-27 17:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27  2:35 [PATCH v2 00/10] Allocation APIs Wedson Almeida Filho
2024-03-27  2:35 ` [PATCH v2 01/10] rust: kernel: move `allocator` module under `alloc` Wedson Almeida Filho
2024-03-27  2:35 ` [PATCH v2 02/10] rust: alloc: introduce the `VecExt` trait Wedson Almeida Filho
2024-03-27 16:45   ` Benno Lossin
2024-03-27  2:35 ` [PATCH v2 03/10] kbuild: use the upstream `alloc` crate Wedson Almeida Filho
2024-03-27  2:35 ` [PATCH v2 04/10] rust: alloc: remove our fork of the " Wedson Almeida Filho
2024-03-27  2:35 ` [PATCH v2 05/10] rust: alloc: introduce allocation flags Wedson Almeida Filho
2024-03-27  2:35 ` [PATCH v2 06/10] rust: alloc: introduce the `BoxExt` trait Wedson Almeida Filho
2024-03-27 17:09   ` Benno Lossin
2024-03-27 18:43     ` Wedson Almeida Filho
2024-03-27  2:35 ` [PATCH v2 07/10] rust: alloc: update `VecExt` to take allocation flags Wedson Almeida Filho
2024-03-27  3:48   ` Boqun Feng
2024-03-27 10:49     ` Miguel Ojeda
2024-03-27 18:19     ` Wedson Almeida Filho
2024-03-27  2:35 ` [PATCH v2 08/10] rust: sync: update `Arc` and `UniqueArc` " Wedson Almeida Filho
2024-03-27  2:35 ` [PATCH v2 09/10] rust: init: update `init` module " Wedson Almeida Filho
2024-03-27  2:35 ` [PATCH v2 10/10] rust: kernel: remove usage of `allocator_api` unstable feature Wedson Almeida Filho
2024-03-27 17:19   ` Benno Lossin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b148cfb-0557-46de-b39f-f2506eb17afd@proton.me \
    --to=benno.lossin@proton.me \
    --cc=a.hindborg@samsung.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=walmeida@microsoft.com \
    --cc=wedsonaf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).