From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14396C07E9E for ; Wed, 7 Jul 2021 21:03:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E517261CD7 for ; Wed, 7 Jul 2021 21:03:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232009AbhGGVGd (ORCPT ); Wed, 7 Jul 2021 17:06:33 -0400 Received: from gimli.kloenk.dev ([195.39.247.182]:49490 "EHLO gimli.kloenk.dev" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230033AbhGGVGd (ORCPT ); Wed, 7 Jul 2021 17:06:33 -0400 X-Greylist: delayed 411 seconds by postgrey-1.27 at vger.kernel.org; Wed, 07 Jul 2021 17:06:32 EDT Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kloenk.dev; s=mail; t=1625691419; bh=XvBNqB53b+UDSkntbWZIwDkF0py1FkstKOl/6BKenl4=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=IPvT50/Xp4G2h8l04mSx++YIcxglQIDHHizSnRO2ZnxX0PKbtV3D9ePnIgIMWwqMY M0D3v37ZhwzV/AqFmqfFk8iDnzVER6Ev6oNjjR5YRraEAQlkl5ffjXyhGKpp2U655J BR2ceK9WZPjRY5KFKG68TKJcpSOEo+7qWOR9wkD0= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: [PATCH 00/17] Rust support From: Finn Behrens In-Reply-To: Date: Wed, 7 Jul 2021 22:56:57 +0200 Cc: Wedson Almeida Filho , Miguel Ojeda , Christoph Hellwig , Miguel Ojeda , Linus Torvalds , rust-for-linux , Linux Kbuild mailing list , Linux Doc Mailing List , linux-kernel Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210704202756.29107-1-ojeda@kernel.org> To: Greg Kroah-Hartman Precedence: bulk List-ID: X-Mailing-List: rust-for-linux@vger.kernel.org > On 7. Jul 2021, at 17:02, Greg Kroah-Hartman = wrote: >=20 > On Wed, Jul 07, 2021 at 03:07:50PM +0100, Wedson Almeida Filho wrote: >>> Last I looked at this thing, it was not >>> feature-complete compared to the in-kernel binder code, has that = been >>> resolved and the needed filesystem changes added? >>=20 >> It is not feature-complete in comparison to the C one just yet, it is = missing a >> few things but not for any fundamental reason -- we were mostly = focusing on the >> kernel crate and tests. >=20 > I love it how you call "binderfs is missing" a "few things" :) >=20 >> Miguel's point is that it does implement the vast majority of binder = features >> and is non-trivial, so it could be used as evidence that useful = kernel drivers >> can be built with Rust; not just "transpiled" from C, but written = with the Rust >> safety guarantees. >=20 > As Christoph said, and I and others have said before, binder is in no > way shape or form anything that resembles any sort of "driver" at all. > It is a crazy IPC mechanism that is tacked onto the side of the = kernel. > Not to say that it doesn't have its usages, but the interactions = between > binder and the rest of the kernel are very small and specific. > Something that almost no one else will ever write again. >=20 > Please work on a real driver to help prove, or disprove, that this all > is going to be able to work properly. There are huge unanswered > questions that need to be resolved that you will run into when you do > such a thing. >=20 There is a more general use driver (network dummy) still in the making, = It is fully operational, just the documentation of the rust bindings are = not finished yet, so it is not merged into the rust tree yet, also I = have to rebase it. I testet the network dummy (dummyrs) driver and for stupid tests like = Iperf3 or ping it performed slightly better that the C version. See = https://github.com/Kloenk/linux/blob/rust-netdevice/drivers/net/dummy_rs.r= s for the actually driver. Yes this driver is still only virtually, but the network apis are = probably more general usage than the binder apis. > Good luck! >=20 > greg k-h CU, Finn